I agree with Kirk. A simple notice to the dev list to say what dependency and why it is being added, this would also be an opportunity to make sure the dependency is not using a Cat-X license [1].
--Mark [1] https://www.apache.org/legal/resolved.html#category-x On Tue, Jan 23, 2018 at 2:09 PM, Kirk Lund <kl...@apache.org> wrote: > Discussing the addition of new dependencies is something the community > should be doing on the dev-list regardless of how many git repos we have. > It's part of the Apache Way that we are beholden to as an Apache project. > > On Tue, Jan 23, 2018 at 11:25 AM, Udo Kohlmeyer <ukohlme...@pivotal.io> > wrote: > > > This really just another reason that we should be pushing for the > > separation of Geode into different (independent) modules with potentially > > separate repos. > > This way modules can advance and iterate faster without having to be > > influenced by external factors causing unrelated failures. > > > > I would push for this, rather than having to slow the whole development > > process down, whilst waiting for consensus on libraries used for external > > tooling. > > > > --Udo > > > > On Tue, Jan 23, 2018 at 11:15 AM, Kirk Lund <kl...@apache.org> wrote: > > > > > I have it working now. My IntelliJ project was using JDK1.8.0_66 for > > Gradle > > > which prevented updating of dependencies which then caused compilation > in > > > IntelliJ to fail on that new dependency. > > > > > > This doesn't resolve my main issue here which is this: *all new > > > dependencies should be discussed on the dev list before introducing > them > > in > > > a commit*. Can you please point me at an email that proposes adding > this > > > dependency? > > > > > > On Tue, Jan 23, 2018 at 10:10 AM, Anthony Baker <aba...@pivotal.io> > > wrote: > > > > > > > I just ran `gradle clean build` from HEAD and did not get any errors. > > > > > > > > > On Jan 23, 2018, at 10:08 AM, Jens Deppe <jde...@pivotal.io> > wrote: > > > > > > > > > > The dependency is the rmi-io library. It provides functionality for > > > > > streaming data over RMI. > > > > > > > > > > It was added a few weeks ago, so I'm not sure why your build is > > > breaking > > > > > now. > > > > > > > > > > --Jens > > > > > > > > > > On Tue, Jan 23, 2018 at 9:41 AM, Kirk Lund <kl...@apache.org> > wrote: > > > > > > > > > >> Looks like this dependency is Jackcess (used for reading and > writing > > > MS > > > > >> Access databases). I cannot find any discussion about adding this > > > > >> dependency on the dev-list. Why does Geode need to talk to MS > Access > > > > >> databases for Cluster Configuration? > > > > >> > > > > >> It does have an Apache 2.0 license, but I think there are two > > problems > > > > with > > > > >> adding Jackcess: 1) all new dependencies should be discussed on > > > dev-list > > > > >> BEFORE adding them to Geode, 2) we shouldn't need to talk to MS > > Access > > > > for > > > > >> Cluster Configuration. > > > > >> > > > > >> On Tue, Jan 23, 2018 at 9:30 AM, Kirk Lund <kl...@pivotal.io> > > wrote: > > > > >> > > > > >>> I just tried to compile Geode develop. > ClusterConfigurationService > > > has > > > > >> two > > > > >>> broken imports that don't exist: > > > > >>> > > > > >>> import com.healthmarketscience.rmiio.RemoteInputStream; > > > > >>> import com.healthmarketscience.rmiio.RemoteInputStreamClient; > > > > >>> > > > > >>> Was there a new dependency added to Geode? > > > > >>> > > > > >> > > > > > > > > > > > > > >
