Re: Review Request 58393: GEODE-2686: Remove JarClassLoader

2017-04-14 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58393/#review172023 --- Ship it! Ship It! - Kirk Lund On April 13, 2017, 11:33 p.m.,

Re: Review Request 58393: GEODE-2686: Remove JarClassLoader

2017-04-13 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58393/#review171971 --- Ship it! Ship It! - Jinmei Liao On April 13, 2017, 11:33 p.m

Re: Review Request 58393: GEODE-2686: Remove JarClassLoader

2017-04-13 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58393/ --- (Updated April 13, 2017, 11:33 p.m.) Review request for geode, Jinmei Liao, Ken

Re: Review Request 58393: GEODE-2686: Remove JarClassLoader

2017-04-13 Thread Jared Stewart
> On April 13, 2017, 7:13 p.m., Kirk Lund wrote: > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigBaseTest.java > > Lines 62 (patched) > > > > > > You might want to consider

Re: Review Request 58393: GEODE-2686: Remove JarClassLoader

2017-04-13 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58393/ --- (Updated April 13, 2017, 11:06 p.m.) Review request for geode, Jinmei Liao, Ken

Re: Review Request 58393: GEODE-2686: Remove JarClassLoader

2017-04-13 Thread Jared Stewart
> On April 13, 2017, 3:25 p.m., Jinmei Liao wrote: > > geode-core/src/test/java/org/apache/geode/management/DeployJarTestSuite.java > > Lines 27 (patched) > > > > > > by checking in this suite, would it cause the test

Re: Review Request 58393: GEODE-2686: Remove JarClassLoader

2017-04-13 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58393/#review171910 --- geode-core/src/test/java/org/apache/geode/internal/DeployedJarJUn

Re: Review Request 58393: GEODE-2686: Remove JarClassLoader

2017-04-13 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58393/#review171878 --- geode-core/build.gradle Lines 116 (patched)