-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58393/
-----------------------------------------------------------

(Updated April 13, 2017, 11:33 p.m.)


Review request for geode, Jinmei Liao, Ken Howe, Kirk Lund, and Patrick 
Rhomberg.


Repository: geode


Description
-------

GEODE-2686: Remove JarClassLoader
- Remove JarClassLoader
- Replace ClassPathLoader's collection of JarClassLoaders with a single 
URLClassLoader
- Change naming scheme for deployed jars from 'vf.gf#myJar.jar#1' to 
'myJar.v1.jar'

GEODE-2705: Jars undeployed from cluster configuration will not be loaded from 
disk on member restart

GEODE-2686: Add more logging to JarDeployer

GEODE-2290: Limit scanning of deployed jars
- Uses fast-classpath-scanner to scan jars for classes containing Functions 
without eagerly loading all classes in the jar.


Diffs (updated)
-----

  geode-assembly/build.gradle 304a1c4 
  geode-assembly/src/test/resources/expected_jars.txt b7d1dc2 
  geode-core/build.gradle 757599a 
  geode-core/src/main/java/org/apache/geode/internal/ClassPathLoader.java 
9ab7c30 
  geode-core/src/main/java/org/apache/geode/internal/DeployedJar.java 
PRE-CREATION 
  
geode-core/src/main/java/org/apache/geode/internal/InternalDataSerializer.java 
f4f4069 
  geode-core/src/main/java/org/apache/geode/internal/JarClassLoader.java 
9cd0589 
  geode-core/src/main/java/org/apache/geode/internal/JarDeployer.java 18d4b42 
  
geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java
 f904af1 
  
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
08f916b 
  
geode-core/src/main/java/org/apache/geode/internal/cache/persistence/BackupManager.java
 d052551 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DeployFunction.java
 5f1f161 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ListDeployedFunction.java
 8df24db 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/UndeployFunction.java
 3f05082 
  
geode-core/src/test/java/org/apache/geode/internal/ClassPathLoaderIntegrationTest.java
 c52d575 
  geode-core/src/test/java/org/apache/geode/internal/ClassPathLoaderTest.java 
6baddaf 
  geode-core/src/test/java/org/apache/geode/internal/DeployedJarJUnitTest.java 
PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/internal/JarClassLoaderJUnitTest.java 
adc1d2e 
  geode-core/src/test/java/org/apache/geode/internal/JarDeployerDUnitTest.java 
a365899 
  
geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java
 71daecc 
  
geode-core/src/test/java/org/apache/geode/internal/cache/IncrementalBackupDUnitTest.java
 0cc003e 
  geode-core/src/test/java/org/apache/geode/management/DeployJarTestSuite.java 
PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest.java
 PRE-CREATION 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandsDUnitTest.java
 7b0823b 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/UserCommandsDUnitTest.java
 24f5cdb 
  
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfig.java
 c3d7f5e 
  
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigBaseTest.java
 cecc8cf 
  
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigDeployJarDUnitTest.java
 7cc84d6 
  
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java
 696d22c 
  
geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigStartMemberDUnitTest.java
 652ec60 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
 0a4785d 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
 97c636b 
  
geode-core/src/test/resources/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest_FunctionATemplate
 PRE-CREATION 
  
geode-core/src/test/resources/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest_FunctionBTemplate
 PRE-CREATION 
  
geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/CommandOverHttpDUnitTest.java
 5f4cd74 
  gradle/dependency-versions.properties da8bdf2 


Diff: https://reviews.apache.org/r/58393/diff/4/

Changes: https://reviews.apache.org/r/58393/diff/3-4/


Testing
-------

- Precheckin passed
- Manually deployed jars and executed functions via gfsh


Thanks,

Jared Stewart

Reply via email to