Re: [Discuss] Compatibility with Apache Xerces

2017-08-21 Thread Jared Stewart
It sounds like these changes ought to be ok. If there is no objection, I will go ahead and pull them in this afternoon. Thanks, Jared > On Aug 21, 2017, at 9:09 AM, Jacob Barrett wrote: > > Looking into the legacy repo I can see that the fix for the StringBuffer > issue was not brought into

Re: [Discuss] Compatibility with Apache Xerces

2017-08-21 Thread Jacob Barrett
Looking into the legacy repo I can see that the fix for the StringBuffer issue was not brought into Geode. The fix was to specifically request the Oracle/Sun implementation. Since that implementation might not be available in the IBM JDK its probably not a great fix. On Fri, Aug 18, 2017 at 9:28

Re: [Discuss] Compatibility with Apache Xerces

2017-08-18 Thread Darren Foong
> You're right. This did come up with the IBM JDK and we fixed it. Not sure why > then it's coming up again. Could it be this? https://issues.apache.org/jira/browse/GEODE-135 Seems like a different issue with the IBM JDK though. I've just verified that the whitespace problem is still an issue wi

Re: [Discuss] Compatibility with Apache Xerces

2017-08-18 Thread Jacob Barrett
You're right. This did come up with the IBM JDK and we fixed it. Not sure why then it's coming up again. Sent from my iPhone On Aug 18, 2017, at 2:01 PM, Dan Smith wrote: >> Since the oracle parser is always going to be there I don't see any harm > in doing that. > > That's not true if we're

Re: [Discuss] Compatibility with Apache Xerces

2017-08-18 Thread Kirk Lund
I think it's fine to add Xerces as a test runtime dependency. The fix to CacheXmlParser.java looks good to me! On Thu, Aug 17, 2017 at 11:35 PM, Darren Foong wrote: > Hi all, > > I'm using Geode in an applicat

Re: [Discuss] Compatibility with Apache Xerces

2017-08-18 Thread Dan Smith
> Since the oracle parser is always going to be there I don't see any harm in doing that. That's not true if we're running on non-oracle JDKs, right? I remember a while back someone was trying to run geode on IBMs JDK and having issues - maybe even this same whitespace problem? I think it this fi

Re: [Discuss] Compatibility with Apache Xerces

2017-08-18 Thread Jacob Barrett
I could have sworn at one point the the cache xml parser explicitly requested the oracle parser. Since the oracle parser is always going to be there I don't see any harm in doing that. A better fix might be to just normalize the white space when parsing. I also recall xerces having a flag for

Re: [Discuss] Compatibility with Apache Xerces

2017-08-18 Thread Anilkumar Gingade
Why worry is claiming to support multiple version; and trying to manage/maintain it... -Anil. On Thu, Aug 17, 2017 at 11:35 PM, Darren Foong wrote: > Hi all, > > I'm using Geode in an application that uses the Apache implementation > of Xerces. The Oracle JDK comes with its own implementation