ome otherwise very-readable code.
>
>From: Blake Bender
>Date: Monday, May 3, 2021 at 11:23 AM
> To: dev@geode.apache.org
>Subject: RE: DISCUSSION: Geode Native C++ Style and Formatting Guide
>My $0.02 on these:
>
>Things I'd like to see us con
eode.apache.org
Subject: RE: DISCUSSION: Geode Native C++ Style and Formatting Guide
My $0.02 on these:
Things I'd like to see us conform to Google style on:
* I'd be happy to move to C++ 17
* Would also be happy to remove forward declarations. "I'm not a c
> On May 4, 2021, at 7:59 AM, Mario Salazar de Torres
> wrote:
>
> Sure, gladly 🙂. Let me put up the info and I will open the discussion.
> And sorry for polluting this topic regarding Style and Formatting :S
No apologies! I just think this topic has a much bigger scope than documenting
our
imple trailing "_",
> perhaps fixed some of the more egregious and weird abbreviations, etc. My
> preference for bug fixes and feature work is that all of the code changes be
> focused on stuff that's relevant to the fix/feature, and mixing it with
> random style guide
dard for the project as it has
> several cool features, but sadly I must admit is too recent to be adopted.
>
> Thanks,
> Mario.
>
> From: Blake Bender
> Sent: Monday, May 3, 2021 8:23 PM
> To: dev@geode.apache.org
> Subject: RE: DISCU
nges be focused on
stuff that's relevant to the fix/feature, and mixing it with random style guide
refactoring, I feel, muddies the waters for future maintainers.
Thanks,
Blake
-----Original Message-
From: Jacob Barrett
Sent: Saturday, May 1, 2021 9:21 AM
To: dev@geode.apache.org
Sub
> On May 3, 2021, at 11:23 AM, Blake Bender wrote:
>
> My $0.02 on these:
>
> Things I'd like to see us conform to Google style on:
> * I'd be happy to move to C++ 17
This is likely an ABI change and certainly moves the minimum runtime library.
The latter might be hard in a minor release.
>
ng-tidy?) of mangling some otherwise very-readable code.
>
> From: Blake Bender
> Date: Monday, May 3, 2021 at 11:23 AM
> To: dev@geode.apache.org
> Subject: RE: DISCUSSION: Geode Native C++ Style and Formatting Guide
> My $0.02 on these:
>
> Things I'd like to see us con
80 characters also feels arbitrary, especially with auto-formatters
(clang-tidy?) of mangling some otherwise very-readable code.
From: Blake Bender
Date: Monday, May 3, 2021 at 11:23 AM
To: dev@geode.apache.org
Subject: RE: DISCUSSION: Geode Native C++ Style and Formatting Guide
My $0.02 on
elevant to the fix/feature, and mixing it with random style guide
refactoring, I feel, muddies the waters for future maintainers.
Thanks,
Blake
-Original Message-----
From: Jacob Barrett
Sent: Saturday, May 1, 2021 9:21 AM
To: dev@geode.apache.org
Subject: Re: DISCUSSION: Geode Native C++
Great call outs!
> On May 1, 2021, at 7:57 AM, Mario Salazar de Torres
> wrote:
>
> 1. Member variables names as of Google style guide requires a '_' char to
> be added at the end so it can be identified. Should we also adopt that?
> For example, imagine you have a region mutex, so, should w
only used when there is no alternative"?
Thanks,
Mario.
From: Jacob Barrett
Sent: Saturday, May 1, 2021 2:31 AM
To: dev@geode.apache.org
Subject: DISCUSSION: Geode Native C++ Style and Formatting Guide
Team,
We haven’t been good about documenting our style
Team,
We haven’t been good about documenting our style and formatting guidance. Like
the Java sources are loosely styled after the Google Java Style Guide, the C++
sources are loosely styled after the Google C++ Style Guide. We deviate in some
places from the Google C++ Style Guide. Without the
13 matches
Mail list logo
