Great call outs! > On May 1, 2021, at 7:57 AM, Mario Salazar de Torres > <mario.salazar.de.tor...@est.tech> wrote: > > 1. Member variables names as of Google style guide requires a '_' char to > be added at the end so it can be identified. Should we also adopt that? > For example, imagine you have a region mutex, so, should we name it as > 'regionMutex_' ?
I didn’t mention this one out in my review of differences because we are following it but I suppose with the combination of the camelCase difference we should probably call it out more specifically. Perhaps in our documentation we should show examples of both local and member variables. Do you think that will make it more clear? > 2. Also, I would like to point out that macros are dis-recommended but > every C++ committee member I know. > What do you think about adding a notice saying: "Macros should be avoided and > only used when there is no alternative”? I think that is called out in various ways in a few places in the Google guide but I am more than happy for us to include strong or clearer language around this. Between constexpr and templates there are very cases for macros anymore. We mostly use macros only to handle non-standard attributes. When we move to C++17 a lot of these will go away. Thanks, Jake
