t;
> Also, since we are deprecating "load-cluster-configuration-dir", should
> we also deprecate "-cluster-config-dir" as well. Is there any need for
> users to persist the cluster configuration in a place other than the
> working dir?
>
> On Thu, Apr 5
+1 for deprecating "--load-cluster-configuration-dir" option in favor of
"import cluster-configuration" for a more explicit intention.
Also, since we are deprecating "load-cluster-configuration-dir", should we
also deprecate "-cluster-config-dir" as well
All,
Currently this option takes (true/false, defaults to false) to let locator
load cluster configuration from a specified directory provided with other
option '--cluster-config-dir'. Also `--cluster-config-dir` is used to
create the persistent disk store to store configuration regi
p.m.)
>
>
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe,
> and Patrick Rhomberg.
>
>
> Bugs: GEODE-3062
> https://issues.apache.org/jira/browse/GEODE-3062
>
>
> Repository: geode
>
>
> Description
> --
Liao, Jared Stewart, Ken Howe, and
Patrick Rhomberg.
Changes
---
Address review issues from Jinmei.
Bugs: GEODE-3062
https://issues.apache.org/jira/browse/GEODE-3062
Repository: geode
Description
---
Fixes:
a) moved deployment of cluster config jars back to initalize after
t;
> (Updated June 15, 2017, 11:44 p.m.)
>
>
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe,
> and Patrick Rhomberg.
>
>
> Bugs: GEODE-3062
> https://issues.apache.org/jira/browse/GEODE-3062
>
>
> Repository: geode
>
>
11:44 p.m.)
>
>
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe,
> and Patrick Rhomberg.
>
>
> Bugs: GEODE-3062
> https://issues.apache.org/jira/browse/GEODE-3062
>
>
> Repository: geode
>
>
> Description
>
Cache create have no GemFireCacheImpl singleton but they do
> have a InternalDistributedSystem singleton)
>
> Add new test to ClusterConfigWithSecurityDUnitTest that fails due to bug
> GEODE-3062.
>
> Remove unused Cache param from applyClusterPropertiesConfiguration so it can
> be called duri
Rhomberg.
Bugs: GEODE-3062
https://issues.apache.org/jira/browse/GEODE-3062
Repository: geode
Description
---
Fixes:
a) moved deployment of cluster config jars back to initalize after
ClassPathLoader
b) added DistributedSystem#disconnect to ServerStarterRule "after" (tests w
gt; Add new test to ClusterConfigWithSecurityDUnitTest that fails due to bug
> GEODE-3062.
>
> Remove unused Cache param from applyClusterPropertiesConfiguration so it can
> be called during Cache construction.
>
> Move cluster config request to Cache construction and handle
Are you sure that we want to keep this response around as a member
> > variable? I'm afraid that it might be stale (in the sense that the cluster
> > config has since been changed) if this response is referred to later on.
>
> Kirk Lund wrote:
> Please see the new diff
>
> Add new test to ClusterConfigWithSecurityDUnitTest that fails due to bug
> GEODE-3062.
>
> Remove unused Cache param from applyClusterPropertiesConfiguration so it can
> be called during Cache construction.
>
> Move cluster config request to Cache construction and ha
curityDUnitTest that fails due to bug
> GEODE-3062.
>
> Remove unused Cache param from applyClusterPropertiesConfiguration so it can
> be called during Cache construction.
>
> Move cluster config request to Cache construction and handle jars and
> properties there. Create new Securit
-
>
> Add new test to ClusterConfigWithSecurityDUnitTest that fails due to bug
> GEODE-3062.
>
> Remove unused Cache param from applyClusterPropertiesConfiguration so it can
> be called during Cache construction.
>
> Move cluster config request to Cache construct
> Add new test to ClusterConfigWithSecurityDUnitTest that fails due to bug
> GEODE-3062.
>
> Remove unused Cache param from applyClusterPropertiesConfiguration so it can
> be called during Cache construction.
>
> Move cluster config request to Cache construction and handle
> Add new test to ClusterConfigWithSecurityDUnitTest that fails due to bug
> GEODE-3062.
>
> Remove unused Cache param from applyClusterPropertiesConfiguration so it can
> be called during Cache construction.
>
> Move cluster config request to Cache construction and handle
Are you sure that we want to keep this response around as a member
> > variable? I'm afraid that it might be stale (in the sense that the cluster
> > config has since been changed) if this response is referred to later on.
Please see the new diff. I changed it from final to volatil
geode
Description
---
Add new test to ClusterConfigWithSecurityDUnitTest that fails due to bug
GEODE-3062.
Remove unused Cache param from applyClusterPropertiesConfiguration so it can be
called during Cache construction.
Move cluster config request to Cache construction and handle jar
/GemFireCacheImpl.java
Lines 327 (patched)
<https://reviews.apache.org/r/60010/#comment251349>
Are you sure that we want to keep this response around as a member
variable? I'm afraid that it might be stale (in the sense that the cluster
config has since been changed) if this response is
> Add new test to ClusterConfigWithSecurityDUnitTest that fails due to bug
> GEODE-3062.
>
> Remove unused Cache param from applyClusterPropertiesConfiguration so it can
> be called during Cache construction.
>
> Move cluster config request to Cache construction and handle
called during Cache construction.
Move cluster config request to Cache construction and handle jars and
properties there. Create new SecurityService in constructor and overwrite the
SecurityService in InternalDistributedSystem.
NOTE: We will later have to fix GEODE-3061 by moving cluster config
bounce the cluster as opposed to performing a rolling restart of the
cluster with that property changed. I think the quickest way for us to get
there is to make the connection a two step process, connect just to get the
properties from the cluster config avoiding any validation, then reconnect
using the
The usage of CacheFactory#setSecurityManager (and setPostProcessor) is
working as expected, both before and after my changes!
The problem is that Cluster Config is requested during Cache initialization
which means that any gemfire.properties stored in Cluster Config will not
be used by
/cache/CacheFactory.java#L355-L368
On Fri, Jun 9, 2017 at 1:11 PM, Kirk Lund wrote:
> Yeah I think we need #2 in the long run. Right now nearly all of the
> gemfire.properties are ignored if you use Cluster Config. The few
> gemfire.properties that are mutable by RuntimeDistributionConfigImpl will
>
Yeah I think we need #2 in the long run. Right now nearly all of the
gemfire.properties are ignored if you use Cluster Config. The few
gemfire.properties that are mutable by RuntimeDistributionConfigImpl will
work when used in Cluster Config -- I believe all other gemfire.properties
would be
I've reverted my change on release/1.2.0.
I'm currently planning to work on #1 on develop in the short term.
On Fri, Jun 9, 2017 at 12:45 PM, Kirk Lund wrote:
> The new changes for SecurityService don't work with Cluster Config. We
> only had one test that would've f
+1 for #2. It does seem more correct
On 6/9/17 12:45, Kirk Lund wrote:
The new changes for SecurityService don't work with Cluster Config. We only
had one test that would've failed but it was annotated with @Ignore.
The problem is this:
The security-manager is a gemfire property
The new changes for SecurityService don't work with Cluster Config. We only
had one test that would've failed but it was annotated with @Ignore.
The problem is this:
The security-manager is a gemfire property and is now used by the
InternalDistributedSystem because member
Dave Barnes created GEODE-2976:
--
Summary: gfsh 'export cluster-config' behavior does not match
online help
Key: GEODE-2976
URL: https://issues.apache.org/jira/browse/GEODE-2976
Proj
[
https://issues.apache.org/jira/browse/GEODE-2369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jared Stewart resolved GEODE-2369.
--
Resolution: Fixed
> Exporting cluster-config with just a filename throws an
[
https://issues.apache.org/jira/browse/GEODE-2764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
nabarun resolved GEODE-2764.
Resolution: Fixed
Fix Version/s: 1.2.0
> Index entry not entered into cluster config xml if reg
uest at:
https://github.com/apache/geode/pull/449
> Index entry not entered into cluster config xml if region name contains a
> function call like entrySet()
> ---
>
>
clause is substring-ed at '.' from the right
* Each substing is checked to see if the region name is valid.
This closes #449
> Index entry not entered into cluster config xml if region name contains a
> fu
InFromClauseMustPersist?
> Index entry not entered into cluster config xml if region name contains a
> function call like entrySet()
> ---
>
> Key: GEODE-2764
&g
the issue:
https://github.com/apache/geode/pull/449
@jhuynh1
I have the changes you mentioned and also added a dunit test to confirm the
behaviour
> Index entry not entered into cluster config xml if region name contains a
> function call lik
s fixed now.
thank you !!
> Index entry not entered into cluster config xml if region name contains a
> function call like entrySet()
> ---
>
> Key: GE
gionPath is null, will cache.getRegion(regionPath) throw an exception?
Shouldn't the regionPath check for null be first?
> Index entry not entered into cluster config xml if region name contains a
* If there are no '.' left to substring on, send region not found
exception.
----
> Index entry not entered into cluster config xml if region name contains a
> function call like entrySet()
> -
[
https://issues.apache.org/jira/browse/GEODE-2764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
nabarun updated GEODE-2764:
---
Summary: Index entry not entered into cluster config xml if region name
contains a function call like
nabarun created GEODE-2764:
--
Summary: Index entry not entered into cluster config xml if region
name contains a function call like entry set
Key: GEODE-2764
URL: https://issues.apache.org/jira/browse/GEODE-2764
Barry Oglesby created GEODE-2688:
Summary: The Lucene xml in the cluster config includes the
internal async event queue id
Key: GEODE-2688
URL: https://issues.apache.org/jira/browse/GEODE-2688
[
https://issues.apache.org/jira/browse/GEODE-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hitesh Khamesra closed GEODE-2229.
--
> Backup old cluster config before importing new
[
https://issues.apache.org/jira/browse/GEODE-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hitesh Khamesra updated GEODE-2229:
---
Fix Version/s: (was: 1.1.0)
1.2.0
> Backup old cluster config bef
. 10, 2017, 12:57 a.m.)
>
>
> Review request for geode, Jared Stewart, Kevin Duling, Kirk Lund, and Swapnil
> Bawaskar.
>
>
> Repository: geode
>
>
> Description
> ---
>
> GEODE-2198: do not import cluster config if any region exists to prevent
> differe
mmit de135a45e18c5351a665dda91aa6ea461fafe4c6 in geode's branch
refs/heads/develop from [~jinmeiliao]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=de135a4 ]
GEODE-2198: do not import cluster config if any region exists to prevent
different servers having conflicing region definitio
. 10, 2017, 12:57 a.m.)
>
>
> Review request for geode, Jared Stewart, Kevin Duling, Kirk Lund, and Swapnil
> Bawaskar.
>
>
> Repository: geode
>
>
> Description
> ---
>
> GEODE-2198: do not import cluster config if any region exists to prevent
> different se
eb. 9, 2017, 4:57 p.m.)
>
>
> Review request for geode, Jared Stewart, Kevin Duling, Kirk Lund, and Swapnil
> Bawaskar.
>
>
> Repository: geode
>
>
> Description
> ---
>
> GEODE-2198: do not import cluster config if any region exists to prevent
> different se
. 10, 2017, 12:57 a.m.)
>
>
> Review request for geode, Jared Stewart, Kevin Duling, Kirk Lund, and Swapnil
> Bawaskar.
>
>
> Repository: geode
>
>
> Description
> ---
>
> GEODE-2198: do not import cluster config if any region exists to prevent
> different se
Bawaskar.
Repository: geode
Description
---
GEODE-2198: do not import cluster config if any region exists to prevent
different servers having conflicing region definitions at one point of time.
Diffs
-
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands
[
https://issues.apache.org/jira/browse/GEODE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hitesh Khamesra closed GEODE-2196.
--
> Write more tests to cover the current behavior of cluster con
[
https://issues.apache.org/jira/browse/GEODE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hitesh Khamesra closed GEODE-2198.
--
> import cluster-config should continue if the running servers have no data in
> their appli
[
https://issues.apache.org/jira/browse/GEODE-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hitesh Khamesra closed GEODE-2197.
--
> Refactor cluster config so that cluster.xml and properties don't need to be
> saved
[
https://issues.apache.org/jira/browse/GEODE-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hitesh Khamesra closed GEODE-2261.
--
> refactor ClusterConfigWriter do not need to use remote call to change cluster
>
mmit 9a774862007722e0f57b94b7dd9c4d76cb56db6e in geode's branch
refs/heads/develop from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=9a77486 ]
GEODE-2369: Remove --dir option from export cluster-config
This closes #374
> Exporting cluster-config with just a filena
the issue:
https://github.com/apache/geode/pull/374
Precheckin passed
> Exporting cluster-config with just a filename throws an NPE
> ---
>
> Key: GEODE-2369
> URL: https://iss
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/374
Precheckin passed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/374
`HelpCommandsIntegrationTest` failed in precheckin. I've pushed a change
to the properties file used by that test and started a new precheckin.
---
If your project is set up for it, you can re
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/374
Precheckin started
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes s
)
> status locator should succeed even if cluster config is not ready
> -
>
> Key: GEODE-2374
> URL: https://issues.apache.org/jira/browse/GEODE-2374
> Project: Geode
>
ExportClusterConfigurationCommand gfsh)
> Exporting cluster-config with just a filename throws an NPE
> ---
>
> Key: GEODE-2369
> URL: https://issues.apache.org/jira/browse/GEODE-2369
>
[
https://issues.apache.org/jira/browse/GEODE-2369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk Lund updated GEODE-2369:
-
Component/s: management
> Exporting cluster-config with just a filename throws an
[
https://issues.apache.org/jira/browse/GEODE-2369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk Lund updated GEODE-2369:
-
Labels: ClusterConfig ExportClusterConfigurationCommand gfsh (was: )
> Exporting cluster-config w
if cluster config is not ready
> -
>
> Key: GEODE-2374
> URL: https://issues.apache.org/jira/browse/GEODE-2374
> Project: Geode
> Issue Type: Bug
> C
[
https://issues.apache.org/jira/browse/GEODE-2374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk Lund updated GEODE-2374:
-
Component/s: configuration
> status locator should succeed even if cluster config is not re
tor should succeed even if cluster config is not ready
> -
>
> Key: GEODE-2374
> URL: https://issues.apache.org/jira/browse/GEODE-2374
> Project: Geode
>
[
https://issues.apache.org/jira/browse/GEODE-2374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk Lund updated GEODE-2374:
-
Component/s: management
> status locator should succeed even if cluster config is not re
[
https://issues.apache.org/jira/browse/GEODE-2374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk Lund reassigned GEODE-2374:
Assignee: Kirk Lund
> status locator should succeed even if cluster config is not re
[
https://issues.apache.org/jira/browse/GEODE-2374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk Lund updated GEODE-2374:
-
Affects Version/s: (was: 1.0.0-incubating.M1)
> status locator should succeed even if cluster con
Kirk Lund created GEODE-2374:
Summary: status locator should succeed even if cluster config is
not ready
Key: GEODE-2374
URL: https://issues.apache.org/jira/browse/GEODE-2374
Project: Geode
[
https://issues.apache.org/jira/browse/GEODE-2374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk Lund updated GEODE-2374:
-
Affects Version/s: 1.0.0-incubating.M1
> status locator should succeed even if cluster config is
[
https://issues.apache.org/jira/browse/GEODE-2374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk Lund updated GEODE-2374:
-
Labels: StatusLocatorCommand (was: )
> status locator should succeed even if cluster config is not re
[
https://issues.apache.org/jira/browse/GEODE-2369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Duling updated GEODE-2369:
Assignee: Jared Stewart
> Exporting cluster-config with just a filename throws an
Kevin Duling created GEODE-2369:
---
Summary: Exporting cluster-config with just a filename throws an
NPE
Key: GEODE-2369
URL: https://issues.apache.org/jira/browse/GEODE-2369
Project: Geode
g cluster config first check if there is any non-empty region
* close and re-create cache if no data exists when importing new cluster
configuration
* put the acquire/release lock inside the ClusterConfigurationService instead
of command execution strategy.
> import cluster-config should con
[
https://issues.apache.org/jira/browse/GEODE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jinmei Liao reassigned GEODE-2196:
--
Assignee: Jinmei Liao
> Write more tests to cover the current behavior of cluster con
[
https://issues.apache.org/jira/browse/GEODE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jinmei Liao resolved GEODE-2198.
Resolution: Fixed
Fix Version/s: 1.1.0
> import cluster-config should continue if
[
https://issues.apache.org/jira/browse/GEODE-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jinmei Liao reassigned GEODE-2198:
--
Assignee: Jinmei Liao (was: Kirk Lund)
> import cluster-config should continue if the runn
mmit 6f418be119d72704215b73e13de902057b18ad4a in geode's branch
refs/heads/develop from [~jinmeiliao]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=6f418be ]
GEODE-2198: close and re-create the cache on a server when importing new
cluster configuration
* When importing cluster con
Jinmei Liao created GEODE-2315:
--
Summary: Improve cluster config: starting a second locator which
joins a locator with cluster configuration should inherit the first locator's
security settings.
Key: GEODE-2315
use remote call to change cluster
> config
>
>
> Key: GEODE-2261
> URL: https://issues.apache.org/jira/browse/GEODE-2261
> Project: Geode
>
ment? Are you saying that we can't
recreate the region with different attribute even if there is no data existing
in the region?
> import cluster-config should continue if the running servers have no data in
> their appl
o
core's test
> refactor ClusterConfigWriter do not need to use remote call to change cluster
> config
>
>
> Key: GEODE-2261
> URL: https://iss
rify that the region attributes match what is being imported.
3. if the attributes are different, then throw an error and do not import.
> import cluster-config should continue if the running servers have no data in
> their applicati
need to use remote call to change cluster
> config
>
>
> Key: GEODE-2261
> URL: https://issues.apache.org/jira/browse/GEODE-2261
> Project: Geode
&
[
https://issues.apache.org/jira/browse/GEODE-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jinmei Liao updated GEODE-2197:
---
Fix Version/s: 1.1.0
> Refactor cluster config so that cluster.xml and properties don't ne
[
https://issues.apache.org/jira/browse/GEODE-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jinmei Liao updated GEODE-2229:
---
Fix Version/s: 1.1.0
> Backup old cluster config before importing new
[
https://issues.apache.org/jira/browse/GEODE-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jinmei Liao updated GEODE-2229:
---
Assignee: Jared Stewart (was: Jinmei Liao)
> Backup old cluster config before importing new
[
https://issues.apache.org/jira/browse/GEODE-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jinmei Liao reassigned GEODE-2229:
--
Assignee: Jinmei Liao
> Backup old cluster config before importing new
[
https://issues.apache.org/jira/browse/GEODE-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jinmei Liao resolved GEODE-2229.
Resolution: Fixed
> Backup old cluster config before importing new
Jinmei Liao created GEODE-2262:
--
Summary: Improve cluster config: do not allow mix of locators that
has CC enabled and not enabled in one cluster.
Key: GEODE-2262
URL: https://issues.apache.org/jira/browse/GEODE
[
https://issues.apache.org/jira/browse/GEODE-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jinmei Liao resolved GEODE-2197.
Resolution: Fixed
> Refactor cluster config so that cluster.xml and properties don't ne
nge cluster
> config
>
>
> Key: GEODE-2261
> URL: https://issues.apache.org/jira/browse/GEODE-2261
> Project: Geode
> Issue Type: Sub-ta
mmit 30891423d83bdc50dc4316206bbea6c87553faae in geode's branch
refs/heads/develop from [~jinmeiliao]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=3089142 ]
GEODE-2197: refactor cluster config and fix the test failures
> Refactor cluster config so that cluster.xml and propertie
mmit 07ed46544634f4165c1c5f1792061f0a556655d8 in geode's branch
refs/heads/develop from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=07ed465 ]
GEODE-2197: refactor cluster config
* not to save the xml, properties in the file system.
* the cc region's change
[
https://issues.apache.org/jira/browse/GEODE-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jinmei Liao updated GEODE-2261:
---
Summary: refactor ClusterConfigWriter do not need to use remote call to
change cluster config (was
> On Tue, Jan 3, 2017 at 10:29 AM Jinmei Liao wrote:
> > >
> > > > Ok, currently we have 2 issues:
> > > > 1) a cluster might have a mix of locators with and without CC
> enabled.
> > > The
> > > > change proposed is to reject locator that does not C
Ok, currently we have 2 issues:
> > > 1) a cluster might have a mix of locators with and without CC enabled.
> > The
> > > change proposed is to reject locator that does not CC enabled to join a
> > > locator that has CC enabled (or vise versa).
> > > 2
> > 1) a cluster might have a mix of locators with and without CC enabled.
> The
> > change proposed is to reject locator that does not CC enabled to join a
> > locator that has CC enabled (or vise versa).
> > 2) commands that change CC does remote calls to a locator with
ues:
> 1) a cluster might have a mix of locators with and without CC enabled. The
> change proposed is to reject locator that does not CC enabled to join a
> locator that has CC enabled (or vise versa).
> 2) commands that change CC does remote calls to a locator with CC to change
>
change
the cluster config. The change proposed is to simply do it on the current
locator.
Fix for issue 2 is NOT a workaround for issue 1, it's a step towards fixing
issue 1. No matter we fix issue 1 or not, change for issue 2 is needed.
On Tue, Jan 3, 2017 at 10:18 AM, Jacob Barrett wrote:
&
1 - 100 of 181 matches
Mail list logo
