> On June 15, 2017, 11:47 p.m., Jinmei Liao wrote: > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java > > Lines 132 (patched) > > <https://reviews.apache.org/r/60125/diff/1/?file=1752116#file1752116line137> > > > > I am surprised that server.stop() does not call this ds.stop(). > > > > would this also apply to LocatorStarterRule as well? If so, we should > > add this block to the parent's class(MemberStarterRule)'s stop() method.
CacheServer.stop() only stops a CacheServer instance. The Cache and DistributedSystem both remain open. - Kirk ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60125/#review178065 ----------------------------------------------------------- On June 15, 2017, 11:44 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60125/ > ----------------------------------------------------------- > > (Updated June 15, 2017, 11:44 p.m.) > > > Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, > and Patrick Rhomberg. > > > Bugs: GEODE-3062 > https://issues.apache.org/jira/browse/GEODE-3062 > > > Repository: geode > > > Description > ------- > > Fixes: > a) moved deployment of cluster config jars back to initalize after > ClassPathLoader > b) added DistributedSystem#disconnect to ServerStarterRule "after" (tests > which fail during Cache create have no GemFireCacheImpl singleton but they do > have a InternalDistributedSystem singleton) > > Add new test to ClusterConfigWithSecurityDUnitTest that fails due to bug > GEODE-3062. > > Remove unused Cache param from applyClusterPropertiesConfiguration so it can > be called during Cache construction. > > Move cluster config request to Cache construction and handle jars and > properties there. Create new SecurityService in constructor and overwrite the > SecurityService in InternalDistributedSystem. > > NOTE: We will later have to fix GEODE-3061 by moving cluster config request > from Cache to InternalDistributedSystem construction so that IDS can be > created with gemfire.properties from cluster config. At that time we would > rip out both cluster config request and creation of security service from > Cache construction and pass both into Cache construction. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java > 22edb6f06c7791929cc9a033ca1a1bfed5751a47 > > geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java > 4f4881fe39116faa505bc2fbec74efd669efe0ef > > geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java > 40df0c7dcac8827a381c268c1f90e6acfb97a7f1 > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigWithSecurityDUnitTest.java > c551ca9104a85dcf54c0bebbc4178fce4114a416 > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java > fa3e8c0f0bb2fdbf55724e1ba78de7babb5f01b8 > > > Diff: https://reviews.apache.org/r/60125/diff/1/ > > > Testing > ------- > > precheckin in progress > > > Thanks, > > Kirk Lund > >
