Re: Changing external methods to no longer throw UnsupportedOperationException

2019-05-23 Thread Darrel Schneider
This particular method, Region.getStatistics, when called on a client does not send a message to the server. So it returns a stats object describing the region on the client. So this would not change the behaviour on a client running an older version of geode. On Thu, May 23, 2019 at 1:00 PM Owen

Re: Changing external methods to no longer throw UnsupportedOperationException

2019-05-23 Thread Owen Nichols
+1 I see no semantic difference between adding a new method vs implementing a stub that previously threw UnsupportedOperationException > On May 23, 2019, at 12:56 PM, Udo Kohlmeyer wrote: > > +1 to implementing this method. > > There is no plausible reason NOT to implement this. > > --Udo >

Re: Changing external methods to no longer throw UnsupportedOperationException

2019-05-23 Thread Udo Kohlmeyer
+1 to implementing this method. There is no plausible reason NOT to implement this. --Udo On 5/23/19 12:44, Dan Smith wrote: +1 to implementing this method in a minor release. I'm with Jake on this one. Every bug we fix changes the behavior of the product in some small way. This seems like a

Re: Changing external methods to no longer throw UnsupportedOperationException

2019-05-23 Thread Dan Smith
+1 to implementing this method in a minor release. I'm with Jake on this one. Every bug we fix changes the behavior of the product in some small way. This seems like a behavior change for the better - I can't picture a use case where someone is actually *relying* on this method throwing Unsupporte

Re: Changing external methods to no longer throw UnsupportedOperationException

2019-05-23 Thread Anilkumar Gingade
I agree, this may not look like the usecase that one would be using or depending. Going with the backward compatibility requirement this will be breaking that contract. Again, based on the scenario and usecases, there could be exceptions. I am trying to see if the versioning support that's used to

Re: Changing external methods to no longer throw UnsupportedOperationException

2019-05-23 Thread Jacob Barrett
But what application is going to legitimately call this method and expect that it throw an exception? What would be the function of that usage? If you assume that calling this method under these conditions had no value and would therefor never have been called then one could argue that implement

Re: Changing external methods to no longer throw UnsupportedOperationException

2019-05-23 Thread Anilkumar Gingade
As this changes the behavior on the existing older application; it seems to break the backward compatibility requirements. We use client versions to keep the contracts/behavior same for older client; can we do the same here. -Anil. On Thu, May 23, 2019 at 8:33 AM Darrel Schneider wrote: > Is i

Changing external methods to no longer throw UnsupportedOperationException

2019-05-23 Thread Darrel Schneider
Is it okay, in a minor release, to implement Region.getStatistics for partitioned regions? See GEODE-2685. The current behavior is for it to always throw UnsupportedOperationException. I doubt that any application is depending on that behavior but it could be. I know we have seen changes like this