errata
On Fri, Feb 7, 2020 at 10:36 AM Ernest Burghardt
wrote:
> There appears to be consensus that this is a critical fix.
>
> The following commit has been brought into release/1.12 as the critical fix
> for GEODE-7752:
>
> git cherry-pick -x 7028f601680fee3f57cbdff63951128d7180ca13
> git che
There appears to be consensus that this is a critical fix.
The following commit has been brought into release/1.12 as the
critical fix for GEODE-7752:
git cherry-pick -x 7028f601680fee3f57cbdff63951128d7180ca13
git cherry-pick -x 9c102e4f8836ca32ad51a05bbd4d0107e8fc0343
GEODE- has been marke
Hi there EB,
fix has been merged to develop. (Everything is green now)
9c102e4f8836ca32ad51a05bbd4d0107e8fc0343
Thanks
--Udo
0On 2/5/20 4:34 PM, Ernest Burghardt wrote:
Fair enough Udo, just let us know when you have it ready.
Thanks,
EB
On Wed, Feb 5, 2020 at 4:31 PM Udo Kohlmeyer wrote:
Fair enough Udo, just let us know when you have it ready.
Thanks,
EB
On Wed, Feb 5, 2020 at 4:31 PM Udo Kohlmeyer wrote:
> My apologies.. I had paid further attention to this, after I made
> changes to the assembly-context.txt file.
>
> I will revert now and then come back when it passes all te
My apologies.. I had paid further attention to this, after I made
changes to the assembly-context.txt file.
I will revert now and then come back when it passes all test requirements.
--Udo
On 2/5/20 4:14 PM, Ernest Burghardt wrote:
Udo,
the PR has some failing tests that are in the "non-mand
Thanks for the additional context, Udo! That makes a lot of sense.
I want to make sure we are very deliberate about including anything but a
critical fix in a release branch after it has been cut.
+1 to including Udo's change once we feel confident about the tests
On Wed, Feb 5, 2020 at 4:27 PM
Hi Ernie,
Thanks for the heads up. This is breaking DistributedTestOpenJDK and Udo
confirmed the are of concern and is going to revert this.
Thanks,
Mark
> On Feb 5, 2020, at 4:14 PM, Ernest Burghardt wrote:
>
> Udo,
> the PR has some failing tests that are in the "non-mandatory" category fo
Even though the management service is still marketed as "experimental" and
we don't need to go through deprecations, I would still very much prefer
this gets pulled into 1.12 so that users don't have to deal with
experimental public API changes.
On Wed, Feb 5, 2020 at 4:23 PM Udo Kohlmeyer wrote:
+1
Getting it right the first time will definitely save us pains down the road.
> On Feb 5, 2020, at 4:23 PM, Udo Kohlmeyer wrote:
>
> @Alexander, I can most certainly elaborate more.
>
> In short, this refactor does not have to be in 1.12, but it does alter public
> Builders and classes. Whi
@Alexander, I can most certainly elaborate more.
In short, this refactor does not have to be in 1.12, but it does alter
public Builders and classes. Which means, that if we don't release it
with 1.12, we would have to go through the cycle of deprecation,etc. to
get this change in. Given that t
Udo,
the PR has some failing tests that are in the "non-mandatory" category for
merge, TBH I'd prefer to have solid green changes being added at this point
forward...
Thanks,
EB
On Wed, Feb 5, 2020 at 3:01 PM Alexander Murmann
wrote:
> Udo, you say "refactor", but this sounds more like a featur
Udo, you say "refactor", but this sounds more like a feature or user facing
improvement. Do you mind elaborating a little more why this should be in
this release?
On Wed, Feb 5, 2020 at 1:54 PM Patrick Johnson
wrote:
> +1
>
> On 2/5/20, 1:53 PM, "Udo Kohlmeyer" wrote:
>
> Hi there Geode de
+1
On Wed, Feb 5, 2020 at 2:36 PM John Blum wrote:
> +1
>
> On Wed, Feb 5, 2020 at 1:54 PM Patrick Johnson >
> wrote:
>
> > +1
> >
> > On 2/5/20, 1:53 PM, "Udo Kohlmeyer" wrote:
> >
> > Hi there Geode dev,
> >
> > I would like to request that GEODE-7752
> > (7028f601680fee3f57cbdf
+1
On Wed, Feb 5, 2020 at 1:54 PM Patrick Johnson
wrote:
> +1
>
> On 2/5/20, 1:53 PM, "Udo Kohlmeyer" wrote:
>
> Hi there Geode dev,
>
> I would like to request that GEODE-7752
> (7028f601680fee3f57cbdff63951128d7180ca13) gets included into 1.12.
>
> This piece of code is a ref
Hi there Geode dev,
I would like to request that GEODE-7752
(7028f601680fee3f57cbdff63951128d7180ca13) gets included into 1.12.
This piece of code is a refactor of work done in GEODE-7715. This
refactor specializes Builders and simplifies Builder behavior for better
user experience.
--Udo
+1
On 2/5/20, 1:53 PM, "Udo Kohlmeyer" wrote:
Hi there Geode dev,
I would like to request that GEODE-7752
(7028f601680fee3f57cbdff63951128d7180ca13) gets included into 1.12.
This piece of code is a refactor of work done in GEODE-7715. This
refactor specializes Bu
16 matches
Mail list logo
