Hi Ernie,

Thanks for the heads up. This is breaking DistributedTestOpenJDK and Udo 
confirmed the are of concern and is going to revert this.
Thanks,

Mark

> On Feb 5, 2020, at 4:14 PM, Ernest Burghardt <eburgha...@pivotal.io> wrote:
> 
> Udo,
> the PR has some failing tests that are in the "non-mandatory" category for
> merge, TBH I'd prefer to have solid green changes being added at this point
> forward...
> 
> Thanks,
> EB
> 
> On Wed, Feb 5, 2020 at 3:01 PM Alexander Murmann <amurm...@apache.org>
> wrote:
> 
>> Udo, you say "refactor", but this sounds more like a feature or user facing
>> improvement. Do you mind elaborating a little more why this should be in
>> this release?
>> 
>> On Wed, Feb 5, 2020 at 1:54 PM Patrick Johnson <jpatr...@vmware.com.invalid
>>> 
>> wrote:
>> 
>>> +1
>>> 
>>> On 2/5/20, 1:53 PM, "Udo Kohlmeyer" <u...@apache.com> wrote:
>>> 
>>>    Hi there Geode dev,
>>> 
>>>    I would like to request that GEODE-7752
>>>    (7028f601680fee3f57cbdff63951128d7180ca13) gets included into 1.12.
>>> 
>>>    This piece of code is a refactor of work done in GEODE-7715. This
>>>    refactor specializes Builders and simplifies Builder behavior for
>>> better
>>>    user experience.
>>> 
>>>    --Udo
>>> 
>>> 
>>> 
>>> 
>> 

Reply via email to