[GitHub] geode pull request #664: Fix for GEODE-3292

2017-08-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/664 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] geode pull request #664: Fix for GEODE-3292

2017-08-04 Thread jujoramos
Github user jujoramos commented on a diff in the pull request: https://github.com/apache/geode/pull/664#discussion_r131378087 --- Diff: geode-assembly/src/test/java/org/apache/geode/tools/pulse/AbstractPulseConnectivityTest.java --- @@ -15,26 +15,31 @@ package org.apach

[GitHub] geode pull request #664: Fix for GEODE-3292

2017-08-04 Thread jujoramos
Github user jujoramos commented on a diff in the pull request: https://github.com/apache/geode/pull/664#discussion_r131367740 --- Diff: geode-pulse/src/test/java/org/apache/geode/tools/pulse/internal/PulseAppListenerTest.java --- @@ -0,0 +1,91 @@ +/* + * Licensed to the Ap

[GitHub] geode pull request #664: Fix for GEODE-3292

2017-08-03 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/664#discussion_r131182576 --- Diff: geode-assembly/src/test/java/org/apache/geode/tools/pulse/AbstractPulseConnectivityTest.java --- @@ -15,26 +15,31 @@ package org.apac

[GitHub] geode pull request #664: Fix for GEODE-3292

2017-08-03 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/664#discussion_r131182711 --- Diff: geode-pulse/src/test/java/org/apache/geode/tools/pulse/internal/PulseAppListenerTest.java --- @@ -0,0 +1,91 @@ +/* + * Licensed to the A

[GitHub] geode pull request #664: Fix for GEODE-3292

2017-08-03 Thread jujoramos
Github user jujoramos commented on a diff in the pull request: https://github.com/apache/geode/pull/664#discussion_r131071385 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java --- @@ -270,6 +271,7 @@ private void startHttpService(boolean

[GitHub] geode pull request #664: Fix for GEODE-3292

2017-08-03 Thread jujoramos
Github user jujoramos commented on a diff in the pull request: https://github.com/apache/geode/pull/664#discussion_r131071365 --- Diff: geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseConnectivityTest.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache

[GitHub] geode pull request #664: Fix for GEODE-3292

2017-08-03 Thread jujoramos
Github user jujoramos commented on a diff in the pull request: https://github.com/apache/geode/pull/664#discussion_r131071353 --- Diff: geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseConnectivityTest.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache

[GitHub] geode pull request #664: Fix for GEODE-3292

2017-08-02 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/664#discussion_r131050219 --- Diff: geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseConnectivityTest.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apach

[GitHub] geode pull request #664: Fix for GEODE-3292

2017-08-02 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/664#discussion_r131049554 --- Diff: geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseConnectivityTest.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apach

[GitHub] geode pull request #664: Fix for GEODE-3292

2017-08-02 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/664#discussion_r131049401 --- Diff: geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseConnectivityTest.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apach

[GitHub] geode pull request #664: Fix for GEODE-3292

2017-08-02 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/664#discussion_r131050061 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java --- @@ -270,6 +271,7 @@ private void startHttpService(boolean

[GitHub] geode pull request #664: Fix for GEODE-3292

2017-08-02 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/664#discussion_r131049994 --- Diff: geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/EmbeddedPulseRule.java --- @@ -38,6 +38,12 @@ protected void before() throws Thro

[GitHub] geode pull request #664: Fix for GEODE-3292

2017-08-02 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/664#discussion_r131049655 --- Diff: geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseConnectivityTest.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apach

[GitHub] geode pull request #664: Fix for GEODE-3292

2017-08-02 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/664#discussion_r131049464 --- Diff: geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseConnectivityTest.java --- @@ -0,0 +1,110 @@ +/* + * Licensed to the Apach

[GitHub] geode pull request #664: Fix for GEODE-3292

2017-07-28 Thread jujoramos
GitHub user jujoramos opened a pull request: https://github.com/apache/geode/pull/664 Fix for GEODE-3292 Embedded PULSE Connection Failure When jmx-manager-bind-address != localhost - ManagementAgent sets the 'pulse.host' system property whenever a 'jmx-manager-bind-address