Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/664#discussion_r131182711
--- Diff:
geode-pulse/src/test/java/org/apache/geode/tools/pulse/internal/PulseAppListenerTest.java
---
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
ANY KIND, either express
+ * or implied. See the License for the specific language governing
permissions and limitations under
+ * the License.
+ *
+ */
+
+package org.apache.geode.tools.pulse.internal;
+
+import javax.servlet.ServletContextEvent;
+import static org.mockito.Mockito.*;
+
+import org.junit.After;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.contrib.java.lang.system.RestoreSystemProperties;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TestRule;
+
+import org.apache.geode.test.junit.categories.UnitTest;
+import org.apache.geode.tools.pulse.internal.data.PulseConstants;
+import org.apache.geode.tools.pulse.internal.data.Repository;
+
+@Category(UnitTest.class)
+public class PulseAppListenerTest {
+ private Repository repository;
+ private PulseAppListener appListener;
+
+ @Rule
+ public final TestRule restoreSystemProperties = new
RestoreSystemProperties();
+
+ @Before
+ public void setUp() {
+ repository = Repository.get();
+ appListener = new PulseAppListener();
+ }
+
+ @Test
+ public void embeddedModeDefaultPropertiesRepositoryInitializationTest() {
+ System.setProperty(PulseConstants.SYSTEM_PROPERTY_PULSE_EMBEDDED,
"true");
+ appListener.contextInitialized(mock(ServletContextEvent.class));
+
+ Assert.assertEquals(false, repository.getJmxUseLocator());
+ Assert.assertEquals(false, repository.isUseSSLManager());
+ Assert.assertEquals(false, repository.isUseSSLLocator());
+ Assert.assertEquals(PulseConstants.GEMFIRE_DEFAULT_PORT,
repository.getPort());
+ Assert.assertEquals(PulseConstants.GEMFIRE_DEFAULT_HOST,
repository.getHost());
+
+ }
+
+ @Test
+ public void
embeddedModeNonDefaultPropertiesRepositoryInitializationTest() {
+ System.setProperty(PulseConstants.SYSTEM_PROPERTY_PULSE_EMBEDDED,
"true");
+ System.setProperty(PulseConstants.SYSTEM_PROPERTY_PULSE_PORT, "9999");
+ System.setProperty(PulseConstants.SYSTEM_PROPERTY_PULSE_HOST,
"nonDefaultBindAddress");
+ System.setProperty(PulseConstants.SYSTEM_PROPERTY_PULSE_USESSL_MANAGER,
+ Boolean.TRUE.toString());
+ System.setProperty(PulseConstants.SYSTEM_PROPERTY_PULSE_USESSL_LOCATOR,
+ Boolean.TRUE.toString());
+
+ appListener.contextInitialized(mock(ServletContextEvent.class));
+
+ Assert.assertEquals(false, repository.getJmxUseLocator());
+ Assert.assertEquals(true, repository.isUseSSLManager());
+ Assert.assertEquals(true, repository.isUseSSLLocator());
+ Assert.assertEquals("9999", repository.getPort());
+ Assert.assertEquals("nonDefaultBindAddress", repository.getHost());
+ }
+
+ @After
+ public void tearDown() {
+ if (repository != null) {
--- End diff --
this looks familiar, can you use EmbeddedPulseRule for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
