Github user galen-pivotal closed the pull request at:
https://github.com/apache/geode/pull/649
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/649#discussion_r129628663
--- Diff: geode-protobuf/src/main/proto/clientProtocol.proto ---
@@ -66,7 +66,7 @@ message Response {
RemoveAllResponse removeAllResponse =
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/649#discussion_r129626464
--- Diff: geode-protobuf/src/main/proto/basicTypes.proto ---
@@ -62,4 +62,14 @@ message Region {
message Server {
string url = 1;
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/649#discussion_r129626228
--- Diff: geode-protobuf/src/main/proto/clientProtocol.proto ---
@@ -66,7 +66,7 @@ message Response {
RemoveAllResponse removeAllResponse =
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/649#discussion_r128848930
--- Diff: geode-protobuf/src/main/proto/basicTypes.proto ---
@@ -62,4 +62,14 @@ message Region {
message Server {
string url = 1;
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/649#discussion_r128847166
--- Diff: geode-protobuf/src/main/proto/clientProtocol.proto ---
@@ -66,7 +66,7 @@ message Response {
RemoveAllResponse removeAllResponse =
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/649#discussion_r128652774
--- Diff: geode-protobuf/src/main/proto/basicTypes.proto ---
@@ -62,4 +62,14 @@ message Region {
message Server {
string url = 1;
-}
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/649
GEODE-2997: Change new protocol GetAllResponse.
@kohlmu-pivotal @hiteshk25 @WireBaron @pivotal-amurmann @bschuchardt
I think it's better to return the errors and the successful keys so
