Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/649#discussion_r128847166
--- Diff: geode-protobuf/src/main/proto/clientProtocol.proto ---
@@ -66,7 +66,7 @@ message Response {
RemoveAllResponse removeAllResponse = 7;
ListKeysResponse listKeysResponse = 8;
- ErrorResponse errorResponse = 13;
+ Error error = 13;
--- End diff --
Why has this been renamed to Error from ErrorResponse? Imo, we are
following the pattern (good or bad) that a ClientProtocol.Response contains an
Operation specific response. To now have a non-"Response" message sort of
breaks the mold.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
