Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/646
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128814031
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the A
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128811946
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Ap
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128811551
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
---
@@ -35,10 +37,9 @@
* @pa
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128793895
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
---
@@ -50,47 +38,14 @@
*
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128678978
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandlerJUnitTest.java
---
@@ -124,20 +128,19 @@
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128678905
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java
---
@@ -144,21 +138,22 @@
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128677601
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
---
@@ -50,47 +38,14 @@
* @p
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128649982
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Ap
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128649664
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Ap
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128649345
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Ap
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128647952
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Ap
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128648216
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
---
@@ -15,32 +15,33 @@
package org.apache.geo
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128649165
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Ap
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128649824
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Ap
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128648851
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/Failure.java
---
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128618059
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
---
@@ -15,32 +15,35 @@
package org.apache.
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128597628
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/Failure.java
---
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Softwa
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128591891
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/Result.java
---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Softwar
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128600182
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
---
@@ -15,32 +15,35 @@
package org.apache.geode.p
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128567505
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
---
@@ -67,30 +68,27 @@
*
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128386349
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandlerJUnitTest.java
---
@@ -124,20 +128,19 @
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128386432
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandlerJUnitTest.java
---
@@ -99,23 +105,21 @@
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128388403
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
---
@@ -35,10 +37,9 @@
* @p
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128387458
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/OperationContext.java
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128386591
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandlerJUnitTest.java
---
@@ -64,11 +72,10 @@
GitHub user pivotal-amurmann opened a pull request:
https://github.com/apache/geode/pull/646
GEODE-3213: Refactor ProtoBuf handler flow
Signed-off-by: Alexander Murmann
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of th
27 matches
Mail list logo
