Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/630
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r128038401
--- Diff: geode-protobuf/src/main/proto/basicTypes.proto ---
@@ -52,7 +52,12 @@ message CallbackArguments {
message Region {
--- End diff
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127820947
--- Diff: geode-protobuf/src/main/proto/basicTypes.proto ---
@@ -52,7 +52,12 @@ message CallbackArguments {
message Region {
--- End diff
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127761196
--- Diff: geode-protobuf/src/main/proto/region_API.proto ---
@@ -102,4 +102,14 @@ message GetRegionNamesRequest {
message GetRegionNamesRespo
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127756778
--- Diff: geode-protobuf/src/main/proto/region_API.proto ---
@@ -102,4 +102,14 @@ message GetRegionNamesRequest {
message GetRegionNamesRespon
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127299289
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandlerJUnitTest.java
---
@@ -14,6 +14,14 @@
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127294276
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandlerJUnitTest.java
---
@@ -14,6 +14,14 @
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127294137
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
---
@@ -278,6 +278,31 @@ public void
useSSL_t
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127294096
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
---
@@ -133,21 +134,38 @@
/**
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127292855
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandlerJUnitTest.java
---
@@ -14,6 +14,14 @@
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127290974
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
---
@@ -278,6 +278,31 @@ public void
useSSL_testNe
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127289766
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
---
@@ -133,21 +134,38 @@
/**
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127289532
--- Diff: geode-protobuf/src/main/proto/basicTypes.proto ---
@@ -52,7 +52,12 @@ message CallbackArguments {
message Region {
string
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127289486
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
---
@@ -278,6 +278,31 @@ public void
useSSL_t
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127289396
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/RemoveRequestOperationHandler.java
---
@@ -33,7 +33,7 @@
Github user WireBaron commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127285451
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/RemoveRequestOperationHandler.java
---
@@ -33,7 +33,7 @@
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127285154
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
---
@@ -278,6 +278,31 @@ public void
useSSL
Github user bschuchardt commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127276853
--- Diff: geode-protobuf/src/main/proto/basicTypes.proto ---
@@ -52,7 +52,12 @@ message CallbackArguments {
message Region {
string nam
GitHub user kohlmu-pivotal opened a pull request:
https://github.com/apache/geode/pull/630
GEODE-3141: GetRegion Operation implemented
Added OperationHandlerJUnitTest.java as parents class of all
OperationHandler tests.
General clean up of all `public static final` fields
19 matches
Mail list logo
