[GitHub] geode issue #687: GEODE-3258: Refactoring DiskStoreCommands

2017-08-07 Thread pdxrunner
Github user pdxrunner commented on the issue: https://github.com/apache/geode/pull/687 I'll go ahead and review your command refactorings in this PR, keeping in mind that the test will be dealt with under the other JIRA. I agree with not changing those two DUnit tests at this time.

[GitHub] geode issue #687: GEODE-3258: Refactoring DiskStoreCommands

2017-08-07 Thread YehEmily
Github user YehEmily commented on the issue: https://github.com/apache/geode/pull/687 @pdxrunner The tests that cover these commands are part of a separate JIRA ticket ([GEODE-1359](https://issues.apache.org/jira/browse/GEODE-1359)), so @jinmeiliao recommended just refactoring the com

[GitHub] geode issue #687: GEODE-3258: Refactoring DiskStoreCommands

2017-08-04 Thread pdxrunner
Github user pdxrunner commented on the issue: https://github.com/apache/geode/pull/687 With regards to your comments on the test classes and possible duplication: I would consider splitting the existing test classes so that each of the new *Command classes has it's own tests.