Github user pdxrunner commented on the issue:
https://github.com/apache/geode/pull/687
With regards to your comments on the test classes and possible duplication:
I would consider splitting the existing test classes so that each of the
new *Command classes has it's own tests. This may actually mean creating two
test classes for each command - a Unit test to cover the functionality that
doesn't need the overhead of the DUnit framework, and a DUnit test to cover
what can't be accomplished in the Unit test.
I would also consider making this refactoring incrementally, with separate
pull requests for each command that is extracted from the original
DiskStoreCommands class. The incremtnal PR's would then entail creating a
Command class and test classes as needed. As a starter, you may want to create
the ...Utils class when you first extract a command that needs the methods.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
