Github user asfgit closed the pull request at:
https://github.com/apache/geode-native/pull/63
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106933661
--- Diff:
src/clicache/integration-test/ThinClientFunctionExecutionTestsN.cs ---
@@ -959,7 +959,7 @@ public void ExecuteFETimeOut()
r
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106930234
--- Diff:
src/cppcache/integration-test/testThinClientPoolExecuteFunction.cpp ---
@@ -1158,9 +1160,10 @@ DUNIT_TASK_DEFINITION(CLIENT1, Client2
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106930126
--- Diff:
src/cppcache/integration-test/testThinClientPoolExecuteFunction.cpp ---
@@ -1506,48 +1353,10 @@ void runFunctionExecution(bool isEndp
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106929938
--- Diff: src/clicache/src/CacheFactory.cpp ---
@@ -84,6 +85,12 @@ namespace Apache
//TODO::split
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106929867
--- Diff:
src/clicache/integration-test/ThinClientFunctionExecutionTestsN.cs ---
@@ -959,7 +959,7 @@ public void ExecuteFETimeOut()
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106929690
--- Diff:
src/clicache/integration-test/ThinClientAppDomainFunctionExecutionTests.cs ---
@@ -0,0 +1,282 @@
+//=
Github user mmartell commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106929025
--- Diff:
src/clicache/integration-test/ThinClientAppDomainFunctionExecutionTests.cs ---
@@ -0,0 +1,282 @@
+//=
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106928287
--- Diff: src/clicache/src/CacheFactory.cpp ---
@@ -84,6 +85,12 @@ namespace Apache
//TODO::split
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106927884
--- Diff: src/clicache/src/CacheFactory.cpp ---
@@ -84,6 +85,12 @@ namespace Apache
//TODO::split
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106924902
--- Diff:
src/cppcache/integration-test/testThinClientPoolExecuteFunction.cpp ---
@@ -1158,9 +1160,10 @@ DUNIT_TASK_DEFINITION(CLIENT1, Client2OpT
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106924253
--- Diff:
src/cppcache/integration-test/testThinClientExecuteFunctionPrSHOP.cpp ---
@@ -563,7 +563,7 @@ DUNIT_TASK_DEFINITION(CLIENT1, Client1OpTe
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106926886
--- Diff:
src/clicache/integration-test/ThinClientFunctionExecutionTestsN.cs ---
@@ -959,7 +959,7 @@ public void ExecuteFETimeOut()
r
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106926117
--- Diff:
src/cppcache/integration-test/testThinClientPoolExecuteFunction.cpp ---
@@ -1506,48 +1353,10 @@ void runFunctionExecution(bool isEndpoin
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106923938
--- Diff: src/cppcache/integration-test/CMakeLists.txt ---
@@ -169,8 +169,6 @@ set_property(TEST testThinClientPartitionResolver
PROPERTY LABELS F
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106927339
--- Diff:
src/cppcache/integration-test/testThinClientExecuteFunctionPrSHOP.cpp ---
@@ -563,7 +563,7 @@ DUNIT_TASK_DEFINITION(CLIENT1, Client1O
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106922752
--- Diff: src/clicache/src/CacheFactory.cpp ---
@@ -84,6 +85,12 @@ namespace Apache
//TODO::split
Github user PivotalSarge commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106921830
--- Diff:
src/cppcache/integration-test/testThinClientExecuteFunctionPrSHOP.cpp ---
@@ -563,7 +563,7 @@ DUNIT_TASK_DEFINITION(CLIENT1, Client1OpTes
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/63
GEODE-2657
Please make a quick review.
Fixes all the integration tests around Function Execution and adds test of
AppDomain Function Execution.
Test testThinClientPoo
19 matches
Mail list logo
