Github user asfgit closed the pull request at:
https://github.com/apache/geode-native/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100942381
--- Diff: src/cppcache/src/CacheXmlParser.cpp ---
@@ -1165,7 +1166,7 @@ void CacheXmlParser::startPersistenceManager(const
xmlChar** atts) {
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100938599
--- Diff: src/cppcache/src/CacheXmlParser.cpp ---
@@ -1165,7 +1166,7 @@ void CacheXmlParser::startPersistenceManager(const
xmlChar** atts) {
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100917160
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1170,7 +1170,7 @@ class TcrMessageHelper {
}
if (compId != expectedPartType) {
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r10091
--- Diff: src/cppcache/src/CacheXmlParser.cpp ---
@@ -1165,7 +1166,7 @@ void CacheXmlParser::startPersistenceManager(const
xmlChar** atts) {
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100913452
--- Diff: src/cppcache/src/CacheXmlParser.cpp ---
@@ -1165,7 +1166,7 @@ void CacheXmlParser::startPersistenceManager(const
xmlChar** atts) {
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100912867
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1170,7 +1170,7 @@ class TcrMessageHelper {
}
if (compId != expectedPartType)
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100904404
--- Diff: src/cppcache/src/CacheXmlParser.cpp ---
@@ -1165,7 +1166,7 @@ void CacheXmlParser::startPersistenceManager(const
xmlChar** atts) {
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100903407
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1170,7 +1170,7 @@ class TcrMessageHelper {
}
if (compId != expectedPartType) {
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100878727
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1170,7 +1170,7 @@ class TcrMessageHelper {
}
if (compId != expectedPartType)
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100877742
--- Diff: src/cppcache/src/CacheXmlParser.cpp ---
@@ -1165,7 +1166,7 @@ void CacheXmlParser::startPersistenceManager(const
xmlChar** atts) {
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100878314
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -1170,7 +1170,7 @@ class TcrMessageHelper {
}
if (compId != expectedPartType)
GitHub user dgkimura opened a pull request:
https://github.com/apache/geode-native/pull/3
Replace ace calls to standard functions
Rather than call ACE library functions, lets try using standard functions,
like `std::snprintf` which was introduced in C++11.
You can merge this pull r
13 matches
Mail list logo
