GitHub user deepakddixit opened a pull request:
https://github.com/apache/geode/pull/648
GEODE-3206 : Corrected order of lucene search results based on score.
* Lucene results with higher score value are more relevant than lower once.
Used descending comparator for lucene
Github user deepakddixit commented on the issue:
https://github.com/apache/geode/pull/568
@kirklund Thanks for review. As noted, I missed following commit
guidelines. I have amended git message. Also updated PR title and description.
---
If your project is set up for it, you can
GitHub user deepakddixit opened a pull request:
https://github.com/apache/geode/pull/568
GEODE-290 : Removed deprecated method stopWithPort from LocatorLauncherâ¦
Removed deprecated properties.
Modified test cases to use alternate constants.
Thank you for
GitHub user deepakddixit opened a pull request:
https://github.com/apache/geode/pull/541
GEODE-2960 : Trim field parameter values from create lucene index.
Added logic to trim leading and trailing spaces from values provided
against 'field'.
Modify existing test case
GitHub user deepakddixit opened a pull request:
https://github.com/apache/geode/pull/526
GEODE-269 : Removing deprecated API's from FunctionService.
Modified test cases after removing deprecated API's
Thank you for submitting a contribution to Apache Geode.
Github user deepakddixit commented on the issue:
https://github.com/apache/geode/pull/511
@jhuynh1 Sure will open new PR without conflict.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user deepakddixit opened a pull request:
https://github.com/apache/geode/pull/511
Feature/geode 269
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been
Github user deepakddixit commented on the issue:
https://github.com/apache/geode/pull/509
@metatype Thanks for review. I have removed withArgs related changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user deepakddixit opened a pull request:
https://github.com/apache/geode/pull/509
GEODE-265: Removing deprecated API from Execution interface.
- Removed following deprecated API from Execution interface
1. public Execution withArgs(IN args)
2. public
Github user deepakddixit commented on the issue:
https://github.com/apache/geode/pull/326
@metatype I have updated the golden-help-offline.properties. The
integration test HelpCommandsIntegrationTest is generic one checking the help
and confirms the contents from golden-help
Github user deepakddixit commented on the issue:
https://github.com/apache/geode/pull/327
@kjduling If changes are good can you please help me in merging this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user deepakddixit opened a pull request:
https://github.com/apache/geode/pull/327
GEODE-2236: Remove all cache-listners using Gfsh
Added check before instantiating cache listner class. Added test to verify
change.
You can merge this pull request into a Git repository by
GitHub user deepakddixit opened a pull request:
https://github.com/apache/geode/pull/326
Feature/geode 2103 : Adding --http-service-port and
--http-service-bind-address option in start locator command
You can merge this pull request into a Git repository by running:
$ git
Github user deepakddixit commented on the issue:
https://github.com/apache/geode/pull/296
Thanks @upthewaterspout for your assistance in resolving it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user deepakddixit commented on the issue:
https://github.com/apache/geode/pull/296
@upthewaterspout Thanks for the detailed review. I agree with you,
SingleHopClientExecutor was not having uncaught exception handler which is
causing exceptions not handled and ultimately not
Github user deepakddixit commented on the issue:
https://github.com/apache/geode/pull/296
@upthewaterspout Do changes look good?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user deepakddixit commented on the issue:
https://github.com/apache/geode/pull/296
Precheckin and ./gradlew test passed on my machine. @upthewaterspout
Kindly have a look over updated PR.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user deepakddixit commented on the issue:
https://github.com/apache/geode/pull/297
Thank you @kirklund and @metatype for review and merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user deepakddixit commented on the issue:
https://github.com/apache/geode/pull/296
@upthewaterspout It looks like from IDE when we run all tests under
UnitTest category above test fails. But when we run either :geode-core:test
target or complete precheckin I never observed
Github user deepakddixit commented on the issue:
https://github.com/apache/incubator-geode/pull/296
@kirklund I have added a test as suggested with SingleHopTestExecutor.
Kindly review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user deepakddixit commented on the issue:
https://github.com/apache/incubator-geode/pull/297
@metatype and @kirklund I have addressed the review comments. Kindly have a
look.
precheckin is successful. I am not sure why travis is failed with
spotlessJavaCheck, at my box it
Github user deepakddixit commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/297#discussion_r90585692
--- Diff:
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowStackTraceDUnitTest.java
---
@@ -90,6 +90,20
Github user deepakddixit commented on the issue:
https://github.com/apache/incubator-geode/pull/296
@upthewaterspout Thanks for the review. The class declaration is mistakenly
changed. I have corrected it. All tests are passing from precheckin after this.
---
If your project is set
GitHub user deepakddixit opened a pull request:
https://github.com/apache/incubator-geode/pull/297
GEODE-734: gfsh export stack-traces should not require an output file with
extension .txt
Removed mandatory txt file extension when exporting stack trace using gfsh
command export
GitHub user deepakddixit opened a pull request:
https://github.com/apache/incubator-geode/pull/296
GEODE-2109 : Calling submit on ExecutionService can cause exceptions to be
lost
Replaced submit call with execute.
Refactored GIITask calls from DiskStoreImpl. Async task like
25 matches
Mail list logo
