Github user deepakddixit commented on the issue:

    https://github.com/apache/geode/pull/296
  
    @upthewaterspout Thanks for the detailed review. I agree with you, 
SingleHopClientExecutor was not having uncaught exception handler which is 
causing exceptions not handled and ultimately not logged. Setting an 
uncaughtExceptionHandler would help in logging uncaught exceptions. 
    Only change I would like to suggest is instead of adding 
uncaughtExceptionHandler can we set LoggingThreadGroup? The other pooled 
executors are using LoggingThreadGroup which handles uncauhtExceptions. I have 
changed code a bit and added LoggingThreadGroup, unit tests are passing. Let me 
know your view on using LoggingThreadGroup. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to