alb3rtobr commented on issue #4978:
URL: https://github.com/apache/geode/pull/4978#issuecomment-617861442
> One additional comment regarding the following waning message:
>
> ```
> [warn 2020/04/18 23:44:22.757 PDT tid=0x298] Unable to ping non-member
rs-FullRegression19040559a2i
prettyClouds opened a new pull request #4984:
URL: https://github.com/apache/geode/pull/4984
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all c
jujoramos commented on issue #4978:
URL: https://github.com/apache/geode/pull/4978#issuecomment-617814149
One additional comment regarding the following waning message:
```
[warn 2020/04/18 23:44:22.757 PDT
tid=0x298] Unable to ping non-member
rs-FullRegression19040559a2i32xlarg
jdeppe-pivotal commented on issue #4861:
URL: https://github.com/apache/geode/pull/4861#issuecomment-617771032
Since we're actively working on various approaches to this, and it's
probably still going to take a while, I'm going to close this PR for now.
---
jujoramos commented on a change in pull request #4978:
URL: https://github.com/apache/geode/pull/4978#discussion_r412828019
##
File path:
geode-core/src/main/java/org/apache/geode/cache/client/internal/PingOp.java
##
@@ -43,12 +45,16 @@ private PingOp() {
static class PingO
jujoramos commented on a change in pull request #4970:
URL: https://github.com/apache/geode/pull/4970#discussion_r412794182
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithExpirationDUnitTest.java
##
@@ -0,0 +1,537 @@
jujoramos commented on issue #4978:
URL: https://github.com/apache/geode/pull/4978#issuecomment-617642403
@bschuchardt @alb3rtobr : I'm still analysing the issue and seeing whether I
can reproduce it consistently, so far it's proving quite elusive as it only
fails once or twice in around 1
dschneider-pivotal opened a new pull request #4983:
URL: https://github.com/apache/geode/pull/4983
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For
mhansonp opened a new pull request #4982:
URL: https://github.com/apache/geode/pull/4982
This test just needed some awaits added to allow the test to retry.
This is an automated message from the Apache Git Service.
To respond
dschneider-pivotal opened a new pull request #4981:
URL: https://github.com/apache/geode/pull/4981
Fixed docs to describe the new default.
Also if the system property it set to an unknown shortcut
then it now defaults to PARTITION_REDUNDANT instead of PARTITION.
The test now validat
DonalEvans commented on issue #4909:
URL: https://github.com/apache/geode/pull/4909#issuecomment-617470775
> it seems like there are several classes that are a tweaked copy of
existing classes - RestoreRedundancyBuilderImpl, RestoreRedundancyDirector,
RegionRedundancyStatus. Is there a way
DonalEvans commented on a change in pull request #4909:
URL: https://github.com/apache/geode/pull/4909#discussion_r412566753
##
File path:
geode-core/src/main/java/org/apache/geode/cache/control/RestoreRedundancyResults.java
##
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the Apache
gesterzhou commented on a change in pull request #4970:
URL: https://github.com/apache/geode/pull/4970#discussion_r412539205
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithExpirationDUnitTest.java
##
@@ -0,0 +1,537 @
upthewaterspout commented on issue #4963:
URL: https://github.com/apache/geode/pull/4963#issuecomment-617442287
The combination of a `ThreadLocal`, a `CountDownLatch`, and
`synchronized()` seems a bit complicated.
The whole close block is already inside of
`synchronized(GemFireCach
kirklund removed a comment on issue #4924:
URL: https://github.com/apache/geode/pull/4924#issuecomment-614809461
The Concurrent Tests that don't use Mockito still seem to hang in
StressNewTest (I removed `@Ignore` so they now need to pass StressNewTest).
-
kirklund removed a comment on issue #4924:
URL: https://github.com/apache/geode/pull/4924#issuecomment-617298733
Another unrelated JMXMBeanReconnectDUnitTest failure.
This is an automated message from the Apache Git Service.
kirklund removed a comment on issue #4924:
URL: https://github.com/apache/geode/pull/4924#issuecomment-614181221
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412496115
##
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java
##
@@ -240,6 +242,16 @@ public stat
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412495880
##
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/RemoveCommand.java
##
@@ -90,7 +90,14 @@ public ResultMo
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412493711
##
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java
##
@@ -381,6 +397,12 @@ public Resu
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412493249
##
File path:
geode-gfsh/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/ClearCommandDUnitTest.java
##
@@ -0,0 +1,130
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412492948
##
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java
##
@@ -313,22 +313,21 @@ publi
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412492480
##
File path:
geode-gfsh/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/ClearCommandDUnitTest.java
##
@@ -70,43 +72,4
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412487003
##
File path:
geode-gfsh/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/ClearCommandDUnitTest.java
##
@@ -0,0 +1,130
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412480534
##
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ClearCommand.java
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed t
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412476686
##
File path:
geode-core/src/main/java/org/apache/geode/management/internal/i18n/CliStrings.java
##
@@ -1914,9 +1921,10 @@
public static final
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412473711
##
File path:
geode-gfsh/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/ClearCommandDUnitTest.java
##
@@ -0,0 +1,123
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412473139
##
File path:
geode-core/src/main/java/org/apache/geode/management/internal/i18n/CliStrings.java
##
@@ -816,6 +816,13 @@
public static final S
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412472330
##
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java
##
@@ -314,17 +314,13 @@ publi
BenjaminPerryRoss commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412471778
##
File path:
geode-core/src/main/java/org/apache/geode/management/internal/i18n/CliStrings.java
##
@@ -1915,6 +1922,9 @@
public static final
pivotal-jbarrett commented on a change in pull request #4909:
URL: https://github.com/apache/geode/pull/4909#discussion_r412469554
##
File path:
geode-core/src/main/java/org/apache/geode/cache/control/RestoreRedundancyResults.java
##
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the A
pivotal-jbarrett commented on a change in pull request #4909:
URL: https://github.com/apache/geode/pull/4909#discussion_r412453438
##
File path:
geode-core/src/main/java/org/apache/geode/cache/control/RestoreRedundancyResults.java
##
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the A
DonalEvans commented on a change in pull request #4818:
URL: https://github.com/apache/geode/pull/4818#discussion_r412366325
##
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ClearCommand.java
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the A
Bill commented on a change in pull request #4959:
URL: https://github.com/apache/geode/pull/4959#discussion_r412391692
##
File path:
geode-assembly/src/acceptanceTest/java/org/apache/geode/client/sni/ClientSNIDropProxyAcceptanceTest.java
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed t
Bill commented on a change in pull request #4959:
URL: https://github.com/apache/geode/pull/4959#discussion_r412386787
##
File path:
geode-assembly/src/acceptanceTest/java/org/apache/geode/client/sni/ClientSNIDropProxyAcceptanceTest.java
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed t
Bill commented on a change in pull request #4959:
URL: https://github.com/apache/geode/pull/4959#discussion_r412386539
##
File path:
geode-assembly/src/acceptanceTest/java/org/apache/geode/client/sni/ClientSNIDropProxyAcceptanceTest.java
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed t
Bill commented on a change in pull request #4959:
URL: https://github.com/apache/geode/pull/4959#discussion_r412386248
##
File path:
geode-assembly/src/acceptanceTest/resources/org/apache/geode/client/sni/docker-compose.yml
##
@@ -33,7 +33,7 @@ services:
container_name: '
bschuchardt commented on a change in pull request #4959:
URL: https://github.com/apache/geode/pull/4959#discussion_r412381622
##
File path:
geode-assembly/src/acceptanceTest/java/org/apache/geode/client/sni/ClientSNIDropProxyAcceptanceTest.java
##
@@ -0,0 +1,197 @@
+/*
+ * Lic
upthewaterspout commented on a change in pull request #4909:
URL: https://github.com/apache/geode/pull/4909#discussion_r412362589
##
File path:
geode-core/src/main/java/org/apache/geode/cache/control/RestoreRedundancyResults.java
##
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the Ap
upthewaterspout commented on issue #4949:
URL: https://github.com/apache/geode/pull/4949#issuecomment-617301600
JMXMBeanReconnectDUnitTest failed, but that is not related to this test.
This is an automated message from the Ap
metatype opened a new pull request #94:
URL: https://github.com/apache/geode-examples/pull/94
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
kirklund commented on issue #4924:
URL: https://github.com/apache/geode/pull/4924#issuecomment-617298733
Another unrelated JMXMBeanReconnectDUnitTest failure.
This is an automated message from the Apache Git Service.
To respo
prettyClouds commented on a change in pull request #4973:
URL: https://github.com/apache/geode/pull/4973#discussion_r412336050
##
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/general/LoopingThreads.java
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apac
nabarunnag commented on a change in pull request #4976:
URL: https://github.com/apache/geode/pull/4976#discussion_r412320360
##
File path: geode-docs/managing/disk_storage/using_disk_stores.html.md.erb
##
@@ -170,7 +170,10 @@ Example of using a named disk store for PDX serializ
metatype commented on issue #93:
URL: https://github.com/apache/geode-examples/pull/93#issuecomment-617284504
Test comment number 2.
This is an automated message from the Apache Git Service.
To respond to the message, please
nabarunnag commented on a change in pull request #4976:
URL: https://github.com/apache/geode/pull/4976#discussion_r412320360
##
File path: geode-docs/managing/disk_storage/using_disk_stores.html.md.erb
##
@@ -170,7 +170,10 @@ Example of using a named disk store for PDX serializ
metatype commented on issue #93:
URL: https://github.com/apache/geode-examples/pull/93#issuecomment-617279841
Testing a comment. This should be a comment in the JIRA.
This is an automated message from the Apache Git Service.
dschneider-pivotal commented on a change in pull request #4973:
URL: https://github.com/apache/geode/pull/4973#discussion_r412318830
##
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/general/LoopingThreads.java
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to th
mhansonp opened a new pull request #4980:
URL: https://github.com/apache/geode/pull/4980
This test just needed some awaits added to allow the test to retry.
This is an automated message from the Apache Git Service.
To respond
metatype opened a new pull request #93:
URL: https://github.com/apache/geode-examples/pull/93
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jujoramos opened a new pull request #4979:
URL: https://github.com/apache/geode/pull/4979
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
alb3rtobr opened a new pull request #4978:
URL: https://github.com/apache/geode/pull/4978
This PR reverts the revert of GEODE-7565 and introduces a fix for the
problem identified
This is an automated message from the Apache
jujoramos commented on a change in pull request #4970:
URL: https://github.com/apache/geode/pull/4970#discussion_r411996029
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithExpirationDUnitTest.java
##
@@ -0,0 +1,535 @@
jujoramos commented on a change in pull request #4970:
URL: https://github.com/apache/geode/pull/4970#discussion_r411993686
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithExpirationDUnitTest.java
##
@@ -0,0 +1,535 @@
jujoramos commented on a change in pull request #4970:
URL: https://github.com/apache/geode/pull/4970#discussion_r411992120
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithExpirationDUnitTest.java
##
@@ -0,0 +1,535 @@
jujoramos commented on a change in pull request #4970:
URL: https://github.com/apache/geode/pull/4970#discussion_r411988106
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithExpirationDUnitTest.java
##
@@ -0,0 +1,535 @@
jujoramos commented on a change in pull request #4970:
URL: https://github.com/apache/geode/pull/4970#discussion_r411985789
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithExpirationDUnitTest.java
##
@@ -0,0 +1,535 @@
jujoramos commented on a change in pull request #4970:
URL: https://github.com/apache/geode/pull/4970#discussion_r411981569
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithExpirationDUnitTest.java
##
@@ -0,0 +1,535 @@
albertogpz commented on a change in pull request #4928:
URL: https://github.com/apache/geode/pull/4928#discussion_r411879596
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderQueue.java
##
@@ -410,6 +441,53 @@ public Object pe
albertogpz commented on a change in pull request #4928:
URL: https://github.com/apache/geode/pull/4928#discussion_r411879596
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderQueue.java
##
@@ -410,6 +441,53 @@ public Object pe
albertogpz commented on issue #4928:
URL: https://github.com/apache/geode/pull/4928#issuecomment-616957705
> Sorry, I haven't had time to dig deeply into this PR.
>
> There were some concerns on the rfc for interleaving or out of ordering of
events. I might have missed it, but were t
demery-pivotal opened a new pull request #4977:
URL: https://github.com/apache/geode/pull/4977
If a user's access token expires, Pulse attempts to refresh it. If the
refresh fails, Pulse logs the user out and redirects the browser to
/pulse/clusterLogout.
Changes in Repository:
davebarnes97 commented on issue #4975:
URL: https://github.com/apache/geode/pull/4975#issuecomment-616863201
Thanks for this contribution, @alb3rtobr.
For the gfsh command reference writeup on change loglevel, I'd like to
suggest a minor re-wording, which replaces future tense with pres
jchen21 commented on a change in pull request #4970:
URL: https://github.com/apache/geode/pull/4970#discussion_r411699051
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithExpirationDUnitTest.java
##
@@ -0,0 +1,535 @@
+
prettyClouds commented on a change in pull request #4973:
URL: https://github.com/apache/geode/pull/4973#discussion_r411691444
##
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/general/LoopingThreads.java
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apac
DonalEvans commented on a change in pull request #4970:
URL: https://github.com/apache/geode/pull/4970#discussion_r411591697
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithExpirationDUnitTest.java
##
@@ -0,0 +1,535 @
karensmolermiller opened a new pull request #4976:
URL: https://github.com/apache/geode/pull/4976
…stores
Reviewers: I put the same information in 3 distinct locations. It is my hope
that Geode-users who need this info will encounter it in one of those places
when they look at the d
dschneider-pivotal commented on a change in pull request #4973:
URL: https://github.com/apache/geode/pull/4973#discussion_r411592696
##
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/general/LoopingThreads.java
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to th
jhuynh1 commented on a change in pull request #4928:
URL: https://github.com/apache/geode/pull/4928#discussion_r411587074
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderQueue.java
##
@@ -410,6 +441,53 @@ public Object peek(
pivotal-jbarrett commented on issue #4969:
URL: https://github.com/apache/geode/pull/4969#issuecomment-616692247
Very specifically we use a plugin called facet that creates all these things
for us.
https://plugins.gradle.org/plugin/nebula.facet
-
bschuchardt commented on issue #4974:
URL: https://github.com/apache/geode/pull/4974#issuecomment-616668765
The problem might be in changes to Ping.java. It may send an error response
back to the client with MessageType.PING, which maybe the client isn't equipped
to deal with.
-
alb3rtobr opened a new pull request #4975:
URL: https://github.com/apache/geode/pull/4975
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
kirklund commented on issue #4969:
URL: https://github.com/apache/geode/pull/4969#issuecomment-616645957
> What do we mean by facet in this context?
I think it means (1) src set, (2) gradle target to execute tests in the src
set, (3) pipeline job in CI and PR.
-
jujoramos edited a comment on issue #4974:
URL: https://github.com/apache/geode/pull/4974#issuecomment-616565367
@alb3rtobr: I'm just tagging you as you are the author of the original
commit so you're aware of the revert request, I'll try to reproduce the issue
using a `DistributedTest` an
jujoramos edited a comment on issue #4974:
URL: https://github.com/apache/geode/pull/4974#issuecomment-616565367
@alb3rtobr: I'm just tagging you as you are the author of the original
commit so you're aware of the revert request, I'll try to reproduce the issue
using a `DistributedTest` an
jujoramos edited a comment on issue #4974:
URL: https://github.com/apache/geode/pull/4974#issuecomment-616565367
@alb3rtobr: I'm just tagging you as you are the author of the original
commit so you're aware of the revert request, I'll try to reproduce the issue
using a `DistributedTest` an
jujoramos commented on issue #4974:
URL: https://github.com/apache/geode/pull/4974#issuecomment-616565367
@alb3rtobr
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
jujoramos opened a new pull request #4974:
URL: https://github.com/apache/geode/pull/4974
This reverts commit dd23ee8200cba67cea82e57e2e4ccedcdf9e8266.
Intermittent errors were observed while executing some internal tests and
commit dd23ee8200cba67cea82e57e2e4ccedcdf9e8266 was determ
jvarenina commented on a change in pull request #4967:
URL: https://github.com/apache/geode/pull/4967#discussion_r411170968
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/backup/BackupService.java
##
@@ -74,6 +74,9 @@ public BackupService(InternalCache
mkevo commented on a change in pull request #4967:
URL: https://github.com/apache/geode/pull/4967#discussion_r411162666
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/backup/BackupService.java
##
@@ -74,6 +74,9 @@ public BackupService(InternalCache cach
DonalEvans merged pull request #2: Added JsonPdxConverter
URL: https://github.com/apache/geode-kafka-connector/pull/2
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
DonalEvans opened a new pull request #2: Added JsonPdxConverter
URL: https://github.com/apache/geode-kafka-connector/pull/2
- Allows PdxInstance objects to be converted to JSON bytes when sourced
from a Geode region into a Kafka topic
- Allows JSON bytes to be converted to PdxInstance
nabarunnag merged pull request #1: Feature/restructuring
URL: https://github.com/apache/geode-kafka-connector/pull/1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
nabarunnag opened a new pull request #1: Feature/restructuring
URL: https://github.com/apache/geode-kafka-connector/pull/1
Cosmetic modification and new test runner for writing tests
This is an automated message from the Apac
84 matches
Mail list logo
