demery-pivotal opened a new pull request #4977:
URL: https://github.com/apache/geode/pull/4977
If a user's access token expires, Pulse attempts to refresh it. If the
refresh fails, Pulse logs the user out and redirects the browser to
/pulse/clusterLogout.
Changes in Repository:
- When OAuth is configured, before returning the user's cluster,
getCluster() checks whether the user's access token has expired.
- If the access token has expired, the repository attempts to refresh
it. If the refresh succeeds, the repository reconnects the user's
cluster to JMX and returns it.
- If the refresh fails, the repository disconnects the user's cluster
from JMX, removes the cluster from the repository, and throws an
authentication or authorization exception.
Changes in PulseController:
- If the service call throws an authentication or authorization
exception, PulseController. getPulseUpdate() returns a 401 status.
Changes in pulsescript/common.js:
- If a Pulse ajax call returns a 401 status, ajaxPost() redirects the
browser to /pulse/clusterLogout to log the user out and request
re-authorization.
Co-authored-by: Joris Melchior <[email protected]>
Co-authored-by: Dale Emery <[email protected]>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [X] Is your initial contribution a single, squashed commit?
- [X] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
