Re: [DISCUSS] Using Pull Requests over Review Board

One feature I like about PRs on GitHub that I haven't figured out how to do on Review Board is breaking up a large changeset (which I would like to have reviewed together) into multiple commits. It can be a useful way to tell a story about your changes, but keep the review for them in one place. I

Re: [DISCUSS] easy string based partitioning

I don't think it would be that much harder to add an option for a user-specified delimiter than it would to hardcode ':' or '|'. I think the utility of that would be much higher, and that it would be a much better candidate for inclusion in geode-core. Otherwise, I think it should live in an "examp

Looks like Travis CI is hung?

It looks like Travis isn't even starting the build for this PR, which should have started 5 or 6 hours ago: Travis: https://travis-ci.org/apache/geode/builds/236348800 PR: https://github.com/apache/geode/pull/474 Does anyone know why it isn't building, or how to jiggle it and make it restart? Th

Re: What to do with Singletons

> > But we should probably create another thread to talk about it to keep this > one focused on the singletons discussion. > +1 How far can we go down the path of cleaning up Singletons without having a > DI framework in the mix? We can do DI without a framework, by just passing the dependencie

Re: Use InternalCache instead of GemFireCacheImpl

Thanks for making this critical refactoring work happen, Kirk! The day of two Caches in a single JVM seems just a little bit closer now. On Mon, May 15, 2017 at 1:31 PM, Dan Smith wrote: > +googol - you're awesome Kirk, thanks for taking this on! > > -Dan > > On Mon, May 15, 2017 at 1:03 PM, Kir

Re: [gemfire-dev] New Client-Server Protocol Proposal

I think we should be presenting the current proposal as the API and message structure, as would be laid out in an IDL. This way, we can experiment with Protobuf, Thrift serialization, &c. for message structure without having to exactly specify the message structure. This will make designing a proto

Re: [gemfire-dev] New Client-Server Protocol Proposal

I think TCP does exactly this for us. On Fri, May 5, 2017 at 9:08 AM, Bruce Schuchardt wrote: > This is very similar to how peer-to-peer messaging is performed in Geode. > Messages are serialized to a stream that knows how to optimally "chunk" the > bytes into fixed-size packets. On the receivi

Re: [gemfire-dev] New Client-Server Protocol Proposal

On Tue, May 2, 2017 at 11:52 AM, Hitesh Khamesra < hitesh...@yahoo.com.invalid> wrote: > Absolutely its a implementation detail. > This doesn't answer Dan's comment. Do you think fragmentation should be taken care of by the TCP layer or the protocol should deal with it specifically?

Re: Edit Permissions for Confluence

Works! Thanks, Dan. Galen On Wed, Apr 19, 2017 at 12:07 PM, Dan Smith wrote: > I just added you, hopefully you should be able to edit now. > > -Dan > > On Wed, Apr 19, 2017 at 11:44 AM, Galen M O'Sullivan < > gosulli...@pivotal.io> > wrote: > > &

Edit Permissions for Confluence

Hi, I don't seem to have edit permissions for the Apache Confluence wiki. Would someone with the proper permissions be willing to give me the proper permissions, please? Username gosullivan. Thanks, Galen

Re: Why we shouldn't use RPC Frameworks for the New Geode Protocol

On Mon, Apr 10, 2017 at 10:47 AM, Bruce Schuchardt wrote: > I agree that key/value serialization is a separate issue and more related > to storage than communications. The thing I'm struggling with is how to > specify message metadata in an RPC IDL. I'm thinking of things like an > eventID, tra

Re: Why we shouldn't use RPC Frameworks for the New Geode Protocol

data perhaps and a section for the data. It > should have no restriction or care on how that data was serialized. The > protocol does not define in any way the structure of the data being PUT or > GET. > > Separating that concern then, does your argument still stand that PRC > fra

Why we shouldn't use RPC Frameworks for the New Geode Protocol

I think the main selling point of an RPC framework/IDL is ease-of-use for defined remote communications that look like function calls. If you have calls you're making to remote servers asking them to do work, you can fairly trivially define the interface and then call through. You can then use nati

Re: Client Commands and SecurityService

+1 to getting rid of singletons and non-constant use of static. Also to code where the ownership semantics are clear. On Mon, Apr 3, 2017 at 10:30 AM, Jacob Barrett wrote: > +1 refactor > On Mon, Apr 3, 2017 at 9:35 AM Michael William Dodge > wrote: > > > +1 to modular and questioning non-const

Re: ReflectionBasedAutoSerializer by default?

* Are we 100% sure that this won't break anything? I'd hate to see a user with some weird object that holds references to system internals putting it into a local region and getting something else back. Or the user might be expecting == to work. * I'm wary of serializing data when the customer isn

Re: [VOTE] Marking Redis Adapter as Experimental

o marking it experimental now >> >> Once we do that I think it will be fine for the community to make breaking >> changes to it if we need to. >> >> -- >> Mike Stolz >> Principal Engineer, GemFire Product Manager >> Mobile: +1-631-835-4771 >>

[VOTE] Marking Redis Adapter as Experimental

Hi all, I think that we should mark the Redis adapter as experimental. This functionality comes from the initial code grant from GemFire. It is mentioned in the "Experimental" section of the GemFire docs [1], and as far as I can tell, the only reason it hasn't been marked as experimental in Geode

Re: Locators with --bind-address

I can see that you might want to configure them separately, so it's good to have both options. If I was to design this again, I think I would have the JMX address etc. default to the same as the bind address, but as it is that would break backwards compatibility. -Galen On Fri, Feb 24, 2017 at 1

Re: GeodeRedisAdapter improvments/feedback

On Wed, Feb 15, 2017 at 1:34 PM, Real Wes wrote: > Does delta propagation make worrying about frequently updated fat collections moot? As long as we don't have collections on the order of the available RAM on a single server (in which case we'd want to distribute it across multiple servers), and

Re: Build failed in Jenkins: Geode-nightly #749

; [1] https://builds.apache.org/job/Geode-nightly/749/console > > [2] https://builds.apache.org/job/Geode-nightly/749/testReport/ > > [3] https://builds.apache.org/job/Geode-nightly/749/artifact/ > > > > On Wed, Feb 15, 2017 at 9:04 AM, Galen M O'Sullivan < > gosu

Re: Build failed in Jenkins: Geode-nightly #749

trying to view? > > --Mark > > [1] https://builds.apache.org/job/Geode-nightly/749/console > [2] https://builds.apache.org/job/Geode-nightly/749/testReport/ > [3] https://builds.apache.org/job/Geode-nightly/749/artifact/ > > On Wed, Feb 15, 2017 at 9:04 AM, Galen M O'S

Re: Build failed in Jenkins: Geode-nightly #749

I don't seem to have access to see the build report. Is that restricted to committers only? Thanks, Galen On Wed, Feb 15, 2017 at 8:08 AM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See > > Changes: > > [kmiller] GEODE-24

Re: GeodeRedisAdapter improvments/feedback

If we put them in separate regions, we'll have the overhead of looking up in two regions added to each and every operation, and the overhead of creating all these regions. If we really wanted to we could have some threshold at which we spill collections over into their own regions, and have someth

Re: [DISCUSS] JIRA guidelines

+1 to the article and removing the draft label On Tue, Feb 14, 2017 at 4:05 PM, Akihiro Kitada wrote: > I agree! > > > -- > Akihiro Kitada | Staff Customer Engineer | +81 80 3716 3736 > Support.Pivotal.io | Mon-Fri 9:00am to > 5:30pm JST | 1-877-477-2269 > [i

Re: New Committer And PMC Member: Jared Stewart

Right on! Congratulations, Jared! On Mon, Feb 13, 2017 at 1:26 PM, Dan Smith wrote: > Sweet! Welcome! > > -Dan > > On Mon, Feb 13, 2017 at 12:23 PM, Kenneth Howe wrote: > > > Congratulations Jared > > > > > On Feb 13, 2017, at 12:07 PM, Joey McAllister > > wrote: > > > > > > Nice! Congratulat

Re: [VOTE] RC2: Apache Geode release - v1.1.0

Good catch, Ken. It looks like the Dockerfile and Docker scripts refer to 'incubat*', and a few places in the docs do as well. On Fri, Feb 10, 2017 at 1:35 PM, Kenneth Howe wrote: > +0 > I’m not going to give an outright down-vote, but BUILDING.md needs to be > updated to refer to the correct ve

Property-Based Testing for Geode

Hi all, I would like to propose adding [junit-quickcheck](1) to Geode. It's named after the [Haskell tool](2) and functions more or less as automated testing for JUnit Theories (if anyone is familiar with those). Property-based testing means basically that you write a function that tests some cod

Re: To Spring or Not

service if we really need to get rid of Spring for some reason. -Galen On Thu, Jan 26, 2017 at 12:23 PM, Jacob Barrett wrote: > On Thu, Jan 26, 2017 at 11:36 AM Galen M O'Sullivan > > wrote: > > > I think the reason we use JSON is because it's easy. I'm not con

Re: To Spring or Not

I think the reason we use JSON is because it's easy. I'm not convinced that 90% of JSON data is from JavaScript, unless you have data to back that up -- a lot of scripting languages use it because it's convenient. I'm not that familiar with how we handle JSON at present, but it's worth revisiting

Re: Debugging JUnit / DUnit tests

Thanks for the input, all! I ended up solving this particular problem without the debugger, but I'll have to try this later. Cheers, Galen On Fri, Jan 13, 2017 at 11:49 AM, Galen M O'Sullivan wrote: > Hi, > > I'm looking at some DUnit tests and wondering if someo

Debugging JUnit / DUnit tests

Hi, I'm looking at some DUnit tests and wondering if someone can point me in the direction of the right way to hook a debugger into them. I've been using IntelliJ to debug in my main development environment, which is a Mac, but don't have it on the Linux box in which I'm seeing an error. What do y

Re: User permissions for Galen O'Sullivan

Thanks, Mark! I suppose I'll add a brief introduction: Hi, I'm Galen O'Sullivan. I joined Pivotal fairly recently. I've previously worked at New Relic and Coherent Logix. In my free time I've been playing with Rust and the Ergodox (though not at the same time). I think it's pretty awesome that I c