submodule that is a sibling to geode-core, and revisit things. Closing the
PR for now, I feel I have the feedback I need.
-Aditya
On Wed, Jan 2, 2019 at 3:11 PM Aditya Anchuri wrote:
> Hi everyone,
>
> As part of work on the proposed Cluster Management API (
> https://cwiki.apache.
Hi everyone,
As part of work on the proposed Cluster Management API (
https://cwiki.apache.org/confluence/display/GEODE/Cluster+Management+Service),
some of us have been exploring introducing Kotlin into the codebase. One of
the things I personally love about Kotlin is null references being
contro
Okay. Please go ahead and merge, I can’t since I’m not a committer.
On Thu, Dec 20, 2018 at 3:00 PM Kirk Lund wrote:
> Looks good. Thanks! I added my approval.
>
> On Thu, Dec 20, 2018 at 2:20 PM Aditya Anchuri
> wrote:
>
> > PR to fix: https://github.com/apache/geode/pul
PR to fix: https://github.com/apache/geode/pull/3030
On Thu, Dec 20, 2018 at 1:58 PM Aditya Anchuri wrote:
> These classes were removed recently, but it looks like we forgot to clean
> up the javadocs. Will make a PR to fix ASAP.
>
> -Aditya
>
> On Thu, Dec 20, 2018 at 1:57 P
These classes were removed recently, but it looks like we forgot to clean
up the javadocs. Will make a PR to fix ASAP.
-Aditya
On Thu, Dec 20, 2018 at 1:57 PM Kirk Lund wrote:
> Just a reminder that any classes not behind internal packages need to have
> functional Javadocs.
>
> We have Javadoc
+1, although I do wonder about the overhead of making PRs increasing more
than it already feels like to me as a new contributor (as the person who
made the geospatial contribution). If this was a gradle task maybe like
spotless?
On Fri, Nov 9, 2018 at 2:20 PM Bruce Schuchardt
wrote:
> I'd like t
n Fri, Nov 9, 2018 at 9:52 AM Aditya Anchuri wrote:
> I apologize, I was slightly wrong earlier with regards to the the IntelliJ
> Lombok plugin -- people will not need the IntelliJ plugin for their code to
> compile -- but they will need to enable compile-time annotation processing
>
Boolean, val
> > startPort:
> > >> Int?, val endPort: Int?, val bindAddress: String, val
> socketBufferSize:
> > >> Int?, val maximumTimeBetweenPings: Int?, val gatewayTransportFilters:
> > >> Array, val hostNameForSender: String, val ifNotExists:
> Boolean)
> > :
> &
al usage I’m agnostic with a small dose of concern on
> equals/hashcode in critical code paths.
>
> My $0.02,
> Anthony
>
>
> > On Nov 8, 2018, at 1:57 PM, Aditya Anchuri wrote:
> >
> > Note: If the PR gets accepted, people that use IntelliJ idea or Eclipse
Also, Kotlin's conciseness is also a language feature rather than
>> library plugin. I've also seen cases where compiled Java was larger than
>> the equivalent compiled Kotlin code.
>>
>> --Udo
>>
>>
>> On 11/8/18 10:31, Aditya Anchuri wrote:
&g
d Java was larger than
> the equivalent compiled Kotlin code.
>
> --Udo
>
>
> On 11/8/18 10:31, Aditya Anchuri wrote:
> > Hi everyone,
> >
> > I am considering adding Lombok as a compile-time dependency (
> > https://projectlombok.org/) so we can reduce the
Hi everyone,
I am considering adding Lombok as a compile-time dependency (
https://projectlombok.org/) so we can reduce the amount of boilerplate code
and reduce the size of some of our classes. I have a small proof of concept
PR ready to go. Before I do so, I want to find out if people have tried
Hello,
I recently forked geode on github and started working on adding geospatial
commands (supported in Redis >3.2) to the Redis adapter (GEOADD, GEOPOS,
GEOHASH, GEODIST, GEORADIUS and GEORADIUSBYMEMBER). I am wrapping up my
work on this, but before I make a PR I would like to know if this is a
13 matches
Mail list logo
