Okay. Please go ahead and merge, I can’t since I’m not a committer. On Thu, Dec 20, 2018 at 3:00 PM Kirk Lund <kl...@apache.org> wrote:
> Looks good. Thanks! I added my approval. > > On Thu, Dec 20, 2018 at 2:20 PM Aditya Anchuri <aanch...@pivotal.io> > wrote: > > > PR to fix: https://github.com/apache/geode/pull/3030 > > > > On Thu, Dec 20, 2018 at 1:58 PM Aditya Anchuri <aanch...@pivotal.io> > > wrote: > > > > > These classes were removed recently, but it looks like we forgot to > clean > > > up the javadocs. Will make a PR to fix ASAP. > > > > > > -Aditya > > > > > > On Thu, Dec 20, 2018 at 1:57 PM Kirk Lund <kl...@apache.org> wrote: > > > > > >> Just a reminder that any classes not behind internal packages need to > > have > > >> functional Javadocs. > > >> > > >> We have Javadoc errors involving > > >> org/apache/geode/cache/configuration/RegionAttributesType.java > referring > > >> to > > >> RegionTimeToLive which I can't find when I grep. > > >> > > >> > Task :geode-assembly:docs > > >> > > >> > > > /Users/klund/dev/gemfire1/open/geode-core/src/main/java/org/apache/geode/cache/configuration/RegionAttributesType.java:479: > > >> warning - Tag @link: reference not found: > > >> RegionAttributesType.RegionTimeToLive > > >> > > >> > > > /Users/klund/dev/gemfire1/open/geode-core/src/main/java/org/apache/geode/cache/configuration/RegionAttributesType.java:490: > > >> warning - Tag @link: reference not found: > > >> RegionAttributesType.RegionTimeToLive > > >> > > >> > > > /Users/klund/dev/gemfire1/open/geode-core/src/main/java/org/apache/geode/cache/configuration/RegionAttributesType.java:501: > > >> warning - Tag @link: reference not found: > > >> RegionAttributesType.RegionIdleTime > > >> > > >> > > > /Users/klund/dev/gemfire1/open/geode-core/src/main/java/org/apache/geode/cache/configuration/RegionAttributesType.java:512: > > >> warning - Tag @link: reference not found: > > >> RegionAttributesType.RegionIdleTime > > >> > > >> > > > /Users/klund/dev/gemfire1/open/geode-core/src/main/java/org/apache/geode/cache/configuration/RegionAttributesType.java:523: > > >> warning - Tag @link: reference not found: > > >> RegionAttributesType.EntryTimeToLive > > >> > > >> > > > /Users/klund/dev/gemfire1/open/geode-core/src/main/java/org/apache/geode/cache/configuration/RegionAttributesType.java:534: > > >> warning - Tag @link: reference not found: > > >> RegionAttributesType.EntryTimeToLive > > >> > > >> > > > /Users/klund/dev/gemfire1/open/geode-core/src/main/java/org/apache/geode/cache/configuration/RegionAttributesType.java:545: > > >> warning - Tag @link: reference not found: > > >> RegionAttributesType.EntryIdleTime > > >> > > >> > > > /Users/klund/dev/gemfire1/open/geode-core/src/main/java/org/apache/geode/cache/configuration/RegionAttributesType.java:556: > > >> warning - Tag @link: reference not found: > > >> RegionAttributesType.EntryIdleTime > > >> 8 warnings > > >> > > > > > >
