Re: [DISCUSS] proposal to pare down old-version testing

2021-12-22 Thread Jacob Barrett
Yes! This! 100%! > On Dec 22, 2021, at 7:14 PM, Owen Nichols wrote: > > Since adopting our N-2 support policy, the list of released versions in > /settings.gradle has ballooned to over 30 entries [1]. > > CI tests use this list to confirm that we don’t break rolling upgrade ability > or comp

[DISCUSS] proposal to pare down old-version testing

2021-12-22 Thread Owen Nichols
Since adopting our N-2 support policy, the list of released versions in /settings.gradle has ballooned to over 30 entries [1]. CI tests use this list to confirm that we don’t break rolling upgrade ability or compatibility with older clients, but some of these tests don’t seem to scale well: PR#

Re: [DISCUSS] Adding LTGM as gating PR checks

2021-12-22 Thread Kirk Lund
I support making LGTM a gating job on every PR. On Thu, Dec 16, 2021 at 2:46 PM Alexander Murmann wrote: > +1 to adding this. Given it has a low false-positive rate, only checks on > code actually changed in the PR and runs quickly compared to some of our > other steps that already happen for ev