This was done to reduce the workload on the developers.
It's a kind of "fire and forget" methodology.
Why make the author come back and merge the PR after my(release manager's)
approval when I can do it myself.
But yeah, blocking the PR, till the release manager approves it makes sense.
Regards
Why not a model where the release manager is a blocking review and let the
author merge only when they blocking review is complete? That makes the process
largely identical to that of the develop branch abs removes this ambiguity of
who merges and when.
> On Jun 29, 2021, at 4:19 PM, Nabarun Na
I just do the merging to have a sanitized and approved list of PRs go into the
support/1.14. Limit the number of commits that may cause an explosion.
Also, I communicate with the author about PR, if it is ready to be merged or if
I have concerns about the PR.
I will not merge your PR but feel f
Hi Naba, is it still the case that only you will merge the PRs to support/1.14?
Or can committers merge their own 1.14 PRs anytime after you have approved the
PR?
I sometimes forget to create my PRs in Draft mode, and may still be running
additional tests, so I'd prefer not to have anyone but
+1
User Guide build scripts are broken, but this is a known bug and should not
delay the release.
A compiled 1.12 User Guide is available on the website, and a knowledgeable
user can build manually as a workaround.
I have back-ported the fix to 1.12 from 1.13, so in the event of a new
release candi
Looking at the positive feedback, to this, I am skipping the red tape of
creating a separate vote thread. The PR has been created and reviewed.[1]
Regards,
Nabarun
[1] https://github.com/apache/geode/pull/6661
From: Darrel Schneider
Sent: Tuesday, June 29, 20
+1
From: Jens Deppe
Sent: Tuesday, June 29, 2021 7:44 AM
To: dev@geode.apache.org
Subject: Re: Fw: [DISCUSS] Rebase and Squash Options on Github develop
+1 For Naba’s proposal
From: Joris Melchior
Date: Tuesday, June 29, 2021 at 7:40 AM
To: dev@geode.apache.org
+1 For Naba’s proposal
From: Joris Melchior
Date: Tuesday, June 29, 2021 at 7:40 AM
To: dev@geode.apache.org
Subject: Re: Fw: [DISCUSS] Rebase and Squash Options on Github develop
+1 for Naburan’s proposed options.
From: Nabarun Nag
Date: Monday, June 28, 2021 at 4:06 PM
To: Owen Nichols , dev
+1 for Naburan’s proposed options.
From: Nabarun Nag
Date: Monday, June 28, 2021 at 4:06 PM
To: Owen Nichols , dev@geode.apache.org
Subject: Re: Fw: [DISCUSS] Rebase and Squash Options on Github develop
Just a clarification.
The options I am proposing to be kept in the PRs are:
* Squash a
