+1 For Naba’s proposal From: Joris Melchior <jmelch...@vmware.com> Date: Tuesday, June 29, 2021 at 7:40 AM To: dev@geode.apache.org <dev@geode.apache.org> Subject: Re: Fw: [DISCUSS] Rebase and Squash Options on Github develop +1 for Naburan’s proposed options.
From: Nabarun Nag <n...@vmware.com> Date: Monday, June 28, 2021 at 4:06 PM To: Owen Nichols <onich...@vmware.com>, dev@geode.apache.org <dev@geode.apache.org> Subject: Re: Fw: [DISCUSS] Rebase and Squash Options on Github develop Just a clarification. The options I am proposing to be kept in the PRs are: * Squash and merge * Rebase and merge Regards, Nabarun ________________________________ From: Owen Nichols <onich...@vmware.com> Sent: Monday, June 28, 2021 1:03 PM To: Nabarun Nag <n...@vmware.com>; dev@geode.apache.org <dev@geode.apache.org> Subject: Re: Fw: [DISCUSS] Rebase and Squash Options on Github develop Sounds like a good idea. I can’t find any example of an intentional merge commit on develop…but plenty of accidental ones. Upon releases we do a command line merge commit to the main trunk, which should still be fine as this proposal only applies to PRs. I agree with still allowing rebase commits. I have seen several PRs use them to good effect. You can disable merge commits through .asf.yaml, so changing the setting is as easy as opening a PR (and, if we don’t like it, reverting is just as easy) --- Sent from Workspace ONE Boxer<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwhatisworkspaceone.com%2Fboxer&data=04%7C01%7Cjdeppe%40vmware.com%7C6fa6793b726442ef3a0808d93b0be198%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637605744486487010%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=u2ACIO9HM1BRNpKUpALLp0UtW2vJnioIPqjEvD79f1c%3D&reserved=0> On June 28, 2021 at 12:38:50 PM PDT, Nabarun Nag <n...@vmware.com> wrote: Hi all, Last year, we had a discussion on rebase and squash merge PRs to the develop branch, * to have linear git history * help with bisecting * easier root cause analysis of failures * easier to backport changes However, many developers have reached out mentioning that sometimes they have clicked the merge button in hurry when they meant to rebase/squash. Once clicked there is no going back. All of them suggested that to have the GitHub setting on develop branch to rebase and squash merge option and hence there is no room for mistakes to occur. I would like to propose to that we set the GitHub setting on develop PR to rebase and squash buttons. Please do note that this is reversible and can be changed back, hence there is no harm in trying it out. Regards Nabarun Nag ________________________________ From: Owen Nichols (Pivotal) <onich...@pivotal.io> Sent: Thursday, April 9, 2020 11:45 AM To: dev@geode.apache.org <dev@geode.apache.org> Subject: Re: [REQUEST] Squash merge please I’ve noticed quite a few PRs in the last week that were merged with “Merge” rather than “Squash and Merge”. While the community consensus was to continue to allow all merge options, please try to default to “Squash and Merge” whenever you can to keep history as linear as possible. GitHub will save the last method you used in a cookie, which helps, but then it’s easy to miss when it resets itself back to the default of “Merge” some months later because you cleared cookies, changed browsers, etc. > On Oct 22, 2019, at 5:12 PM, Nabarun Nag <n...@pivotal.io> wrote: > > Hi Geode Committers, > > A kind request for using squash commit instead of using merge. > This will really help us in our bisect operations when a regression/flakiness > in the product is introduced. We can automate and go through fewer commits > faster, avoiding commits like "spotless fix" and "re-trigger precheck-in" or > other minor commits in the merged branch. > > Also, please use the commit format : (helps us to know who worked on it, what > is the history) > GEODE-xxxx: <brief intro > > > * explanation line 1 > * explanation line 2 > > This is not a rule or anything, but a request to help out your fellow > committers in quickly detecting a problem. > > For inspiration, we can look into Apache Kafka / Spark where they have a > complete linear graph for their main branch HEAD [see attachment] > > Regards > Naba. > >
