[GitHub] [geode] albertogpz commented on a change in pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

albertogpz commented on a change in pull request #4928: URL: https://github.com/apache/geode/pull/4928#discussion_r411879596 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderQueue.java ## @@ -410,6 +441,53 @@ public Object pe

[GitHub] [geode] albertogpz commented on a change in pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

albertogpz commented on a change in pull request #4928: URL: https://github.com/apache/geode/pull/4928#discussion_r411879596 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderQueue.java ## @@ -410,6 +441,53 @@ public Object pe

[GitHub] [geode] albertogpz commented on issue #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

albertogpz commented on issue #4928: URL: https://github.com/apache/geode/pull/4928#issuecomment-616957705 > Sorry, I haven't had time to dig deeply into this PR. > > There were some concerns on the rfc for interleaving or out of ordering of events. I might have missed it, but were t

[GitHub] [geode] demery-pivotal opened a new pull request #4977: GEODE-7851: Pulse refreshes expired access tokens

demery-pivotal opened a new pull request #4977: URL: https://github.com/apache/geode/pull/4977 If a user's access token expires, Pulse attempts to refresh it. If the refresh fails, Pulse logs the user out and redirects the browser to /pulse/clusterLogout. Changes in Repository:

Re: GitHub notifications?

Filed https://issues.apache.org/jira/browse/INFRA-20156 . This hit other projects as well. Anthony > On Apr 20, 2020, at 9:10 AM, Nicholas Vallely wrote: > > No, but it's annoying:) > > On Mon, Apr 20, 2020 at 7:48 AM Anthony Baker wrote:

[GitHub] [geode] davebarnes97 commented on issue #4975: Logging documentation fixes

davebarnes97 commented on issue #4975: URL: https://github.com/apache/geode/pull/4975#issuecomment-616863201 Thanks for this contribution, @alb3rtobr. For the gfsh command reference writeup on change loglevel, I'd like to suggest a minor re-wording, which replaces future tense with pres

[GitHub] [geode] jchen21 commented on a change in pull request #4970: GEODE-7676: Add PR clear with expiration tests

jchen21 commented on a change in pull request #4970: URL: https://github.com/apache/geode/pull/4970#discussion_r411699051 ## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithExpirationDUnitTest.java ## @@ -0,0 +1,535 @@ +

[GitHub] [geode] prettyClouds commented on a change in pull request #4973: improvement/GEODE-8002 Refactor: Extract class to encapsulate concurrent execution

prettyClouds commented on a change in pull request #4973: URL: https://github.com/apache/geode/pull/4973#discussion_r411691444 ## File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/general/LoopingThreads.java ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apac

[GitHub] [geode] DonalEvans commented on a change in pull request #4970: GEODE-7676: Add PR clear with expiration tests

DonalEvans commented on a change in pull request #4970: URL: https://github.com/apache/geode/pull/4970#discussion_r411591697 ## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithExpirationDUnitTest.java ## @@ -0,0 +1,535 @

[GitHub] [geode] karensmolermiller opened a new pull request #4976: GEODE-7997: Document needed location of parallel gateway sender disk …

karensmolermiller opened a new pull request #4976: URL: https://github.com/apache/geode/pull/4976 …stores Reviewers: I put the same information in 3 distinct locations. It is my hope that Geode-users who need this info will encounter it in one of those places when they look at the d

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #4973: improvement/GEODE-8002 Refactor: Extract class to encapsulate concurrent execution

dschneider-pivotal commented on a change in pull request #4973: URL: https://github.com/apache/geode/pull/4973#discussion_r411592696 ## File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/general/LoopingThreads.java ## @@ -0,0 +1,88 @@ +/* + * Licensed to th

[GitHub] [geode] jhuynh1 commented on a change in pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

jhuynh1 commented on a change in pull request #4928: URL: https://github.com/apache/geode/pull/4928#discussion_r411587074 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderQueue.java ## @@ -410,6 +441,53 @@ public Object peek(

Re: [PROPOSAL]: GEODE-7940 to support/1.12

Hello all, Thanks for the feedback. There seems to be enough consensus in that this is a critical fix, so I've cherry-picked the commit to the support/1.12 branch already (and updated the Fixed Versions field in JIRA). Best regards. On Mon, 20 Apr 2020 at 18:41, Owen Nichols wrote: > Weekend te

Reviews needed on Restore Redundancy PR

This PR has been open for a while now with only one review so I thought I'd request that a few more people please give it a look over: https://github.com/apache/geode/pull/4909 There was quite a lot of discussion/activity on the RFC for this, so it would be helpful if the people who had request

Re: [PROPOSAL]: GEODE-7940 to support/1.12

Weekend testing looks good to me +1 > On Apr 17, 2020, at 3:26 PM, Robert Houghton wrote: > > Conditional +1 from me too, pending a few days on develop with happy > results :) > > Thanks Juan! > > On Fri, Apr 17, 2020 at 1:41 AM Ju@N wrote: > >> Hello devs, >> >> I'd like to propose bringi

[GitHub] [geode] pivotal-jbarrett commented on issue #4969: GEODE-7995: Creates concurrencyTest facet

pivotal-jbarrett commented on issue #4969: URL: https://github.com/apache/geode/pull/4969#issuecomment-616692247 Very specifically we use a plugin called facet that creates all these things for us. https://plugins.gradle.org/plugin/nebula.facet -

[GitHub] [geode] bschuchardt commented on issue #4974: Revert "GEODE-7565: Allow gateway receivers with same host and port

bschuchardt commented on issue #4974: URL: https://github.com/apache/geode/pull/4974#issuecomment-616668765 The problem might be in changes to Ping.java. It may send an error response back to the client with MessageType.PING, which maybe the client isn't equipped to deal with. -

Re: About Geode rolling downgrade

Hi, I agree that if we wanted to support limited rolling downgrade some other version interchange needs to be done and extra tests will be required. Nevertheless, this could be done using gfsh or with a startup parameter. For example, in the case you mentioned about the UDP messaging, some comm

Re: GitHub notifications?

No, but it's annoying:) On Mon, Apr 20, 2020 at 7:48 AM Anthony Baker wrote: > Hmmm, it looks like GitHub notifications are coming to dev@ instead of > notifications@. > > Did anyone request this change? > > Anthony > >

RE: About "change loglevel" command

Hi Kirk, Thanks for the info, we were not aware of it. We are using filters in our configuration so we are not taking advantage of the optimization you mentioned. I think this is something that should be included in the documentation. I have created a PR: https://github.com/apache/geode/pull/497

[GitHub] [geode] alb3rtobr opened a new pull request #4975: Logging documentation fixes

alb3rtobr opened a new pull request #4975: URL: https://github.com/apache/geode/pull/4975 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] kirklund commented on issue #4969: GEODE-7995: Creates concurrencyTest facet

kirklund commented on issue #4969: URL: https://github.com/apache/geode/pull/4969#issuecomment-616645957 > What do we mean by facet in this context? I think it means (1) src set, (2) gradle target to execute tests in the src set, (3) pipeline job in CI and PR. -

[GitHub] [geode] jujoramos edited a comment on issue #4974: Revert "GEODE-7565: Allow gateway receivers with same host and port

jujoramos edited a comment on issue #4974: URL: https://github.com/apache/geode/pull/4974#issuecomment-616565367 @alb3rtobr: I'm just tagging you as you are the author of the original commit so you're aware of the revert request, I'll try to reproduce the issue using a `DistributedTest` an

[GitHub] [geode] jujoramos edited a comment on issue #4974: Revert "GEODE-7565: Allow gateway receivers with same host and port

jujoramos edited a comment on issue #4974: URL: https://github.com/apache/geode/pull/4974#issuecomment-616565367 @alb3rtobr: I'm just tagging you as you are the author of the original commit so you're aware of the revert request, I'll try to reproduce the issue using a `DistributedTest` an

GitHub notifications?

Hmmm, it looks like GitHub notifications are coming to dev@ instead of notifications@. Did anyone request this change? Anthony

[GitHub] [geode] jujoramos edited a comment on issue #4974: Revert "GEODE-7565: Allow gateway receivers with same host and port

jujoramos edited a comment on issue #4974: URL: https://github.com/apache/geode/pull/4974#issuecomment-616565367 @alb3rtobr: I'm just tagging you as you are the author of the original commit so you're aware of the revert request, I'll try to reproduce the issue using a `DistributedTest` an

[GitHub] [geode] jujoramos commented on issue #4974: Revert "GEODE-7565: Allow gateway receivers with same host and port

jujoramos commented on issue #4974: URL: https://github.com/apache/geode/pull/4974#issuecomment-616565367 @alb3rtobr This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [geode] jujoramos opened a new pull request #4974: Revert "GEODE-7565: Allow gateway receivers with same host and port

jujoramos opened a new pull request #4974: URL: https://github.com/apache/geode/pull/4974 This reverts commit dd23ee8200cba67cea82e57e2e4ccedcdf9e8266. Intermittent errors were observed while executing some internal tests and commit dd23ee8200cba67cea82e57e2e4ccedcdf9e8266 was determ

[GitHub] [geode] jvarenina commented on a change in pull request #4967: GEODE-7989: Improve backup exceptions logging

jvarenina commented on a change in pull request #4967: URL: https://github.com/apache/geode/pull/4967#discussion_r411170968 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/backup/BackupService.java ## @@ -74,6 +74,9 @@ public BackupService(InternalCache

[GitHub] [geode] mkevo commented on a change in pull request #4967: GEODE-7989: Improve backup exceptions logging

mkevo commented on a change in pull request #4967: URL: https://github.com/apache/geode/pull/4967#discussion_r411162666 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/backup/BackupService.java ## @@ -74,6 +74,9 @@ public BackupService(InternalCache cach