Re: SSL Alias Support for JMX Connections

2019-08-08 Thread Owen Nichols
Hi Juan and Sai, thank you for bringing your concern. Geode's release process dictates a time-based schedule to cut release branches. The release/1.10.0 branch was already

Re: SSL Alias Support for JMX Connections

2019-08-08 Thread Sai Boorlagadda
+1 for getting this into 1.10 On Thu, Aug 8, 2019 at 11:29 AM Juan José Ramos wrote: > I'd like to propose including the fix for *GEODE-7022 [1]* in release > 1.10.0. > The fix basically improves our own implementation of the > *RMIClientSocketFactory* to fully support the GEODE SSL settings, al

Re: Fix for ClassCastException when using Logback for 1.10.0

2019-08-08 Thread Owen Nichols
There appears to be consensus that this is a critical fix. The following commit has been brought into support/1.10.0 as the critical fix for GEODE-7050 : git cherry-pick -x e5c9c420f462149fd0

Re: Unit tests are hanging?

2019-08-08 Thread Ryan McMahon
I have a PR up for this now. https://github.com/apache/geode/pull/3900 It bumps the timeout to 20 minutes but also changes the CALL_STACK_TIMEOUT to be 1140 seconds (19 minutes). The latter configuration parameter controls when we declare the task "hung" and dump stacks. We were not dumping stac

Re: geode-native ipv6

2019-08-08 Thread Blake Bender
This chunk of code in the client handshake code leads me to believe it is still IPv4 only. Won't say it's definitive, cause I'm not 100% certain hostaddr is used on the server side, but still... // writing first 4 bytes of the address. This will be same until // IPV6 support is added in the clien

Re: geode-native ipv6

2019-08-08 Thread Mark Hanson
I just tried to connect to Geode with the native client and it did not go well. It exceptioned with an illegal argument error. That said, it “seems" like it might not be complicated to make it IPv6 compliant. Thanks, Mark > On Aug 8, 2019, at 9:56 AM, Mark Hanson wrote: > > The latest ACE f

Re: geode-native ipv6

2019-08-08 Thread Jacob Barrett
We are on the latest ACE. > On Aug 8, 2019, at 9:56 AM, Mark Hanson wrote: > > The latest ACE framework seems to have support, but I don’t know how far off > latest we are. I don’t think we test anything in an IPv6 context, so I would > say no that we don’t officially support it in the client.

Re: Fix for ClassCastException when using Logback for 1.10.0

2019-08-08 Thread John Blum
+1 On Thu, Aug 8, 2019 at 11:31 AM Juan José Ramos wrote: > +1 > > On Thu, Aug 8, 2019 at 7:26 PM Mark Hanson wrote: > > > +1 > > > > I think it is valuable to make life easier for Spring Boot users. > > > > Thanks, > > Mark > > > > > On Aug 8, 2019, at 11:24 AM, Kirk Lund wrote: > > > > > > T

Re: Fix for ClassCastException when using Logback for 1.10.0

2019-08-08 Thread Juan José Ramos
+1 On Thu, Aug 8, 2019 at 7:26 PM Mark Hanson wrote: > +1 > > I think it is valuable to make life easier for Spring Boot users. > > Thanks, > Mark > > > On Aug 8, 2019, at 11:24 AM, Kirk Lund wrote: > > > > This is the last logging related fix that I'd like to propose adding to > > 1.10.0 > > r

SSL Alias Support for JMX Connections

2019-08-08 Thread Juan José Ramos
I'd like to propose including the fix for *GEODE-7022 [1]* in release 1.10.0. The fix basically improves our own implementation of the *RMIClientSocketFactory* to fully support the GEODE SSL settings, allowing our users to specify a default alias when opening an RMI connection. Best regards. [1]:

Re: Unit tests are hanging?

2019-08-08 Thread Ryan McMahon
Looks like we have a general consensus from the community. I'll go ahead and make a PR for the changes. Thanks, Ryan On Thu, Aug 8, 2019 at 11:03 AM Juan José Ramos wrote: > +1 > > On Thu, Aug 8, 2019 at 6:55 PM Kirk Lund wrote: > > > +1 > > > > On Thu, Aug 8, 2019 at 10:14 AM Dan Smith wrot

Re: Fix for ClassCastException when using Logback for 1.10.0

2019-08-08 Thread Mark Hanson
+1 I think it is valuable to make life easier for Spring Boot users. Thanks, Mark > On Aug 8, 2019, at 11:24 AM, Kirk Lund wrote: > > This is the last logging related fix that I'd like to propose adding to > 1.10.0 > release branch. > > Spring Boot adds Logback and log4j-to-slf4j to the clas

Fix for ClassCastException when using Logback for 1.10.0

2019-08-08 Thread Kirk Lund
This is the last logging related fix that I'd like to propose adding to 1.10.0 release branch. Spring Boot adds Logback and log4j-to-slf4j to the classpath. This results in ClassCastExceptions if log4j-core is not excluded. This change prevents Geode from using Log4jAgent if Log4j Core is present

Re: Fix for NPE during forceDisconnect candidate for 1.10.0

2019-08-08 Thread Juan José Ramos
+1 On Thu, Aug 8, 2019 at 7:02 PM John Blum wrote: > +1 for Kirk's changes in 1.10. This will be critical for SD Neuman and > SBDG 1.3. > > On Thu, Aug 8, 2019 at 10:57 AM Owen Nichols wrote: > > > Hi Kirk and Mark, thank you for bringing your concern. > > > > Our “critical fixes” rule allows

Re: Unit tests are hanging?

2019-08-08 Thread Juan José Ramos
+1 On Thu, Aug 8, 2019 at 6:55 PM Kirk Lund wrote: > +1 > > On Thu, Aug 8, 2019 at 10:14 AM Dan Smith wrote: > > > > With all that, I propose we permanently bump the timeouts on UnitTestX > > jobs > > > across the board (main pipeline, PR pipeline, etc) from 10 to 20 > minutes > > to > > > be m

Re: Fix for NPE during forceDisconnect candidate for 1.10.0

2019-08-08 Thread John Blum
+1 for Kirk's changes in 1.10. This will be critical for SD Neuman and SBDG 1.3. On Thu, Aug 8, 2019 at 10:57 AM Owen Nichols wrote: > Hi Kirk and Mark, thank you for bringing your concern. > > Our “critical fixes” rule allows critical fixes to be brought to the > release branch by proposal on

Re: Fix for NPE during forceDisconnect candidate for 1.10.0

2019-08-08 Thread Owen Nichols
Hi Kirk and Mark, thank you for bringing your concern. Our “critical fixes” rule allows critical fixes to be brought to the release branch by proposal on the dev list, as you have just done. If there is consensus from the Geode community that this NPE fix satisfies the “critical fixes” rule, D

Re: Unit tests are hanging?

2019-08-08 Thread Kirk Lund
+1 On Thu, Aug 8, 2019 at 10:14 AM Dan Smith wrote: > > With all that, I propose we permanently bump the timeouts on UnitTestX > jobs > > across the board (main pipeline, PR pipeline, etc) from 10 to 20 minutes > to > > be more tolerant of these types of degradations. > > > > +1 > > -Dan >

Fix for NPE during forceDisconnect candidate for 1.10.0

2019-08-08 Thread Kirk Lund
I'd like to propose including the fix for GEODE-6959 in 1.10.0. Spring Boot users are very likely to hit this NPE during forceDisconnect. If a custom log4j2.xml is used without specifying the Geode AlertAppender, GMSMembershipManager may throw a NullPointerException when invoking AlertAppender.ge

Re: Another change for 1.10.0 release

2019-08-08 Thread Owen Nichols
There appears to be consensus that this is a critical fix. The following commit has been brought into support/1.10.0 as the critical fix for GEODE-7055 : git cherry-pick -x 1438b56bf7ef44e758

Re: Another change for 1.10.0 release

2019-08-08 Thread Juan José Ramos
+1 On Thu, Aug 8, 2019 at 6:41 PM Ryan McMahon wrote: > +1 > > On Thu, Aug 8, 2019 at 10:40 AM John Blum wrote: > > > +1 for Dan's changes. > > > > On Thu, Aug 8, 2019 at 10:28 AM Owen Nichols > wrote: > > > > > Hi Dan, thank you for bringing your concern. > > > > > > Our “critical fixes” rule

Re: Another change for 1.10.0 release

2019-08-08 Thread Ryan McMahon
+1 On Thu, Aug 8, 2019 at 10:40 AM John Blum wrote: > +1 for Dan's changes. > > On Thu, Aug 8, 2019 at 10:28 AM Owen Nichols wrote: > > > Hi Dan, thank you for bringing your concern. > > > > Our “critical fixes” rule allows critical fixes to be brought to the > > release branch by proposal on t

Re: Another change for 1.10.0 release

2019-08-08 Thread John Blum
+1 for Dan's changes. On Thu, Aug 8, 2019 at 10:28 AM Owen Nichols wrote: > Hi Dan, thank you for bringing your concern. > > Our “critical fixes” rule allows critical fixes to be brought to the > release branch by proposal on the dev list [as you have just done]. If > there is consensus from th

Re: Another change for 1.10.0 release

2019-08-08 Thread Owen Nichols
Hi Dan, thank you for bringing your concern. Our “critical fixes” rule allows critical fixes to be brought to the release branch by proposal on the dev list [as you have just done]. If there is consensus from the Geode community that this GEODE-7055 fix satisfies the “critical fixes” rule, Dic

Re: Unit tests are hanging?

2019-08-08 Thread Dan Smith
> With all that, I propose we permanently bump the timeouts on UnitTestX jobs > across the board (main pipeline, PR pipeline, etc) from 10 to 20 minutes to > be more tolerant of these types of degradations. > +1 -Dan

Another change for 1.10.0 release

2019-08-08 Thread Dan Smith
Hi all, I'd like to get the fix for GEODE-7055 (Don't send failure replies from a P2P reader thread) into the 1.10.0 release branch. This bug was causing a hang on startup for users of the session replication module that didn't put the session jars on the classpath of the locator. The hang doesn'

Re: geode-native ipv6

2019-08-08 Thread Mark Hanson
The latest ACE framework seems to have support, but I don’t know how far off latest we are. I don’t think we test anything in an IPv6 context, so I would say no that we don’t officially support it in the client. Given some time, I could do some testing.. Thanks, Mark > On Aug 8, 2019, at 7:35

Re: Unit tests are hanging?

2019-08-08 Thread Ryan McMahon
So we temporarily bumped the timeout from 10 minutes to 2 hours on the UnitTestOpenJDK11 execute_tests Concourse task, originally with the intention of logging into the heavy lifter to debug further. However, after doing that we see that the jobs are all succeeding in roughly the same amount of ti

Re: geode-native ipv6

2019-08-08 Thread Blake Bender
I'm sure someone will chime in with a more definitive answer, but I'm pretty certain the answer is no, sorry. Thanks, Blake On Thu, Aug 8, 2019 at 4:28 AM Mario Ivanac wrote: > Hi, > > > can you tell me does geode-native client support ipv6? > > > BR, > > Mario >

geode-native ipv6

2019-08-08 Thread Mario Ivanac
Hi, can you tell me does geode-native client support ipv6? BR, Mario

Re: Reviewers for PR

2019-08-08 Thread Mario Ivanac
Hi, could someone review PR https://github.com/apache/geode/pull/3854. Thanks Šalje: Mark Hanson Poslano: 6. kolovoza 2019. 19:21:42 Prima: dev@geode.apache.org Predmet: Reviewers for PR Hi All, Here is another PR that could use reviewers. GEODE-6748: Firs