There appears to be consensus that this is a critical fix.

The following commit has been brought into support/1.10.0 
<https://github.com/apache/geode/tree/release/1.10.0> as the critical fix for 
GEODE-7050 <https://issues.apache.org/jira/browse/GEODE-7050>:

git cherry-pick -x e5c9c420f462149fd062847904e3435fbe99afb4 
<https://github.com/apache/geode/commit/e5c9c420f462149fd062847904e3435fbe99afb4>

GEODE-7050 <https://issues.apache.org/jira/browse/GEODE-7050> has been marked 
as 'resolved in' 1.10.0.

-Owen

> On Aug 8, 2019, at 11:36 AM, John Blum <jb...@pivotal.io> wrote:
> 
> +1
> 
> On Thu, Aug 8, 2019 at 11:31 AM Juan José Ramos <jra...@pivotal.io> wrote:
> 
>> +1
>> 
>> On Thu, Aug 8, 2019 at 7:26 PM Mark Hanson <mhan...@pivotal.io> wrote:
>> 
>>> +1
>>> 
>>> I think it is valuable to make life easier for Spring Boot users.
>>> 
>>> Thanks,
>>> Mark
>>> 
>>>> On Aug 8, 2019, at 11:24 AM, Kirk Lund <kl...@pivotal.io> wrote:
>>>> 
>>>> This is the last logging related fix that I'd like to propose adding to
>>>> 1.10.0
>>>> release branch.
>>>> 
>>>> Spring Boot adds Logback and log4j-to-slf4j to the classpath. This
>>>> results in ClassCastExceptions if log4j-core is not excluded.
>>>> 
>>>> This change prevents Geode from using Log4jAgent if Log4j Core is
>>>> present but not using Log4jProvider.
>>>> 
>>>> For example, Log4j uses SLF4JProvider instead of Log4jProvider when
>>>> log4j-to-slf4j is in the classpath.
>>>> 
>>>> By disabling Log4jAgent when other Log4j Providers are in use, this
>>>> prevents problems such as ClassCastExceptions when attempting to cast
>>>> loggers from org.apache.logging.slf4j.SLF4JLogger to
>>>> org.apache.logging.log4j.core.Logger to get the LoggerConfig or
>>>> LoggerContext.
>>>> 
>>>> PR: https://github.com/apache/geode/pull/3892
>>>> GEODE-7050: Use Log4jAgent only if Log4j is using Log4jProvider
>>>> https://issues.apache.org/jira/browse/GEODE-7050
>>>> 
>>>> Thanks,
>>>> Kirk and Aaron
>>> 
>>> 
>> 
>> --
>> Juan José Ramos Cassella
>> Senior Software Engineer
>> Email: jra...@pivotal.io
>> 
> 
> 
> -- 
> -John
> john.blum10101 (skype)

Reply via email to