Re: Avoiding Unpredictability in Our DUnit Testing Rules

2018-11-21 Thread Mark Hanson
It is frowned upon. VM.getVM(0) is now the accepted way to get VM 0. Thanks, Mark > On Nov 21, 2018, at 10:41 AM, Nabarun Nag wrote: > > Will doing this in the test, > > final Host host = Host.getHost(0); > VM server1 = host.getVM(startingVersion, 0); > > be frowned upon, if I use the abov

Re: PowerMock unit test errors

2018-11-21 Thread Ryan McMahon
Just thought I'd share - after a second pass at this I was able to avoid PowerMock when modifying the class under test to use constructor DI. I think initially I was a bit reluctant to modify the production code here but on a second look I think it was the right thing to do. Just wanted to share

Re: Release branch for Apache Geode 1.8.0 has been cut

2018-11-21 Thread Alexander Murmann
Hi Ryan, This looks like a solid fix to a critical issue. 👍from me if everyone else agree. On Wed, Nov 21, 2018 at 11:00 AM Ryan McMahon wrote: > HI Alexander, > > I have another fix that I believe would be beneficial for the 1.8 release. > We have seen that issues related to intermittent DNS l

Re: Avoiding Unpredictability in Our DUnit Testing Rules

2018-11-21 Thread Patrick Rhomberg
Within a test itself, reaching out to the host / VM that way should be fine, since you know that it will be executing after any rule's before() method. On Wed, Nov 21, 2018 at 10:49 AM Nabarun Nag wrote: > Will doing this in the test, > > final Host host = Host.getHost(0); > VM server1 = host.g

Re: Avoiding Unpredictability in Our DUnit Testing Rules

2018-11-21 Thread Nabarun Nag
Will doing this in the test, final Host host = Host.getHost(0); VM server1 = host.getVM(startingVersion, 0); be frowned upon, if I use the above over using @Rule. Regards Nabarun Nag > On Nov 21, 2018, at 10:36 AM, Robert Houghton wrote: > > Great find, Patrick. I hope this shakes out some o

Re: Avoiding Unpredictability in Our DUnit Testing Rules

2018-11-21 Thread Robert Houghton
Great find, Patrick. I hope this shakes out some of the test bugs! On Wed, Nov 21, 2018, 10:34 Patrick Rhomberg tl;dr: Use JUnit RuleChain. > > > Hello all! > > Several [1] of our test @Rule classes make use of the fact that our DUnit > VMs Host is statically accessible to affect every test

Avoiding Unpredictability in Our DUnit Testing Rules

2018-11-21 Thread Patrick Rhomberg
tl;dr: Use JUnit RuleChain. Hello all! Several [1] of our test @Rule classes make use of the fact that our DUnit VMs Host is statically accessible to affect every test VM. For instance, the SharedCountersRule initializes a counter in every VM, and the CleanupDUnitVMsRule bounces VMs before

Re: Release branch for Apache Geode 1.8.0 has been cut

2018-11-21 Thread Ryan McMahon
HI Alexander, I have another fix that I believe would be beneficial for the 1.8 release. We have seen that issues related to intermittent DNS lookup failures can cause WAN event processing to cease where a retry would have been more appropriate. The fix is already merged to develop. May I cherry