Hi Ryan, This looks like a solid fix to a critical issue. 👍from me if everyone else agree.
On Wed, Nov 21, 2018 at 11:00 AM Ryan McMahon <rmcma...@pivotal.io> wrote: > HI Alexander, > > I have another fix that I believe would be beneficial for the 1.8 release. > We have seen that issues related to intermittent DNS lookup failures can > cause WAN event processing to cease where a retry would have been more > appropriate. The fix is already merged to develop. May I cherry pick it > back to 1.8 release branch as well? > > https://issues.apache.org/jira/browse/GEODE-6065 > > Thanks, > Ryan > > On Thu, Nov 15, 2018 at 10:19 AM Alexander Murmann <amurm...@pivotal.io> > wrote: > > > Ryan, Jason & Nabarun, these all look like critical issues to me that we > > should address in 1.8 to not introduce a regression. If nobody else has > an > > objection, I am fine with you cherry-picking these into the relase > branch. > > > > Thanks! > > > > On Wed, Nov 14, 2018 at 5:19 PM Nabarun Nag <n...@pivotal.io> wrote: > > > > > I would also like to put in the fix for GEODE-6053. It's in the review > > > phase and soon will be in the develop and the release branch. > > > > > > Regards > > > Nabarun Nag > > > > > > > On Nov 14, 2018, at 10:28 AM, Jason Huynh <jhu...@pivotal.io> wrote: > > > > > > > > I'd like to cherry pick the following two commits to release/1.8. > > > > > > > > > > > > > > > > > > https://github.com/apache/geode/commit/6d9e026feb584309dff269e593417082a71434fc > > > > > > > > > > > > > > https://github.com/apache/geode/commit/d22e83e167f261e933b79b2619367d2e1b788db6 > > > > > > > > > > > > Reason: There was a previous commit that modified the way > > > > FunctionInvocationTargetExceptions were being wrapped or sent back to > > the > > > > client. This could negatively impact a user that was drilling down > > into > > > > exceptions.getCause() methods as sometimes it would be null. These > two > > > > commits restore the behavior for any client between 1.0-1.7. > > > > > > > > > > > > Thanks, > > > > > > > > -Jason > > > > > > > > On Mon, Nov 12, 2018 at 5:47 PM Ryan McMahon <rmcma...@pivotal.io> > > > wrote: > > > > > > > >> Hi Alexander, > > > >> > > > >> I would like to cherry pick the following commits from develop to > > > >> release/1.8.0: > > > >> > > > >> > > > >> > > > > > > https://github.com/apache/geode/commit/e9ea18e18c85b977b91192d4edbb9a4e18b2643e > > > >> *Reason*: This was a revert of a previous commit which addressed > data > > > >> inconsistencies between WAN sites, but it was found the fix > introduced > > > >> several other inconsistencies. > > > >> > > > >> > > > >> > > > > > > https://github.com/apache/geode/commit/aab0198e8478d4246042b2eb889c8ce7e28bb52e > > > >> *Reason: *This fixes a race condition in the QueryMonitor which > causes > > > an > > > >> unexpected RejectedExecutionException in monitorQuery() > > > >> > > > >> Please let me know if this sounds reasonable and I can go ahead and > > > begin > > > >> the cherry picking process. > > > >> > > > >> Thanks! > > > >> Ryan > > > >> > > > >> > > > >> On Thu, Nov 8, 2018 at 1:54 PM Alexander Murmann < > amurm...@pivotal.io > > > > > > >> wrote: > > > >> > > > >>> Hello everyone, > > > >>> > > > >>> As discussed previously created a new release branch for Apache > Geode > > > >> 1.8.0 > > > >>> - "release/1.8.0" > > > >>> > > > >>> Please do review and raise any concern with the release branch. > > > >>> If no concerns are raised, we will start with the voting for the > > > release > > > >>> candidate soon. > > > >>> > > > >>> This also means that all tickets JIRA that get resolved on develop > > > should > > > >>> be marked with 1.9.0 as their fix version. > > > >>> > > > >>> Thanks! > > > >>> > > > >>> Alexander > > > >>> > > > >> > > > > > > > > >
