Re: Geode Jira/GitHub Integration configuration changes

2017-12-27 Thread Kirk Lund
I'm keeping INFRA-15727 to confirm that the changes have also been made to the geode-native and geode-examples repos. On Wed, Dec 27, 2017 at 3:41 PM, Kirk Lund wrote: > Karen just submitted a PR (#1208). It posted a nice short comment about > the PR to GEODE-4170 without diffs. Looks good to me

Re: Geode Jira/GitHub Integration configuration changes

2017-12-27 Thread Kirk Lund
Karen just submitted a PR (#1208). It posted a nice short comment about the PR to GEODE-4170 without diffs. Looks good to me! I'm going to close INFRA-15727 as fixed. If anyone notices anything not quite right, please let me know and provide a URL. Thanks, Kirk On Wed, Dec 27, 2017 at 3:12 PM, D

Re: [DISCUSS] C++ Header only internal library code

2017-12-27 Thread Mark Hanson
Sounds good to me. +1 Thanks, Mark > On Dec 27, 2017, at 9:17 AM, Jacob Barrett wrote: > > As we move more and more to C++11 the use of templates and header only > implementations balloons. For many of these templates to be useful some > internal utilities must be provided to them but should not

Re: Geode Jira/GitHub Integration configuration changes

2017-12-27 Thread Dave Barnes
I must have just missed the cutoff - my PR (#1207), which I created at 2:48, generated diffs in the JIRA. On Wed, Dec 27, 2017 at 3:06 PM, Kirk Lund wrote: > INFRA has made the change. Does anyone have a PR ready to submit so I can > confirm the behavior on a Jira ticket? > > On Wed, Dec 27, 201

Re: Geode Jira/GitHub Integration configuration changes

2017-12-27 Thread Kirk Lund
INFRA has made the change. Does anyone have a PR ready to submit so I can confirm the behavior on a Jira ticket? On Wed, Dec 27, 2017 at 12:57 PM, Kirk Lund wrote: > I filed a request with INFRA to exclude pull request diffs from Jira > comments. > > https://issues.apache.org/jira/browse/INFRA-1

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #779 was SUCCESSFUL (with 2324 tests)

2017-12-27 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #779 was successful. --- Scheduled 2326 tests in total. https://build.spring.io/browse/SGF-NAG-779/ -- This

Re: Geode Jira/GitHub Integration configuration changes

2017-12-27 Thread Kirk Lund
I filed a request with INFRA to exclude pull request diffs from Jira comments. https://issues.apache.org/jira/browse/INFRA-15727 On Mon, Dec 18, 2017 at 12:33 PM, William Markito Oliveira < mark...@apache.org> wrote: > +1 for removing the diff - Link to the PR should be good enough. > > On Mon,

[DISCUSS] C++ Header only internal library code

2017-12-27 Thread Jacob Barrett
As we move more and more to C++11 the use of templates and header only implementations balloons. For many of these templates to be useful some internal utilities must be provided to them but should not be "exposed" as public API themselves. Many large scale projects have similar issues as more and