Re: Review Request 62163: GEODE-3096: pulling in refactoring work on HttpOperationInvoker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62163/ --- (Updated Sept. 9, 2017, 6:21 a.m.) Review request for geode, Jared Stewart, Ken

Re: Review Request 62163: GEODE-3096: pulling in refactoring work on HttpOperationInvoker

> On Sept. 7, 2017, 11:27 p.m., Jared Stewart wrote: > > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshExecution.java > > Lines 37 (patched) > > > > > > I don't think this method is used. I

Re: Review Request 62163: GEODE-3096: pulling in refactoring work on HttpOperationInvoker

> On Sept. 7, 2017, 6:03 p.m., Patrick Rhomberg wrote: > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportConfigCommand.java > > Line 132 (original), 119-124 (patched) > > > > > > Si

Re: Review Request 62163: GEODE-3096: pulling in refactoring work on HttpOperationInvoker

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62163/ --- (Updated Sept. 9, 2017, 6:20 a.m.) Review request for geode, Jared Stewart, Ken

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #672 was SUCCESSFUL (with 2027 tests)

--- Spring Data GemFire > Nightly-ApacheGeode > #672 was successful. --- Scheduled 2029 tests in total. https://build.spring.io/browse/SGF-NAG-672/ -- This

Re: Review Request 62189: GEODE-2817: consolidate authorize(*) methods

> On Sept. 8, 2017, 10:32 p.m., Ken Howe wrote: > > geode-core/src/main/java/org/apache/geode/cache/execute/Function.java > > Lines 120 (patched) > > > > > > You are expecting an internal object to be passed in a pub

Re: Review Request 62189: GEODE-2817: consolidate authorize(*) methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62189/#review185028 --- geode-core/src/main/java/org/apache/geode/cache/execute/Function.

Re: Review Request 62189: GEODE-2817: consolidate authorize(*) methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62189/#review185024 --- Ship it! Ship It! - Jared Stewart On Sept. 8, 2017, 4:28 p.m

Re: [DISCUSS] Addition of isValid API to Index interface

Indexes are critical for querying; most of the databases doesn't allow insert/update if there is any failure with index maintenance... As Geode OQL supports two ways (sync and async) to maintain the indexes, we need be careful about the error handling in both cases... My take is: 1. For synchrono

Passed: jinmeiliao/geode#17 (ruleCleanup - 64c9cdd)

Build Update for jinmeiliao/geode - Build: #17 Status: Passed Duration: 11 minutes and 36 seconds Commit: 64c9cdd (ruleCleanup) Author: Jinmei Liao Message: Test Rule Fix: clean up client DS when using LocatorServerStartupRule View the changeset: https://gith

Re: Review Request 62132: GEODE-3277: Fix error path constructors of Launcher inner State classess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62132/#review185020 --- Ship it! Ship It! - Jared Stewart On Sept. 8, 2017, 7:58 p.m

Re: [DISCUSS] Addition of isValid API to Index interface

Hi Mike, Please do find our answers below: *Question:* What if there were multiple indices that were in flight and only the third one errors out, will they all be marked invalid? *Answer:* Only the third will be marked invalid and only the third one will not be used for query execution. *Questio

Re: [DISCUSS] geode-native c++ exceptions

if we continue the merging of Jake <> Sarge comments we might find that std::exception(s) is sufficient if the many name exceptions that pertain to the Library are all handled in a similar manner and only have unique names for human readability, but not a functional consideration... EB On Fri, Se

Re: Now that we've moved to gitbox

It takes awhile to sync up. It was about 15 or 20 minutes after I completed the steps before I could could push. > On Sep 8, 2017, at 1:09 PM, Jinmei Liao wrote: > > I did everything of the above, and the gitbox.apache.org > shows I have write access to geode, but I

Re: Now that we've moved to gitbox

I did everything of the above, and the gitbox.apache.org shows I have write access to geode, but I still get the following when I do a push. What else I need to do? ~/projects/gemfire/open (develop) $ git push ERROR: Permission to apache/geode.git denied to jinmeiliao. fatal: Could not read from r

Re: Review Request 62132: GEODE-3277: Fix error path constructors of Launcher inner State classess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62132/#review185008 --- Ship it! Ship It! - Jinmei Liao On Sept. 8, 2017, 7:58 p.m.,

Re: Review Request 62132: GEODE-3277: Fix error path constructors of Launcher inner State classess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62132/ --- (Updated Sept. 8, 2017, 7:58 p.m.) Review request for geode, Emily Yeh, Jinmei

Re: Missing Gitbox activation email

Sorry, I take that back. I am able to update my info page. Thanks! On Fri, Sep 8, 2017 at 12:39 PM, Jinmei Liao wrote: > Sorry to be so late in the game. > > When I go to id.apache.org and login, my github username is > in my info page, but I am not able to update that box (it's grayed out). I

Re: Missing Gitbox activation email

Sorry to be so late in the game. When I go to id.apache.org and login, my github username is in my info page, but I am not able to update that box (it's grayed out). I did not receive any notification email either after the 2nd step. What's my next step? On Thu, Sep 7, 2017 at 1:04 PM, Nabarun N

GEODE-3249 fix has been pushed to release/1.2.1

I've cherry-picked the fix on release/1.2.1 commit 0b881b515eb1dcea974f0f5c1b40da03d42af9cf Author: Bruce Schuchardt Date:   Fri Sep 8 09:35:18 2017 -0700     GEODE-3249 Validate internal client/server messages

Re: [DISCUSS] Addition of isValid API to Index interface

Just to help me understand, the index is corrupted in a way beyond just the field that errors out? What if there were multiple indices that were in flight and only the third one errors out, will they all be marked invalid? If anything goes wrong with the put it should probably still throw back to t

Re: Review Request 62179: Test Rule Fix: clean up client DS when using LocatorServerStartupRule

> On Sept. 8, 2017, 4:37 p.m., Jared Stewart wrote: > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java > > Line 107 (original), 107 (patched) > > > > > > I like this use of

Re: Review Request 62179: Test Rule Fix: clean up client DS when using LocatorServerStartupRule

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62179/#review184990 --- Ship it! Ship It! - Jared Stewart On Sept. 8, 2017, 3:51 p.m

Re: Review Request 62179: Test Rule Fix: clean up client DS when using LocatorServerStartupRule

> On Sept. 8, 2017, 4:37 p.m., Jared Stewart wrote: > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java > > Lines 232 (patched) > > > > > > Do you think there is any chance

Re: Review Request 62088: GEODE-3249 Validate internal client/server messages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62088/#review184986 --- Ship it! Ship It! - Hitesh Khamesra On Sept. 7, 2017, 5:43 p

Re: [Discuss] Enable region set operations to start JTA transactions

How is this going to work for a PartitionedRegion? Answer: This will not be changed from current implementation -- transaction host will copy all primary data (on the node) to its TXState, and will iterate through remaining data (on other nodes) as non transactional data (not able to support repea

Re: Review Request 62179: Test Rule Fix: clean up client DS when using LocatorServerStartupRule

> On Sept. 8, 2017, 4:37 p.m., Jared Stewart wrote: > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java > > Lines 232 (patched) > > > > > > Do you think there is any chance

Re: Review Request 62179: Test Rule Fix: clean up client DS when using LocatorServerStartupRule

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62179/#review184984 --- geode-core/src/test/java/org/apache/geode/test/dunit/rules/Locato

Re: [DISCUSS] Addition of isValid API to Index interface

+1 -Dan On Thu, Sep 7, 2017 at 9:14 PM, Nabarun Nag wrote: > *Proposal:* > * Index interface will include an API - isValid() which will return true if > the index is still valid / uncorrupted, else will return false if it > corrupted / invalid. > * gfsh command "list index" will have one more c

Review Request 62189: GEODE-2817: consolidate authorize(*) methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62189/ --- Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhombe

Re: Review Request 62164: GEODE-3566 Moving a bucket during rebalancing does not update overflow stats

> On Sept. 7, 2017, 8:08 p.m., Nick Reich wrote: > > geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/BucketRebalanceStatRegressionTest.java > > Lines 17 (patched) > > > > > > I think this is the w

Re: Review Request 62164: GEODE-3566 Moving a bucket during rebalancing does not update overflow stats

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62164/#review184982 --- Ship it! Ship It! - Nick Reich On Sept. 8, 2017, 4:10 p.m.,

Re: Review Request 62164: GEODE-3566 Moving a bucket during rebalancing does not update overflow stats

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62164/ --- (Updated Sept. 8, 2017, 4:10 p.m.) Review request for geode, anilkumar gingade,

Re: Review Request 62164: GEODE-3566 Moving a bucket during rebalancing does not update overflow stats

> On Sept. 7, 2017, 8:08 p.m., Nick Reich wrote: > > geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/BucketRebalanceStatRegressionTest.java > > Lines 17 (patched) > > > > > > I think this is the w

Re: Review Request 62179: Test Rule Fix: clean up client DS when using LocatorServerStartupRule

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62179/ --- (Updated Sept. 8, 2017, 3:51 p.m.) Review request for geode, Jared Stewart, Ken

Re: [DISCUSS] geode-native c++ exceptions

I subscribe to Josh Gray's philosophy of only having another exception class if there is something different to be done when it's caught. For example, if the caller would do the exact same thing for NoPermissionsException and DiskFullException, just use an IOException and be done with it. I also

Re: Geode sessions at SpringOne Platform conference

Hi Jagdish, Thanks for sharing this information! I think this looks like a great event. If you have a banner, text, or other assets to share that would make it easier to update the website. Could you also kindly review the ASF branding and trademark guidelines [1] [2] [3] to ensure proper us

Re: [DISCUSS] geode-native c++ exceptions

Sorry for jumping on this thread so late. This is an important issue we need to address. On Thu, Aug 17, 2017 at 11:57 AM David Kimura wrote: > Using exceptions seems contrary to the Google C++ Style Guide we adopted, > which states: *"do not use C++ exceptions"* [3 >

Build failed in Jenkins: Geode-nightly-flaky #116

See -- Started by upstream project "Geode-nightly" build number 948 originally caused by: Started by timer [EnvInject] - Loading node environment variables. Building remotely on H14 (c

Build failed in Jenkins: Geode-nightly #948

See Changes: [upthewaterspout] Revert "GEODE-3568: User can set a LuceneSerializer through the Java [gosullivan] GEODE-3555: proper new client protocol closure with more than max conns. [dbarnes] GEODE-3575 User