> On Sept. 7, 2017, 8:08 p.m., Nick Reich wrote: > > geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/BucketRebalanceStatRegressionTest.java > > Lines 17 (patched) > > <https://reviews.apache.org/r/62164/diff/1/?file=1817801#file1817801line17> > > > > I think this is the wrong library, or are you using assertj on purpose > > instead of junit?
The use of assertj was intentional and recommended to me by Kirk. > On Sept. 7, 2017, 8:08 p.m., Nick Reich wrote: > > geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/BucketRebalanceStatRegressionTest.java > > Lines 128 (patched) > > <https://reviews.apache.org/r/62164/diff/1/?file=1817801#file1817801line128> > > > > This could be cleaned up by getting the region once at the top of the > > method and using that variable throughout. The region does not exist in the process that is executing validateInitialRegion so I can't get it at the top of the method. The lambdas are being executed in different members, so each one needs to get the region instance specific to that member. - Lynn ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62164/#review184872 ----------------------------------------------------------- On Sept. 8, 2017, 4:10 p.m., Lynn Gallinat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62164/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2017, 4:10 p.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, Eric Shu, and > Nick Reich. > > > Repository: geode > > > Description > ------- > > We now update the stats in a member that lost a bucket due to rebalancing > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegion.java > 465a3dd > > geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/BucketRebalanceStatRegressionTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/62164/diff/2/ > > > Testing > ------- > > Precheckin > > > Thanks, > > Lynn Gallinat > >
