Re: [DISCUSS] easy string based partitioning

2017-06-02 Thread Jacob Barrett
The "simplest implementation" overlooks the rational for implementing it. The rational was to avoid customers having to implement classes to do partitioning. How is that any different than forcing them to conform their string keys to a very specific format we can parse in this solution. If there ke

Re: [DISCUSS] easy string based partitioning

2017-06-02 Thread Michael Stolz
We are looking for the simplest implementation. Not the best. Fixed delimeter, string only, SIMPLE. We as a team have a habit of always solving the bigger problem. Lets allow this one to be simple. -- Mike Stolz Principal Engineer - Gemfire Product Manager Mobile: 631-835-4771 On Jun 2, 2017 1

Re: [DISCUSS] easy string based partitioning

2017-06-02 Thread Jacob Barrett
If you implement as regular expression the user doesn't have to reformat their key to a specific format (akin to making them implement a class). I would concat the matching groups for generate the routing key. Consider RegEx: .*\bcorrelation=(\d+).*\bmaybe-something-else=(\w) With Keys: A: my,key;

[jira] [Created] (GEODE-3027) A developer can co-locate two keys on a put

2017-06-02 Thread Fred Krone (JIRA)
Fred Krone created GEODE-3027: - Summary: A developer can co-locate two keys on a put Key: GEODE-3027 URL: https://issues.apache.org/jira/browse/GEODE-3027 Project: Geode Issue Type: Improvement

Re: [DISCUSS] easy string based partitioning

2017-06-02 Thread John Blum
Hi Darrel- +1 I am largely still thinking on this one (also from a *Spring* perspective), but I like your initial concept/idea. Will provide more feedback in time. Cheers, John On Fri, Jun 2, 2017 at 4:40 PM, Michael Stolz wrote: > +1 This is the easiest way to make colocation easy > > -- >

Re: [DISCUSS] easy string based partitioning

2017-06-02 Thread Michael Stolz
+1 This is the easiest way to make colocation easy -- Mike Stolz Principal Engineer - Gemfire Product Manager Mobile: 631-835-4771 On Jun 2, 2017 6:55 PM, "Darrel Schneider" wrote: > Geode partitioned regions usually partition the data based on the key's > hashcode. > You can do your own partit

[DISCUSS] easy string based partitioning

2017-06-02 Thread Darrel Schneider
Geode partitioned regions usually partition the data based on the key's hashcode. You can do your own partitioning by implementing the PartitionResolver interface and configuring it on the partitioned region. In some use cases needing to deploy your class that implements PartitionResolver can be p

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #573 was SUCCESSFUL (with 1868 tests)

2017-06-02 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #573 was successful. --- Scheduled 1870 tests in total. https://build.spring.io/browse/SGF-NAG-573/ -- This

Re: Review Request 59692: GEODE-2925: add target for resource operation for finer grained security

2017-06-02 Thread Patrick Rhomberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59692/#review176859 --- geode-core/src/main/java/org/apache/geode/internal/security/Secur

[jira] [Resolved] (GEODE-2947) Improve error message (seen in gfsh) when attempting to destroy a region before destroying lucene indexes

2017-06-02 Thread Karen Smoler Miller (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karen Smoler Miller resolved GEODE-2947. Resolution: Fixed Documentation update cherry picked to the release/1.2.0 branch wit

[jira] [Commented] (GEODE-2947) Improve error message (seen in gfsh) when attempting to destroy a region before destroying lucene indexes

2017-06-02 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035527#comment-16035527 ] ASF subversion and git services commented on GEODE-2947: Commit 96

[jira] [Commented] (GEODE-2947) Improve error message (seen in gfsh) when attempting to destroy a region before destroying lucene indexes

2017-06-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035526#comment-16035526 ] ASF GitHub Bot commented on GEODE-2947: --- Github user asfgit closed the pull request

[GitHub] geode pull request #555: GEODE-2947: Document revised gfsh destroy error mes...

2017-06-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/555 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (GEODE-2947) Improve error message (seen in gfsh) when attempting to destroy a region before destroying lucene indexes

2017-06-02 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035524#comment-16035524 ] ASF subversion and git services commented on GEODE-2947: Commit 74

[jira] [Commented] (GEODE-2661) CacheListener gets invoked when an non-existent entry is removed using removeAll

2017-06-02 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035504#comment-16035504 ] ASF subversion and git services commented on GEODE-2661: Commit 39

[jira] [Assigned] (GEODE-2931) Document existing REST API functionality for primitives as PUT values

2017-06-02 Thread Karen Smoler Miller (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karen Smoler Miller reassigned GEODE-2931: -- Assignee: (was: Karen Smoler Miller) > Document existing REST API functiona

Re: Review Request 59692: GEODE-2925: add target for resource operation for finer grained security

2017-06-02 Thread Jinmei Liao
> On June 1, 2017, 9:47 p.m., Patrick Rhomberg wrote: > > geode-core/src/main/java/org/apache/geode/management/internal/security/ResourceOperation.java > > Line 29 (original), 30 (patched) > > > > > > Is it possible t

Re: Review Request 59692: GEODE-2925: add target for resource operation for finer grained security

2017-06-02 Thread Patrick Rhomberg
> On June 1, 2017, 9:47 p.m., Patrick Rhomberg wrote: > > geode-core/src/main/java/org/apache/geode/management/internal/security/ResourceOperation.java > > Line 29 (original), 30 (patched) > > > > > > Is it possible t

Re: [jira] [Updated] (GEODE-3005) A developer can create a Region with Partition by Prefix using Java API

2017-06-02 Thread Swapnil Bawaskar
I don't see how this RoutableKey approach, which is a Java interface will work from non-java clients. So, in the interest of cross-language support and keeping the usage simple, I think we should just restrict this to work with utf-8 encoded strings with a delimiter. I agree however that this shou

[jira] [Created] (GEODE-3026) If a region defining lucene indexes cannot be created, it leaves an AEQ behind

2017-06-02 Thread Barry Oglesby (JIRA)
Barry Oglesby created GEODE-3026: Summary: If a region defining lucene indexes cannot be created, it leaves an AEQ behind Key: GEODE-3026 URL: https://issues.apache.org/jira/browse/GEODE-3026 Project:

Review Request 59757: GEODE-3024 race condition between server and restarted locator preparing membership views

2017-06-02 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59757/ --- Review request for geode, Hitesh Khamesra and Udo Kohlmeyer. Bugs: GEODE-3024

[jira] [Created] (GEODE-3025) CI failure: org.apache.geode.cache.lucene.LuceneQueriesClientDUnitTest.transactionWithLuceneQueriesShouldThrowException

2017-06-02 Thread Jason Huynh (JIRA)
Jason Huynh created GEODE-3025: -- Summary: CI failure: org.apache.geode.cache.lucene.LuceneQueriesClientDUnitTest.transactionWithLuceneQueriesShouldThrowException Key: GEODE-3025 URL: https://issues.apache.org/jira/br

[jira] [Commented] (GEODE-2947) Improve error message (seen in gfsh) when attempting to destroy a region before destroying lucene indexes

2017-06-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035182#comment-16035182 ] ASF GitHub Bot commented on GEODE-2947: --- Github user dihardman commented on the issu

[GitHub] geode issue #555: GEODE-2947: Document revised gfsh destroy error message

2017-06-02 Thread dihardman
Github user dihardman commented on the issue: https://github.com/apache/geode/pull/555 +1 Looks good. Thanks! On Fri, Jun 2, 2017 at 9:26 AM, Karen Miller wrote: > @dihardman @boglesby > @ladyVader <

Build failed in Jenkins: Geode-release #52

2017-06-02 Thread Apache Jenkins Server
See Changes: [abaker] GEODE-2947: Error message is now specific to lucene indexes [jiliao] GEODE-3006: reduce the frequency of ping request and reduce the loglevel [jiliao] GEODE-2983: correctly handling --J option

Re: Review Request 59754: GEODE-2928: get rid of the isGfshVM static variable

2017-06-02 Thread Jinmei Liao
> On June 2, 2017, 5:53 p.m., Jared Stewart wrote: > > geode-core/src/test/java/org/apache/TestSuite.java > > Lines 24 (patched) > > > > > > I suspect that you may not have intended to include this file in your > > c

Re: [jira] [Updated] (GEODE-3005) A developer can create a Region with Partition by Prefix using Java API

2017-06-02 Thread Michael Stolz
+1 to the RoutableKey. Does need to be supported on any non-java clients too though. -- Mike Stolz Principal Engineer, GemFire Product Manager Mobile: +1-631-835-4771 On Thu, Jun 1, 2017 at 8:31 PM, Darrel Schneider wrote: > +1 to the RoutableKey idea. > It also gets rid of any need for a delim

Re: Review Request 59754: GEODE-2928: get rid of the isGfshVM static variable

2017-06-02 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59754/#review176809 --- geode-core/src/test/java/org/apache/TestSuite.java Lines 24 (patc

Jenkins build is back to normal : Geode-nightly-flaky #24

2017-06-02 Thread Apache Jenkins Server
See

Re: Review Request 59736: GEODE-2933: jmx-manager-hostname-for-clients should be a gfsh option

2017-06-02 Thread Patrick Rhomberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59736/#review176794 --- 1) `¯_(?)_/¯` 2) I think the setting of defaults would belong to t

[jira] [Commented] (GEODE-2444) Making Redis Adapter easier to use and more robust

2017-06-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035033#comment-16035033 ] ASF GitHub Bot commented on GEODE-2444: --- Github user kohlmu-pivotal commented on the

[GitHub] geode issue #404: Geode 2469

2017-06-02 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on the issue: https://github.com/apache/geode/pull/404 @yhilem @ggreen @bbaynes, there is currently a feature branch https://github.com/apache/geode/tree/feature/GEODE-2444, which started splitting the Redis Adapter into its own module. I would

[jira] [Commented] (GEODE-2981) Fix the line feed code of the test expected value

2017-06-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035030#comment-16035030 ] ASF GitHub Bot commented on GEODE-2981: --- Github user jaredjstewart commented on the

[GitHub] geode issue #530: GEODE-2981: Fix the line feed code of the test expected va...

2017-06-02 Thread jaredjstewart
Github user jaredjstewart commented on the issue: https://github.com/apache/geode/pull/530 Thank you for your contribution, looks good to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[jira] [Commented] (GEODE-2981) Fix the line feed code of the test expected value

2017-06-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035027#comment-16035027 ] ASF GitHub Bot commented on GEODE-2981: --- Github user jinmeiliao commented on the iss

[GitHub] geode issue #530: GEODE-2981: Fix the line feed code of the test expected va...

2017-06-02 Thread jinmeiliao
Github user jinmeiliao commented on the issue: https://github.com/apache/geode/pull/530 will pull this in after testing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

Review Request 59754: GEODE-2928: get rid of the isGfshVM static variable

2017-06-02 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59754/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Pat

[jira] [Commented] (GEODE-2935) Add Events link to Geode site footer

2017-06-02 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035026#comment-16035026 ] ASF subversion and git services commented on GEODE-2935: Commit c7

[jira] [Commented] (GEODE-2947) Improve error message (seen in gfsh) when attempting to destroy a region before destroying lucene indexes

2017-06-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034996#comment-16034996 ] ASF GitHub Bot commented on GEODE-2947: --- GitHub user karensmolermiller opened a pull

[GitHub] geode pull request #555: GEODE-2947: Document revised gfsh destroy error mes...

2017-06-02 Thread karensmolermiller
GitHub user karensmolermiller opened a pull request: https://github.com/apache/geode/pull/555 GEODE-2947: Document revised gfsh destroy error message @dihardman @boglesby @ladyVader Please review. You can merge this pull request into a Git repository by running: $ git pull htt

[GitHub] geode issue #404: Geode 2469

2017-06-02 Thread bbaynes
Github user bbaynes commented on the issue: https://github.com/apache/geode/pull/404 @yhilem @ggreen Looks like a great use case. The PR may need a little cleanup (based on Galen's comments), but it would be good to get this in. --- If your project is set up for it, you can repl

Re: Review Request 59692: GEODE-2925: add target for resource operation for finer grained security

2017-06-02 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59692/ --- (Updated June 2, 2017, 4:08 p.m.) Review request for geode, Emily Yeh, Jared St

Re: Review Request 59686: GEODE-2983: correctly handling --J option value that has ", " inside.

2017-06-02 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59686/#review176783 --- Ship it! Ship It! - Emily Yeh On May 31, 2017, 10:44 p.m., J

[GitHub] geode-site pull request #3: GEODE-2935: Add Events link to footer, events im...

2017-06-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode-site/pull/3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[jira] [Commented] (GEODE-2935) Add Events link to Geode site footer

2017-06-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034953#comment-16034953 ] ASF GitHub Bot commented on GEODE-2935: --- Github user asfgit closed the pull request

[jira] [Created] (GEODE-3024) race condition between server and restarted locator preparing membership views

2017-06-02 Thread Bruce Schuchardt (JIRA)
Bruce Schuchardt created GEODE-3024: --- Summary: race condition between server and restarted locator preparing membership views Key: GEODE-3024 URL: https://issues.apache.org/jira/browse/GEODE-3024 Pr

Build failed in Jenkins: Geode-nightly #854

2017-06-02 Thread Apache Jenkins Server
See Changes: [jiliao] GEODE-3006: reduce the frequency of ping request and reduce the loglevel [jiliao] GEODE-2983: correctly handling --J option value that has "," inside. [jstewart] GEODE-2989: Improve mechanism

Re: Review Request 59692: GEODE-2925: add target for resource operation for finer grained security

2017-06-02 Thread Jinmei Liao
> On June 1, 2017, 9:47 p.m., Patrick Rhomberg wrote: > > geode-core/src/main/java/org/apache/geode/management/internal/security/ResourceOperation.java > > Line 29 (original), 30 (patched) > > > > > > Is it possible t

Re: Review Request 59692: GEODE-2925: add target for resource operation for finer grained security

2017-06-02 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59692/ --- (Updated June 2, 2017, 2:31 p.m.) Review request for geode, Emily Yeh, Jared St

[jira] [Created] (GEODE-3023) TcpServer thread can be blocked in processRequest

2017-06-02 Thread Vahram Aharonyan (JIRA)
Vahram Aharonyan created GEODE-3023: --- Summary: TcpServer thread can be blocked in processRequest Key: GEODE-3023 URL: https://issues.apache.org/jira/browse/GEODE-3023 Project: Geode Issue T

[jira] [Created] (GEODE-3022) [JGRP00001] configuration error: the following properties in org.apache.geode.distributed.internal.membership.gms.messenger.Transport are not recognized: {ignore_dont_bun

2017-06-02 Thread Sumitra Chatterjee (JIRA)
Sumitra Chatterjee created GEODE-3022: - Summary: [JGRP1] configuration error: the following properties in org.apache.geode.distributed.internal.membership.gms.messenger.Transport are not recognized: {ignore_dont_bundle=false}