[GitHub] incubator-geode issue #291: [GEODE-1122] Fixed Dependency on environment var...

2016-11-22 Thread davinash
Github user davinash commented on the issue: https://github.com/apache/incubator-geode/pull/291 Is this PR now good for merge to develop now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

Re: Review Request 54003: GEODE-2137 client membership IDs contain 17 bytes of useless information that should be removed

2016-11-22 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54003/#review156667 --- Ship it! Ship It! - Hitesh Khamesra On Nov. 22, 2016, 11:21

Re: Review Request 54003: GEODE-2137 client membership IDs contain 17 bytes of useless information that should be removed

2016-11-22 Thread Bruce Schuchardt
> On Nov. 22, 2016, 11:33 p.m., Hitesh Khamesra wrote: > > Does that cover the case when event(or put) happened through peer(or server) It does cover peer-to-peer. One thing that I need to do though is bump the current Version and make sure this works with Geode 1.0.0. - Bruce

Re: Review Request 54000: GEODE-2135 Update schema location in the docs

2016-11-22 Thread Dave Barnes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54000/#review156663 --- Ship it! Ship It! - Dave Barnes On Nov. 22, 2016, 9:56 p.m.,

Re: Review Request 54003: GEODE-2137 client membership IDs contain 17 bytes of useless information that should be removed

2016-11-22 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54003/#review156662 --- Does that cover the case when event(or put) happened through peer(

Review Request 54003: GEODE-2137 client membership IDs contain 17 bytes of useless information that should be removed

2016-11-22 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54003/ --- Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.

Re: Review Request 54000: GEODE-2135 Update schema location in the docs

2016-11-22 Thread Anthony Baker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54000/#review156648 --- Ship it! Ship It! - Anthony Baker On Nov. 22, 2016, 9:56 p.m

Review Request 54000: GEODE-2135 Update schema location in the docs

2016-11-22 Thread Karen Miller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54000/ --- Review request for geode, Anthony Baker and Dave Barnes. Repository: geode De

Re: Strange Performance Issue with Large number Region Creation

2016-11-22 Thread Udo Kohlmeyer
+1 Maybe we can create a JIRA for this. On 11/22/16 11:56, Dan Smith wrote: Seems like fixing that StatisicsMonitor to use a ConcurrentHashSet is a good fix, there's no reason why it should be a list that I can see. As other folks mentioned, there is significant overhead involved in creating

Re: Strange Performance Issue with Large number Region Creation

2016-11-22 Thread Dan Smith
Seems like fixing that StatisicsMonitor to use a ConcurrentHashSet is a good fix, there's no reason why it should be a list that I can see. As other folks mentioned, there is significant overhead involved in creating that many regions in terms of memory, messaging, and disk metadata. Especially co

[GitHub] incubator-geode issue #294: Properly close WebDriver for UITests

2016-11-22 Thread jaredjstewart
Github user jaredjstewart commented on the issue: https://github.com/apache/incubator-geode/pull/294 Precheckin started --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] incubator-geode pull request #294: Properly close WebDriver for UITests

2016-11-22 Thread jaredjstewart
GitHub user jaredjstewart opened a pull request: https://github.com/apache/incubator-geode/pull/294 Properly close WebDriver for UITests - WebDriver gets closed properly so that the UITests don't overwhelm CI machines with extra processes - Increase WebDriver element wait ti

Re: Review Request 53996: GEODE-2136: Don't duplicate cookies in the http response

2016-11-22 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53996/#review156609 --- Ship it! Ship It! - Jason Huynh On Nov. 22, 2016, 7:04 p.m.,

Re: Strange Performance Issue with Large number Region Creation

2016-11-22 Thread Udo Kohlmeyer
@Avinesh, I's be interested in understanding why you need to create 1500 regions. Maybe if you could explain the usecase where 1500 regions are required we could potentially help with another solution. This reminds me of the Oracle Table limitation of 999 columns Where the Oracle support

Review Request 53996: GEODE-2136: Don't duplicate cookies in the http response

2016-11-22 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53996/ --- Review request for geode and Jason Huynh. Repository: geode Description -

Re: Review Request 53971: GEODE-2125 Add doc note to not use kill cmd on servers

2016-11-22 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53971/#review156598 --- Ship it! Ship It! - Bruce Schuchardt On Nov. 22, 2016, 6:02

Re: Review Request 53971: GEODE-2125 Add doc note to not use kill cmd on servers

2016-11-22 Thread Karen Miller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53971/ --- (Updated Nov. 22, 2016, 6:02 p.m.) Review request for geode, Bruce Schuchardt,

[GitHub] incubator-geode pull request #293: GEODE-1653: Executing a fire-and-forget f...

2016-11-22 Thread jhuynh1
Github user jhuynh1 commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/293#discussion_r89148312 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/BugGeode_1653DUnitTest.java --- @@ -0,0 +1,145 @@ +/* + * Licensed to the

Re: Review Request 53971: GEODE-2125 Add doc note to not use kill cmd on servers

2016-11-22 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53971/#review156591 --- geode-docs/configuring/running/starting_up_shutting_down.html.md.

Re: Review Request 53867: GEODE-2129 make pdxtype id random(not sequential)

2016-11-22 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53867/#review156585 --- Ship it! Ship It! - Bruce Schuchardt On Nov. 22, 2016, 12:49

Jenkins build is back to normal : Geode-nightly #661

2016-11-22 Thread Apache Jenkins Server
See

[GitHub] incubator-geode pull request #293: GEODE-1653: Executing a fire-and-forget f...

2016-11-22 Thread metatype
Github user metatype commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/293#discussion_r89129716 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRClientServerRegionFunctionExecutionDUnitTest.java --- @@ -143,7 +143,7

[GitHub] incubator-geode pull request #293: GEODE-1653: Executing a fire-and-forget f...

2016-11-22 Thread metatype
Github user metatype commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/293#discussion_r89132685 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/BugGeode_1653DUnitTest.java --- @@ -0,0 +1,145 @@ +/* + * Licensed to th

Re: The next release (v1.1.0)

2016-11-22 Thread Anthony Baker
Transitioning from an incubating project to a top-level project means we keep doing exactly what we’ve been doing—except that now the project is responsible for managing itself. We will be transitioning a few resources such as mailing lists and git repos to reflect that we are no longer an incu

[GitHub] incubator-geode pull request #293: GEODE-1653: Executing a fire-and-forget f...

2016-11-22 Thread ameybarve15
GitHub user ameybarve15 opened a pull request: https://github.com/apache/incubator-geode/pull/293 GEODE-1653: Executing a fire-and-forget function on all servers doesn't actually execute on all servers You can merge this pull request into a Git repository by running: $ git pu