Github user metatype commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/293#discussion_r89132685
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/BugGeode_1653DUnitTest.java
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for
additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
ANY KIND, either express
+ * or implied. See the License for the specific language governing
permissions and limitations under
+ * the License.
+ */
+
+package org.apache.geode.internal.cache;
+
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.client.*;
+import org.apache.geode.cache.client.internal.LocatorTestBase;
+import org.apache.geode.cache.execute.Execution;
+import org.apache.geode.cache.execute.Function;
+import org.apache.geode.cache.execute.FunctionService;
+import org.apache.geode.internal.AvailablePort;
+import org.apache.geode.internal.cache.functions.TestFunction;
+import org.apache.geode.test.dunit.Assert;
+import org.apache.geode.test.dunit.Host;
+import org.apache.geode.test.dunit.NetworkUtils;
+import org.apache.geode.test.dunit.VM;
+import org.apache.geode.test.junit.categories.DistributedTest;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+/**
+ * Created by amey on 22/11/16.
+ */
+@Category(DistributedTest.class)
+public class BugGeode_1653DUnitTest extends LocatorTestBase {
+
+ public BugGeode_1653DUnitTest() {
+ super();
+ }
+
+ @Override
+ public final void postSetUp() throws Exception {
+ disconnectAllFromDS();
+ }
+
+ @Override
+ protected final void postTearDownLocatorTestBase() throws Exception {
+ disconnectAllFromDS();
+ }
+
+ @Test
+ public void testBugGeode_1653() {
+
+ // Test case for Executing a fire-and-forget function on all servers
as opposed to only
+ // executing on the ones the
+ // client is currently connected to.
+
+ Host host = Host.getHost(0);
+ VM locator = host.getVM(0);
+ VM server1 = host.getVM(1);
+ VM server2 = host.getVM(2);
+ VM client = host.getVM(3);
+
+ final int locatorPort =
AvailablePort.getRandomAvailablePort(AvailablePort.SOCKET);
+ final String locatorHost = NetworkUtils.getServerHostName(host);
+
+ // Step 1. Start a locator and one cache server.
+ locator.invoke("Start Locator", () -> startLocator(locatorHost,
locatorPort, ""));
+
+ String locString = getLocatorString(host, locatorPort);
+
+ // Step 2. Start a server and create a replicated region "R1".
+ server1.invoke("Start BridgeServer",
+ () -> startBridgeServer(new String[] {"R1"}, locString, new
String[] {"R1"}));
+
+ // Step 3. Create a client cache with pool mentioning locator.
+ client.invoke("create client cache and pool mentioning locator", () ->
{
+ ClientCacheFactory ccf = new ClientCacheFactory();
+ ccf.addPoolLocator(locatorHost, locatorPort);
+ ClientCache cache = ccf.create();
+ Pool pool1 = PoolManager.createFactory().addLocator(locatorHost,
locatorPort)
+ .setServerGroup("R1").create("R1");
+
+ Region region1 =
cache.createClientRegionFactory(ClientRegionShortcut.PROXY).setPoolName("R1")
+ .create("R1");
+
+ // Step 4. Execute the function to put DistributedMemberID into
above created replicated
+ // region.
+ Function function = new TestFunction(false,
TestFunction.TEST_FUNCTION_1653);
+ FunctionService.registerFunction(function);
+
+ String regionName = "R1";
+ Execution dataSet = FunctionService.onServers(pool1);
+ dataSet.withArgs(regionName).execute(function);
+ Thread.sleep(1000);
--- End diff --
Using explicit thread sleep calls in tests is not recommended as this will
cause the test to sporadically fail. Here's an example of changing a sleep to
a condition:
https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=commitdiff;h=7d5f39a;hp=6c7a0d2a2d3c0c56828c9c0498390b505de00ea4
@kirklund may have some ideas for test patterns you could use.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
