Re: [PATCH 3/3] ethdev: import and export data variables for MSVC

2024-10-07 Thread Stephen Hemminger
On Tue, 12 Mar 2024 00:51:48 -0700 Tyler Retzlaff wrote: > diff --git a/lib/ethdev/rte_ethdev_export.h b/lib/ethdev/rte_ethdev_export.h > new file mode 100644 > index 000..7887bee > --- /dev/null > +++ b/lib/ethdev/rte_ethdev_export.h > @@ -0,0 +1,23 @@ > +/* SPDX-License-Identifier: BSD-3-Cl

RE: [PATCH] eal/x86: cache queried CPU flags

2024-10-07 Thread Wathsala Wathawana Vithanage
> > Hi Bruce, > > Why x86/rte_cpuflags.c is not using rte_getauxval() ? > > I don't see any such DPDK function, unless I'm missing something? I do see a > linux function which includes hw capability flags. I suspect the reasons we > don't use that are: > > 1. Lack of awareness of it (at least on

Re: [PATCH 00/16] remove use of VLAs for Windows built code

2024-10-07 Thread Stephen Hemminger
On Wed, 17 Apr 2024 16:41:43 -0700 Tyler Retzlaff wrote: > As per guidance technical board meeting 2024/04/17. This series > removes the use of VLAs from code built for Windows for all 3 > toolchains. If there are additional opportunities to convert VLAs > to regular C arrays please provide the d

Re: [PATCH v5] devtools: add .clang-format file

2024-10-07 Thread Stephen Hemminger
On Thu, 16 May 2024 08:20:51 + Abdullah Ömer Yamaç wrote: > clang-format is a tool to format C/C++/Objective-C code. It can be used > to reformat code to match a given coding style, or to ensure that code > adheres to a specific coding style. It helps to maintain a consistent > coding style a

[PATCH v9] eal: add build-time option to omit trace

2024-10-07 Thread Morten Brørup
Some applications want to omit the trace feature. Either to reduce the memory footprint, to reduce the exposed attack surface, or for other reasons. This patch adds an option in rte_config.h to include or omit trace in the build. Trace is included by default. Omitting trace works by omitting all

RE: [PATCH] eal/x86: cache queried CPU flags

2024-10-07 Thread Wathsala Wathawana Vithanage
> On Mon, Oct 7, 2024 at 1:07 PM Bruce Richardson > wrote: > > > > Rather than re-querying the HW each time a CPU flag is requested, we > > can just save the return value in the flags array. This should speed > > up repeated querying of CPU flags, and provides a workaround for a > > reported issue

Re: [PATCH] bus/pci: don't open uio device in secondary process

2024-10-07 Thread Stephen Hemminger
On Wed, 28 Aug 2024 12:40:02 +0200 Konrad Sztyber wrote: > The uio_pci_generic driver clears the bus master bit when the device > file is closed. So, when the secondary process terminates after probing > a device, that device becomes unusable in the primary process. > > To avoid that, the devic

Re: [PATCH v2 1/2] net/sxe: add net driver sxe

2024-10-07 Thread Stephen Hemminger
On Fri, 6 Sep 2024 10:09:30 +0800 Jie Liu wrote: > diff --git a/drivers/net/sxe/Makefile b/drivers/net/sxe/Makefile > new file mode 100644 > index 00..5e2870fdc4 > --- /dev/null > +++ b/drivers/net/sxe/Makefile DPDK does not use make anymore, please remove this from next version.

[PATCH v2 2/3] ethdev: make parameters to TM profile add fn constant

2024-10-07 Thread Bruce Richardson
The function to add a new profile in rte_tm should not (and does not) modify the profile parameters passed in via struct pointer. We should guarantee this by marking the parameter pointer as const. This allows SW to create multiple profiles using the same parameter struct without having to reset i

[PATCH v2 1/3] ethdev: make parameters to TM node add fn constant

2024-10-07 Thread Bruce Richardson
The function to add a new scheduling node in rte_tm should not (and does not) modify the actual node parameters passed in via struct pointer. We should guarantee this by marking the parameter pointer as const. This allows SW to create multiple scheduling nodes using the same parameter struct withou

[PATCH v2 3/3] ethdev: make TM shaper parameters constant

2024-10-07 Thread Bruce Richardson
The function to add a new shaper profile in rte_tm should not (and does not) modify the profile parameters passed in via struct pointer. We should guarantee this by marking the parameter pointer as const. This allows SW to create multiple profiles using the same parameter struct without having to r

[PATCH v2 0/3] make struct parameters constant in rte_tm APIs

2024-10-07 Thread Bruce Richardson
For functions for creating profiles, shapers and hierarchy nodes, make the parameter structure pointer a pointer to a const object. This guarantees to the user that the struct won't be modified by the function, which allows the user to re-use the same parameters multiple times without having to con

Re: [PATCH v2] common/mlx5: Optimize mlx5 mempool get extmem

2024-10-07 Thread John Romein
Dear Stephen, The problem has not been solved, but I found a workaround. According to the documentation (https://doc.dpdk.org/guides/prog_guide/gpudev.html, sec 11.3), rte_extmem_register should be invoked with GPU_PAGE_SIZE as an argument.  If GPU_PAGE_SIZE is set to 2 MB instead of 64 kB, r

Re: [PATCH] eal/x86: cache queried CPU flags

2024-10-07 Thread David Marchand
On Mon, Oct 7, 2024 at 1:07 PM Bruce Richardson wrote: > > Rather than re-querying the HW each time a CPU flag is requested, we can > just save the return value in the flags array. This should speed up > repeated querying of CPU flags, and provides a workaround for a reported > issue where errors

[PATCH] eal/x86: cache queried CPU flags

2024-10-07 Thread Bruce Richardson
Rather than re-querying the HW each time a CPU flag is requested, we can just save the return value in the flags array. This should speed up repeated querying of CPU flags, and provides a workaround for a reported issue where errors are seen with constant querying of the AVX-512 CPU flag from a non

Re: [PATCH v18 1/3] eventdev: add support for independent enqueue

2024-10-07 Thread Jerin Jacob
On Mon, Oct 7, 2024 at 1:43 PM Abdullah Sevincer wrote: > > Support for independent enqueue feature and updates Event Device > and PMD feature list. > > A new capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ is introduced. It > allows out-of-order enqueuing of RTE_EVENT_OP_FORWARD or RELEASE type > ev

[dpdk-dev] [PATCH v2] drivers: fix build issues with redundant newline changes

2024-10-07 Thread jerinj
From: Jerin Jacob Certain section of the code in net/mvpp2 and ml/cnxk is enabled only when all depended library dependences where meet. Fixing those build errors. Fixes: f665790a5dba ("drivers: remove redundant newline from logs") Signed-off-by: Jerin Jacob --- v2: - Add https://patches.dpdk

Re: [PATCH] test: fix option block

2024-10-07 Thread Stephen Hemminger
On Thu, 14 Mar 2024 09:46:26 + Mingjin Ye wrote: > The options allow (-a) and block (-b) cannot be used at the same time. > Therefore, allow (-a) will not be added when block (-b) is present. > > Fixes: b3ce7891ad38 ("test: fix probing in secondary process") > Cc: sta...@dpdk.org > > Signed

[PATCH v2 28/50] net/ntnic: add categorizer (CAT) FPGA module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Categorizer module’s main purpose is to is select the behavior of other modules in the FPGA pipeline depending on a protocol check. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 205 drivers/net/ntnic/meson.build

[PATCH v2 39/50] net/ntnic: add scatter-gather HW deallocation

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Deallocates memory for hardware Virtio queues and unmaps VFIO resources. Updated eth_tx_queue_release and eth_rx_queue_release. Released hardware Virtio queues for TX and RX. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/ntos_drv.h | 1 + drivers/net/

[PATCH v2 43/50] net/ntnic: add split-queue support

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Split-queue support was added. Internal structures were enhanced with additional managmnet fields. Implement a managed virtual queue function based on the queue type and configuration parameters. DBS control registers were added. Signed-off-by: Danylo Vodopianov ---

[PATCH v2 45/50] net/ntnic: used writer data handling functions

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Introduced functions to set and flush RX and TX used writer data. Added support for setting shadow data with functions for guest physical address, host ID, queue size, packed, interrupt enable, vector, and ISTK for RX and TX. Implemented set_rx_used_writer_data and set_t

[PATCH v2 41/50] net/ntnic: add packet handler for virtio queues

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Added functionality to handles the copying of segmented queue data into a rte_mbuf and vice versa. Added functionality to manages packet transmission for a specified TX and RX queues. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/ntnic_virt_queue.h |

[PATCH v2 38/50] net/ntnic: enhance Ethernet device configuration

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Added eth_dev_close function to handle closing of Ethernet devices. It releases managed RX/TX virtual queues. Initialized scatter-gather queue system. Defined constants and macros for hardware RX/TX descriptors and packet buffer sizes. Defined structures for RX and TX p

[PATCH v2 40/50] net/ntnic: add queue setup operations

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Added TX and RX queue setup. Handles memory allocation and hardware Virtio queue setup. Allocates and configures memory for hardware Virtio queues, including handling IOMMU and VFIO mappings. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/ntnic_virt_que

[PATCH v2 11/50] net/ntnic: add categorizer (CAT) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Categorizer module’s main purpose is to select the behavior of other modules in the FPGA pipeline, depending on a protocol check. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 51 + drivers/net/ntnic/include/hw_mod_cat_v

[PATCH v2 10/50] net/ntnic: add INFO flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The info module keeps track of the hardcoded parameters of the FPGA and provides an abstraction that can support if parameter is unsupported for a given FPGA. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 57 +++ drivers/net

[PATCH v2 05/50] net/ntnic: extend and fix logging implementation

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Add suffixes logging Fix the issue with the configuration log level for a specific module Fix extended debug logging 3-letter abbreviation for log type Update documentation new log modules were added Log level in functions that initialize feature operations

[PATCH v2 02/50] net/ntnic: fix coverity issues:

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov CI founc couple coverity problems which were fixed in this commit. CID 440550, 440551, 440545, 440553, 440552, 440547: Null pointer dereferences (REVERSE_INULL) These issues were fixed by reworking variable NULL checking and adding NULL checking before var using. CID 44

[PATCH v2 14/50] net/ntnic: add IP fragmenter (IFR) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The IP Fragmenter module can fragment outgoing packets based on a programmable MTU. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/meson.build | 1 + .../nthw/flow_api/flow_backend/flow_backend.c | 12 .../ntnic/nthw/flow_filter/flow_

Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-10-07 Thread Stephen Hemminger
On Tue, 2 Apr 2024 09:19:23 -0700 Tyler Retzlaff wrote: > On Sun, Mar 17, 2024 at 08:44:15PM -0600, Ashish Sadanandan wrote: > > The header was missing the extern "C" directive which causes name > > mangling of functions by C++ compilers, leading to linker errors > > complaining of undefined refe

RE: [EXTERNAL] [PATCH v2] cryptodev: add ec points to sm2 op

2024-10-07 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Thursday, October 3, 2024 4:39 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Dooley, Brian > Subject: RE: [EXTERNAL] [PATCH v2] cryptodev: add ec points to sm2 op > > > In the case when PMD cannot support the full process of the SM2

Re: [PATCH v1] crypto/ipsec_mb: bump minimum IPsec MB version

2024-10-07 Thread Ji, Kai
Acked-by: Kai Ji Any release doc needs to be updated ? From: Dooley, Brian Sent: 04 October 2024 15:58 To: Ji, Kai ; De Lara Guarch, Pablo Cc: dev@dpdk.org ; gak...@marvell.com ; wathsala.vithan...@arm.com ; Dooley, Brian Subject: [PATCH v1] crypto/ipsec_mb:

RE: [PATCH v1] crypto/ipsec_mb: bump minimum IPsec MB version

2024-10-07 Thread De Lara Guarch, Pablo
> -Original Message- > From: Dooley, Brian > Sent: Friday, October 4, 2024 3:58 PM > To: Ji, Kai ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; gak...@marvell.com; wathsala.vithan...@arm.com; > Dooley, Brian > Subject: [PATCH v1] crypto/ipsec_mb: bump minimum IPsec MB version > > AESNI_M

Re: [PATCH v2] vhost: restrict set max queue pair API to VDUSE

2024-10-07 Thread Maxime Coquelin
On 10/3/24 10:11, Maxime Coquelin wrote: In order to avoid breaking Vhost-user live-migration, we want the rte_vhost_driver_set_max_queue_num API to only be effective with VDUSE. Furthermore, this API is only really needed for VDUSE where the device number of queues is defined by the backend.

RE: [PATCH v2 1/2] cryptodev: fix RSA xform for ASN.1 syntax

2024-10-07 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Monday, October 7, 2024 9:20 AM > To: Gowrishankar Muthukrishnan ; > dev@dpdk.org; Akhil Goyal ; Fan Zhang > > Cc: Anoob Joseph ; Richardson, Bruce > ; jer...@marvell.com; Ji, Kai ; > jack.bond-pres...@foss.arm.com; Marchand, Dav

Re: [PATCH 2/2] eal/riscv: add support for zicbop extension

2024-10-07 Thread Stanisław Kardach
On Thu, May 30, 2024 at 7:20 PM Daniel Gregory wrote: > > The zicbop extension adds instructions for prefetching data into cache. > Use them to implement RISCV-specific versions of the rte_prefetch* and > rte_prefetch*_write functions. > > - prefetch.r indicates to hardware that the cache block wi

RE: [PATCH v17 1/3] eventdev: add support for independent enqueue

2024-10-07 Thread Sevincer, Abdullah
That part below was intended for continuation of the above code sample. Remember there was a DLB2 related information below I removed that. But, It looks like it is thought to be an orphan section I will remove it in the next patch set. >+The below section does not have any code. It is an orphan

[PATCH v18 2/3] event/dlb2: add support for independent enqueue

2024-10-07 Thread Abdullah Sevincer
DLB devices need events to be enqueued in the same order they are dequeued. Applications are not suppose to change event order between dequeue and to enqueue. Since Eventdev standard does not add such restrictions independent enqueue support is needed for DLB PMD so that it restores dequeue order o

[dpdk-dev] [PATCH] drivers: fix build issues with redundant newline changes

2024-10-07 Thread jerinj
From: Jerin Jacob Certain section of the code in net/mvpp2 and ml/cnxk is enabled only when all depended library dependences where meet. Fixing those build errors. Fixes: e99981af3463 ("drivers: replace logging helpers") Signed-off-by: Jerin Jacob --- drivers/ml/cnxk/mvtvm_ml_dev.c | 8 ++-

[PATCH v18 1/3] eventdev: add support for independent enqueue

2024-10-07 Thread Abdullah Sevincer
Support for independent enqueue feature and updates Event Device and PMD feature list. A new capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ is introduced. It allows out-of-order enqueuing of RTE_EVENT_OP_FORWARD or RELEASE type events on an event port where this capability is enabled. To use this c

[PATCH v18 0/3] Independent Enqueue Support

2024-10-07 Thread Abdullah Sevincer
v18: Address comments. v17: Address comments. v16: Address comments. v15: Address comments. v14: Address comments. v13: Address comments. v12: Address comments. v11: Address comments. v10: Add acked-by reviewer name. v9: Address comments. v8: Address build issues. v7: Address documentation reviews.

[PATCH v18 3/3] event/dsw: add capability for independent enqueue

2024-10-07 Thread Abdullah Sevincer
To use independent enqueue capability applications need to set flag RTE_EVENT_PORT_CFG_INDEPENDENT_ENQ during port setup only if the capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ exists. Hence, this commit adds the capability of independent enqueue to the DSW driver. Signed-off-by: Abdullah Sevince

Re: [PATCH 1/5] config/riscv: add flag for using Zbc extension

2024-10-07 Thread Stanisław Kardach
On Wed, Jun 19, 2024 at 6:41 PM Daniel Gregory wrote: > > On Wed, Jun 19, 2024 at 09:08:14AM +0200, Morten Brørup wrote: > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > 1/5] config/riscv: add flag for using Zbc extension > > > > > > On Tue, 18 Jun 2024 18:41:29 +0100 > > > Da

RE: [EXTERNAL] Re: [v2 7/7] crypto/dpaa2_sec: rework debug code

2024-10-07 Thread Gagandeep Singh
Hi All, > -Original Message- > From: Akhil Goyal > Sent: Friday, October 4, 2024 9:31 PM > To: David Marchand ; Gagandeep Singh > > Cc: dev@dpdk.org; Hemant Agrawal ; Jun Yang > ; Thomas Monjalon > Subject: RE: [EXTERNAL] Re: [v2 7/7] crypto/dpaa2_sec: rework debug code > > > Hello guy

Re: [PATCH v17 1/3] eventdev: add support for independent enqueue

2024-10-07 Thread Jerin Jacob
On Mon, Oct 7, 2024 at 7:31 AM Abdullah Sevincer wrote: > > Support for independent enqueue feature and updates Event Device > and PMD feature list. > > A new capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ is introduced. It > allows out-of-order enqueuing of RTE_EVENT_OP_FORWARD or RELEASE type > ev

RE: [PATCH v2 1/2] cryptodev: fix RSA xform for ASN.1 syntax

2024-10-07 Thread Kusztal, ArkadiuszX
Acked with a small comment. > -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Friday, October 4, 2024 8:11 AM > To: dev@dpdk.org; Akhil Goyal ; Fan Zhang > > Cc: Anoob Joseph ; Richardson, Bruce > ; jer...@marvell.com; Kusztal, ArkadiuszX > ; Ji, Kai ; jack.bond- > pres...@

Re: [PATCH v6 2/6] crypto/openssl: support EDDSA

2024-10-07 Thread Ji, Kai
Acked-by: Kai Ji From: Gowrishankar Muthukrishnan Sent: 04 October 2024 09:26 To: dev@dpdk.org ; Ji, Kai Cc: Anoob Joseph ; Richardson, Bruce ; jer...@marvell.com ; fanzhang@gmail.com ; Kusztal, ArkadiuszX ; jack.bond-pres...@foss.arm.com ; Marchand, Dav

Re: [PATCH] crypto/dpaa2_sec: rework debug code

2024-10-07 Thread David Marchand
On Mon, Oct 7, 2024 at 10:44 AM Gagandeep Singh wrote: > > Output debug information according to various modes. > > Signed-off-by: Jun Yang > Signed-off-by: Gagandeep Singh > --- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 87 +++-- > 1 file changed, 63 insertions(+), 24 del

Re: [EXTERNAL] Re: [v2 7/7] crypto/dpaa2_sec: rework debug code

2024-10-07 Thread David Marchand
On Mon, Oct 7, 2024 at 10:46 AM Gagandeep Singh wrote: > > > I see this patch is already merged in next-crypto. > > > Please, can this be fixed before reaching main? > > > > > Gagan, > > This patch is removed from the crypto tree for now. > > > > Please rework and send as separate patch. > > I hav

RE: [RFC 0/4] ethdev: rework config restore

2024-10-07 Thread Konstantin Ananyev
> > External email: Use caution opening links or attachments > > > > > > On 9/18/2024 10:21 AM, Dariusz Sosnowski wrote: > > > Hi all, > > > > > > We have been working on optimizing the latency of calls to > > > rte_eth_dev_start(), on ports spawned by mlx5 PMD. Most of the work > > > requires ch

Re: [PATCH v2 02/10] baseband/acc: queue allocation refactor

2024-10-07 Thread Maxime Coquelin
Hi Nicolas, On 10/4/24 20:19, Chautru, Nicolas wrote: Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Friday, October 4, 2024 5:08 AM To: Vargas, Hernan ; dev@dpdk.org; gak...@marvell.com; t...@redhat.com Cc: Chautru, Nicolas ; Zhang, Qi Z Subject: Re: [PATCH v2 02/10] base

[PATCH] crypto/dpaa2_sec: rework debug code

2024-10-07 Thread Gagandeep Singh
Output debug information according to various modes. Signed-off-by: Jun Yang Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 87 +++-- 1 file changed, 63 insertions(+), 24 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/

[PATCH] net/mlx5/hws: in NAT64 fix TC to TOS fields mapping

2024-10-07 Thread Itamar Gozlan
From: Hamdan Igbaria In IPv6 to IPv4 scenario when copying the TC field to the TOS[DSCP:6 bits, ECN: 2 bits] field the mapping of the fields get set wrongly, since the destination field of TOS is defined as 2 split fields of DSCP and ECN. In IPv4 to IPv6 we don't have this issue since both the so

Re: [dpdk-dev] [PATCH] drivers: fix build issues with redundant newline changes

2024-10-07 Thread David Marchand
Hello Jerin, On Mon, Oct 7, 2024 at 10:13 AM wrote: > > From: Jerin Jacob > > Certain section of the code in net/mvpp2 and ml/cnxk is enabled only > when all depended library dependences where meet. > Fixing those build errors. Sorry for missing those. Too bad there is no CI with such libraries

[PATCH] crypto/dpaa2_sec: rework debug code

2024-10-07 Thread Gagandeep Singh
Output debug information according to various modes. Signed-off-by: Jun Yang Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 87 +++-- 1 file changed, 63 insertions(+), 24 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/

Re: [PATCH] crypto/scheduler: fix incorrect variable usage

2024-10-07 Thread Ji, Kai
I'm not see any issue with original code, can you give more details about crash so I can try to reproduce at my end. cc kirill.rybalche...@intel.com for review From: Yong Liang <1269690...@qq.com> Sent: 18 September 2024 15:15 To: dev@dpdk.org Cc: roy.fan.zh...@

Re: [PATCH v1] crypto/ipsec_mb: bump minimum IPsec MB version

2024-10-07 Thread Dooley, Brian
Good point Kai, i'll update the patch. Thanks, Brian From: Ji, Kai Sent: Monday, October 7, 2024 11:09 AM To: Dooley, Brian ; De Lara Guarch, Pablo Cc: dev@dpdk.org ; gak...@marvell.com ; wathsala.vithan...@arm.com Subject: Re: [PATCH v1] crypto/ipsec_mb: bump

Re: [PATCH] eal/x86: cache queried CPU flags

2024-10-07 Thread Bruce Richardson
On Mon, Oct 07, 2024 at 04:29:31PM +, Wathsala Wathawana Vithanage wrote: > > Rather than re-querying the HW each time a CPU flag is requested, we can > > just > > save the return value in the flags array. This should speed up repeated > > querying of CPU flags, and provides a workaround for a

RE: [PATCH v2 02/10] baseband/acc: queue allocation refactor

2024-10-07 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Monday, October 7, 2024 2:31 AM > To: Chautru, Nicolas ; Vargas, Hernan > ; dev@dpdk.org; gak...@marvell.com; > t...@redhat.com > Cc: Zhang, Qi Z > Subject: Re: [PATCH v2 02/10] baseband/acc: queue allocation refactor > >

[PATCH v2] crypto/ipsec_mb: bump minimum IPsec MB version

2024-10-07 Thread Brian Dooley
AESNI_MB SW PMDs increment Intel IPsec MB version to 1.4. A minimum IPsec Multi-buffer version of 1.4 or greater is now required for the 24.11 LTS release. Signed-off-by: Brian Dooley Acked-by: Kai Ji Acked-by: Pablo de Lara --- This patch relates to a deprecation notice sent in the 24.03 relea

Re: [PATCH v8 3/6] eventdev: add event preschedule hint

2024-10-07 Thread Jerin Jacob
On Sun, Oct 6, 2024 at 10:44 PM wrote: > > From: Pavan Nikhilesh > > Add a new eventdev API to provide a hint to the eventdev PMD to > pre-schedule the next event into the event port, without releasing > the current flow context. > Event device that support this feature advertises the capability

RE: [PATCH v6 1/6] cryptodev: add EDDSA asymmetric crypto algorithm

2024-10-07 Thread Kusztal, ArkadiuszX
Hi Gowrishankar, I like the idea of adding EdDSA, but I have several comments. > -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Friday, October 4, 2024 10:26 AM > To: dev@dpdk.org; Akhil Goyal ; Fan Zhang > > Cc: Anoob Joseph ; Richardson, Bruce > ; jer...@marvell.com; Ku

Re: [PATCH 1/5] config/riscv: add flag for using Zbc extension

2024-10-07 Thread Stephen Hemminger
On Mon, 7 Oct 2024 10:14:22 +0200 Stanisław Kardach wrote: > > > > > > > > Please do not add more config options via compile flags. > > > > It makes it impossible for distros to ship one version. > That is a problem with RISC-V in general. Since all features are > "extensions" and there is no l

Re: [PATCH 4/4] ethdev: add traffic manager query function

2024-10-07 Thread Bruce Richardson
On Sun, Sep 22, 2024 at 05:26:30PM +0100, Ferruh Yigit wrote: > On 8/6/2024 4:24 PM, Bruce Richardson wrote: > > +/** > > + * Return information about a traffic management node > > + * > > + * Return information about a hierarchy node, using the same format of > > parameters > > + * as was passed

[PATCH v9 1/6] eventdev: introduce event pre-scheduling

2024-10-07 Thread pbhagavatula
From: Pavan Nikhilesh Event pre-scheduling improves scheduling performance by assigning events to event ports in advance when dequeues are issued. The dequeue operation initiates the pre-schedule operation, which completes in parallel without affecting the dequeued event flow contexts and dequeue

[PATCH v9 2/6] eventdev: add event port pre-schedule modify

2024-10-07 Thread pbhagavatula
From: Pavan Nikhilesh Some event devices allow pre-schedule types to be modified at runtime on an event port. Add `RTE_EVENT_DEV_CAP_PER_PORT_PRESCHEDULE` capability to indicate that the event device supports this feature. Add `rte_event_port_preschedule_modify()` API to modify the pre-schedule

[PATCH v9 3/6] eventdev: add event preschedule hint

2024-10-07 Thread pbhagavatula
From: Pavan Nikhilesh Add a new eventdev API to provide a hint to the eventdev PMD to pre-schedule the next event into the event port, without releasing the current flow context. Event device that support this feature advertises the capability using the RTE_EVENT_DEV_CAP_PRESCHEDULE_EXPLICIT capa

[PATCH v9 4/6] event/cnkx: add pre-schedule support

2024-10-07 Thread pbhagavatula
From: Pavan Nikhilesh Add device level and port level pre-schedule support for cnxk eventdev. Signed-off-by: Pavan Nikhilesh --- doc/guides/eventdevs/cnxk.rst | 10 -- doc/guides/eventdevs/features/cnxk.ini | 1 + drivers/event/cnxk/cn10k_eventdev.c| 19 +-

[PATCH v9 0/6] Introduce event pre-scheduling

2024-10-07 Thread pbhagavatula
From: Pavan Nikhilesh Event pre-scheduling improves scheduling performance by assigning events to event ports in advance when dequeues are issued. This series introduces various types and levels of pre-scheduling to the eventdev library. pre-scheduling Types: * RTE_EVENT_PRESCHEDULE_NONE: No pr

[PATCH v9 5/6] app/test-eventdev: add pre-scheduling support

2024-10-07 Thread pbhagavatula
From: Pavan Nikhilesh Add support to configure pre-scheduling for eventdev test application. Option `--preschedule` 0 - Disable pre-scheduling. 1 - Enable pre-scheduling. 2 - Enable pre-schedule with adaptive mode (Default). Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/evt_common

[PATCH v9 6/6] examples: use eventdev pre-scheduling

2024-10-07 Thread pbhagavatula
From: Pavan Nikhilesh Enable event pre-scheduling if supported by the event device. Signed-off-by: Pavan Nikhilesh --- examples/eventdev_pipeline/pipeline_worker_generic.c | 6 ++ examples/eventdev_pipeline/pipeline_worker_tx.c | 6 ++ examples/ipsec-secgw/event_helper.c

RE: [PATCH v6 2/6] crypto/openssl: support EDDSA

2024-10-07 Thread Kusztal, ArkadiuszX
Hi Gowrishankar, > -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Friday, October 4, 2024 10:26 AM > To: dev@dpdk.org; Ji, Kai > Cc: Anoob Joseph ; Richardson, Bruce > ; jer...@marvell.com; fanzhang@gmail.com; > Kusztal, ArkadiuszX ; jack.bond- > pres...@foss.arm.com;

RE: [PATCH] eal/x86: cache queried CPU flags

2024-10-07 Thread Wathsala Wathawana Vithanage
> Rather than re-querying the HW each time a CPU flag is requested, we can just > save the return value in the flags array. This should speed up repeated > querying of CPU flags, and provides a workaround for a reported issue where > errors are seen with constant querying of the AVX-512 CPU flag fr

[PATCH 4/5] net/virtio: implement update link state API

2024-10-07 Thread skoteshwar
From: Satha Rao This patch introduces the vhost_vdpa_update_link_state API to manage the link state updates. Signed-off-by: Satha Rao --- drivers/net/virtio/virtio_user/vhost_vdpa.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/virtio/virtio_user

[PATCH 5/5] net/virtio-user: support vDPA configuration callback

2024-10-07 Thread skoteshwar
From: Satha Rao Extended the vhost_vdpa_get_intr_fd API to create an event and register for configuration callbacks with the vDPA backend. This enhancement allows the virtio-user driver to handle configuration changes more effectively. Signed-off-by: Satha Rao --- drivers/net/virtio/virtio_use

[PATCH 2/5] net/virtio-user: get link duplex and speed

2024-10-07 Thread skoteshwar
From: Satha Rao This patch extends the virtio_user_read_dev_config API to retrieve link speed and duplex settings if the device features support VIRTIO_NET_F_SPEED_DUPLEX. Signed-off-by: Satha Rao --- .../net/virtio/virtio_user/virtio_user_dev.c | 22 ++- .../net/virtio/virtio

[PATCH 3/5] net/virtio: add set config callback

2024-10-07 Thread skoteshwar
From: Satha Rao This patch enables the set config callback handler. Signed-off-by: Satha Rao --- drivers/net/virtio/virtio_user/vhost.h | 1 + drivers/net/virtio/virtio_user/vhost_vdpa.c | 10 ++ 2 files changed, 11 insertions(+) diff --git a/drivers/net/virtio/virtio_user/vhost

[PATCH 1/5] interrupts: fix number of bytes read for vdev

2024-10-07 Thread skoteshwar
From: Satha Rao Correct the number of bytes to read during vdev interrupt processing. The driver sets this value, and the rxtx interrupt handling already performs this correctly. Fixes: 8feec90 ("eal/linux: add interrupt type for vdev") Cc: sta...@dpdk.org Signed-off-by: Satha Rao --- lib

Re: [PATCH v2 0/3] make struct parameters constant in rte_tm APIs

2024-10-07 Thread Stephen Hemminger
On Mon, 7 Oct 2024 12:49:04 +0100 Bruce Richardson wrote: > For functions for creating profiles, shapers and hierarchy nodes, make > the parameter structure pointer a pointer to a const object. This > guarantees to the user that the struct won't be modified by the > function, which allows the us

Re: [PATCH] net/mlx5: support no host PF configuration

2024-10-07 Thread Stephen Hemminger
On Wed, 11 Oct 2023 09:41:53 +0300 Jiawei Wang wrote: > From: Xueming Li > > In BlueField, a new firmware configuration option NUM_OF_PF=0 disables > PF on the x86 host side, no HPF on the ARM side, and the only RDMA port > on the ARM side is the bonding device(PF0). A device probe with devargs

Re: [PATCH v2 0/4] power: refactor power management library

2024-10-07 Thread Stephen Hemminger
On Mon, 26 Aug 2024 13:06:45 + Sivaprasad Tummala wrote: > This patchset refactors the power management library, addressing both > core and uncore power management. The primary changes involve the > creation of dedicated directories for each driver within > 'drivers/power/core/*' and 'drivers

Re: [PATCH v6] app/testpmd: enable cli for programmable action

2024-10-07 Thread Stephen Hemminger
On Thu, 18 Apr 2024 16:39:14 +0100 Ferruh Yigit wrote: > On 2/8/2024 1:10 AM, Ferruh Yigit wrote: > > On 10/11/2023 1:03 PM, Qi Zhang wrote: > >> Parsing command line for rte_flow_action_prog. > >> > >> Syntax: > >> > >> "prog name [arguments \ > >>... end]" > >> > >> Use parse_string0 t

Re: [PATCH] doc: remove confusing command to send patch

2024-10-07 Thread Stephen Hemminger
On Tue, 10 Oct 2023 18:26:35 +0200 Thomas Monjalon wrote: > In the contributor guide, it was said that no need to Cc maintainers > for new additions, probably for new directories not having a maintainer. > There is no harm, and it is a good habit, to always Cc maintainers. > > Remove this case a

[PATCH v2 29/50] net/ntnic: add key match (KM) FPGA module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Key Matcher module checks the values of individual fields of a packet. It supports both exact match which is implemented with a CAM, and wildcards which is implemented with a TCAM. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h

[PATCH v2 30/50] net/ntnic: add flow matcher (FLM) FPGA module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Flow Matcher module is a high-performance stateful SDRAM lookup and programming engine which supported exact match lookup in line-rate of up to hundreds of millions of flows. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h|

[PATCH v2 35/50] net/ntnic: add Tx Packet Editor (TPE) FPGA module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The TX Packet Editor is a software abstraction module, that keeps track of the handful of FPGA modules that are used to edit packets in the TX pipeline. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 80 + drivers/net/ntn

[PATCH v2 32/50] net/ntnic: add queue select (QSL) FPGA module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Queue Selector module directs packets to a given destination which includes host queues, physical ports, exceptions paths, and discard. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 37 drivers/net/ntnic/meson.build

[PATCH v2 31/50] net/ntnic: add hasher (HSH) FPGA module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Hasher module calculates a configurable hash value to be used internally by the FPGA. The module support both Toeplitz and NT-hash. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 36 drivers/net/ntnic/meson.build

[PATCH v2 37/50] net/ntnic: add basic queue operations

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Adds support for queue configure, start, stop, release. The internal macro and functions of ntnic were also added and initialized. Signed-off-by: Danylo Vodopianov --- doc/guides/nics/features/ntnic.ini | 1 + drivers/net/ntnic/include/ntos_drv.h | 34 + driver

[PATCH v2 36/50] net/ntnic: add receive MAC converter (RMC) core module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The RX MAC Converter module is part of the control mechanism of the physical ports. Signed-off-by: Oleksandr Kolomeiets --- v2 * Fix Typo/Spelling * Update release notes --- doc/guides/rel_notes/release_24_11.rst| 1 + drivers/net/ntnic/adapter/nt4ga_adapter

[PATCH v2 34/50] net/ntnic: add packet descriptor builder (PDB) FPGA module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Packet Description Builder module creates packet meta-data for example virtio-net headers. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 34 drivers/net/ntnic/meson.build | 1 + drivers/net/ntnic

[PATCH v2 33/50] net/ntnic: add slicer (SLC LR) FPGA module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Slicer for Local Retransmit module can cut of the head a packet before the packet leaves the FPGA RX pipeline. This is used when the TX pipeline is configured to add a new head in the packet. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mo

Re: [PATCH] app/flow-perf: replace RTE_BE32/16 with rte_cpu_to_be_32/16 for variables

2024-10-07 Thread Stephen Hemminger
On Tue, 18 Apr 2023 11:32:50 + Wisam Monther wrote: > Hi, > > > > > > > > -Original Message- > > > > From: Harold Huang > > > > Sent: Sunday, March 12, 2023 4:00 AM > > > > To: dev@dpdk.org > > > > Cc: Harold Huang ; Wisam Monther > > > > > > > > Subject: [PATCH] app/flow-perf: r

Re: [PATCH] examples/ipsec-secgw: fix cmp_sa_key bug

2024-10-07 Thread Stephen Hemminger
On Wed, 22 Nov 2023 15:58:40 +0800 supeng2087 wrote: > From: supeng > > Inbound direction, sad_lookup function will call cmp_sa_key to compare packet > outer ip info with local sa. Local sa src ip should equal packet dst ip, > Local sa dst ip should equal src ip. > --- > examples/ipsec-se

[PATCH v2 12/50] net/ntnic: add key match (KM) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Key Matcher module checks the values of individual fields of a packet. It supports both exact match which is implemented with a CAM, and wildcards which is implemented with a TCAM. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h

[PATCH v2 25/50] net/ntnic: add Tx Packet Editor (TPE) flow module

2024-10-07 Thread Serhii Iliushyk
The TX Packet Editor is a software abstraction module, that keeps track of the handful of FPGA modules that are used to edit packets in the TX pipeline. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/include/hw_mod_backend.h| 27 ++ drivers/net/ntnic/include/hw_mod_tpe_v3.h | 126

[PATCH v2 24/50] net/ntnic: add replacer (Tx RPL) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The TX Replacer module can replace a range of bytes in a packet. The replacing data is stored in a table in the module and will often contain tunnel data. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/meson.build | 1 + .../nthw/flow_api/

[PATCH v2 18/50] net/ntnic: add packet descriptor builder (PDB) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Packet Description Builder module creates packet meta-data for example virtio-net headers. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 16 ++ drivers/net/ntnic/include/hw_mod_pdb_v9.h | 42 drivers/net/ntnic/

[PATCH v2 23/50] net/ntnic: add insert (Tx INS) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets he TX Inserter module injects zeros into an offset of a packet, effectively expanding the packet. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/meson.build | 1 + .../nthw/flow_api/flow_backend/flow_backend.c | 13 .../ntnic/nthw/flo

  1   2   >