On Tue, 12 Mar 2024 00:51:48 -0700 Tyler Retzlaff <roret...@linux.microsoft.com> wrote:
> diff --git a/lib/ethdev/rte_ethdev_export.h b/lib/ethdev/rte_ethdev_export.h > new file mode 100644 > index 0000000..7887bee > --- /dev/null > +++ b/lib/ethdev/rte_ethdev_export.h > @@ -0,0 +1,23 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2024 Microsoft Corporation > + */ > + > +#ifndef _RTE_ETHDEV_EXPORT_H_ > +#define _RTE_ETHDEV_EXPORT_H_ > + > +/** > + * @file > + * > + * Import / Export macros for ethdev data variables. > + */ > + > +#include <rte_common.h> > + > +#ifndef __rte_ethdev_export > +#define __rte_ethdev_export __rte_declare_import > +#else > +#undef __rte_ethdev_export > +#define __rte_ethdev_export __rte_declare_export > +#endif > + > +#endif Why not put this in rte_ethdev_core.h rather than a new file?? Patch needs to be resubmitted anyway because it fails github build from missing C++ guards.
