Re: [dpdk-dev] [PATCH] telemetry: fix build on FreeBSD < 12.2

2021-04-21 Thread Thomas Monjalon
21/04/2021 20:11, Thomas Monjalon: > The function pthread_setname_np() was originally not available on > FreeBSD. It has been added in FreeBSD 12.2: > https://svnweb.freebsd.org/base?view=revision&revision=362264 > > The EAL implementation of rte_thread_setname() is duplicated > in the telemetry l

[dpdk-dev] [PATCH] telemetry: fix build on FreeBSD < 12.2

2021-04-21 Thread Thomas Monjalon
The function pthread_setname_np() was originally not available on FreeBSD. It has been added in FreeBSD 12.2: https://svnweb.freebsd.org/base?view=revision&revision=362264 The EAL implementation of rte_thread_setname() is duplicated in the telemetry library, which does not depend on EAL, so the co

Re: [dpdk-dev] [PATCH] telemetry: fix build for armv7

2020-05-11 Thread David Marchand
On Mon, May 11, 2020 at 3:32 PM David Marchand wrote: > > telemetry can not depend on EAL anymore but it still wants to get arch > headers. > We directly point at the right source directories by using the same logic > than EAL. However the special case of armv7 has been missed. > > Fix this by def

Re: [dpdk-dev] [PATCH] telemetry: fix build for armv7

2020-05-11 Thread Bruce Richardson
On Mon, May 11, 2020 at 03:58:47PM +0200, David Marchand wrote: > On Mon, May 11, 2020 at 3:47 PM Bruce Richardson > wrote: > > > > On Mon, May 11, 2020 at 03:32:12PM +0200, David Marchand wrote: > > > telemetry can not depend on EAL anymore but it still wants to get arch > > > headers. > > > We d

Re: [dpdk-dev] [PATCH] telemetry: fix build for armv7

2020-05-11 Thread David Marchand
On Mon, May 11, 2020 at 3:47 PM Bruce Richardson wrote: > > On Mon, May 11, 2020 at 03:32:12PM +0200, David Marchand wrote: > > telemetry can not depend on EAL anymore but it still wants to get arch > > headers. > > We directly point at the right source directories by using the same logic > > than

Re: [dpdk-dev] [PATCH] telemetry: fix build for armv7

2020-05-11 Thread Bruce Richardson
On Mon, May 11, 2020 at 03:32:12PM +0200, David Marchand wrote: > telemetry can not depend on EAL anymore but it still wants to get arch > headers. > We directly point at the right source directories by using the same logic > than EAL. However the special case of armv7 has been missed. > No object

[dpdk-dev] [PATCH] telemetry: fix build for armv7

2020-05-11 Thread David Marchand
telemetry can not depend on EAL anymore but it still wants to get arch headers. We directly point at the right source directories by using the same logic than EAL. However the special case of armv7 has been missed. Fix this by defaulting ARCH_DIR to RTE_ARCH. Caught on OBS: [ 162s] SYMLINK-FIL

Re: [dpdk-dev] [PATCH] telemetry: fix build warnings seen when using gcc 9

2019-08-23 Thread Musatescu, Flavia
On 23/08/2019 11:01, Kevin Traynor wrote: On 02/07/2019 15:20, Flavia Musatescu wrote: Suppress the unaligned packed member address warnings by extending the telemetry library build flags with -Wno-address-of-packed-member option, through the WERROR_FLAGS makefile variable. With this change a

Re: [dpdk-dev] [PATCH] telemetry: fix build warnings seen when using gcc 9

2019-08-23 Thread Kevin Traynor
On 02/07/2019 15:20, Flavia Musatescu wrote: > Suppress the unaligned packed member address warnings by extending > the telemetry library build flags with -Wno-address-of-packed-member > option, through the WERROR_FLAGS makefile variable. > > With this change additional warnings are turned on to b

[dpdk-dev] [PATCH] telemetry: fix build warnings seen when using gcc 9

2019-07-02 Thread Flavia Musatescu
Suppress the unaligned packed member address warnings by extending the telemetry library build flags with -Wno-address-of-packed-member option, through the WERROR_FLAGS makefile variable. With this change additional warnings are turned on to be treated as errors, which causes the following build i

Re: [dpdk-dev] [PATCH] telemetry: fix build

2019-06-28 Thread Ferruh Yigit
On 6/28/2019 10:57 AM, Thomas Monjalon wrote: > 28/06/2019 11:55, Ferruh Yigit: >> On 6/28/2019 10:17 AM, Thomas Monjalon wrote: >>> 28/06/2019 10:46, Laatz, Kevin: On 27/06/2019 20:51, Ferruh Yigit wrote: > Build error: > ../lib/librte_telemetry/rte_telemetry.c:558:28: >e

Re: [dpdk-dev] [PATCH] telemetry: fix build

2019-06-28 Thread Thomas Monjalon
28/06/2019 11:55, Ferruh Yigit: > On 6/28/2019 10:17 AM, Thomas Monjalon wrote: > > 28/06/2019 10:46, Laatz, Kevin: > >> > >> On 27/06/2019 20:51, Ferruh Yigit wrote: > >>> Build error: > >>> ../lib/librte_telemetry/rte_telemetry.c:558:28: > >>>error: comparison of unsigned expression < 0 is al

Re: [dpdk-dev] [PATCH] telemetry: fix build

2019-06-28 Thread Ferruh Yigit
On 6/28/2019 10:17 AM, Thomas Monjalon wrote: > 28/06/2019 10:46, Laatz, Kevin: >> >> On 27/06/2019 20:51, Ferruh Yigit wrote: >>> Build error: >>> ../lib/librte_telemetry/rte_telemetry.c:558:28: >>>error: comparison of unsigned expression < 0 is always false >>>[-Werror,-Wtautological-comp

Re: [dpdk-dev] [PATCH] telemetry: fix build

2019-06-28 Thread Thomas Monjalon
28/06/2019 10:46, Laatz, Kevin: > > On 27/06/2019 20:51, Ferruh Yigit wrote: > > Build error: > > ../lib/librte_telemetry/rte_telemetry.c:558:28: > >error: comparison of unsigned expression < 0 is always false > >[-Werror,-Wtautological-compare] > > > > Build error not observed in default

Re: [dpdk-dev] [PATCH] telemetry: fix build

2019-06-28 Thread Laatz, Kevin
On 27/06/2019 20:51, Ferruh Yigit wrote: Build error: ../lib/librte_telemetry/rte_telemetry.c:558:28: error: comparison of unsigned expression < 0 is always false [-Werror,-Wtautological-compare] Build error not observed in default make build because telemetry library disabled by default

[dpdk-dev] [PATCH] telemetry: fix build

2019-06-27 Thread Ferruh Yigit
Build error: ../lib/librte_telemetry/rte_telemetry.c:558:28: error: comparison of unsigned expression < 0 is always false [-Werror,-Wtautological-compare] Build error not observed in default make build because telemetry library disabled by default but easier to reproduce via meson. Fixing by