28/06/2019 10:46, Laatz, Kevin:
>
> On 27/06/2019 20:51, Ferruh Yigit wrote:
> > Build error:
> > ../lib/librte_telemetry/rte_telemetry.c:558:28:
> > error: comparison of unsigned expression < 0 is always false
> > [-Werror,-Wtautological-compare]
> >
> > Build error not observed in default make build because telemetry library
> > disabled by default but easier to reproduce via meson.
No, I compile telemetry with make and with meson.
I cannot reproduce the error. I guess it depends of the compiler version?
> > Fixing by converting unsigned variables to signed.
> >
> > Fixes: 0fe3a37924d4 ("telemetry: format json response when sending stats")
> > Fixes: 4080e46c8078 ("telemetry: support global metrics")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yi...@intel.com>
> > ---
> > Cc: Reshma Pattan <reshma.pat...@intel.com>
> > Cc: Flavia Musatescu <flavia.musate...@intel.com>
> > ---
> > lib/librte_telemetry/rte_telemetry.c | 12 ++++++------
> > lib/librte_telemetry/rte_telemetry_internal.h | 6 +++---
> > 2 files changed, 9 insertions(+), 9 deletions(-)
>
> Acked-by: Kevin Laatz <kevin.la...@intel.com>
Applied, thanks
