Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix

2023-08-21 Thread Patrick Robb
Hi David, Responding to your Slack request about merging Bruce's patch ahead of yours here so there is more visibility. That is fine, but as you point out it will mean a temporary loss of test coverage, as it will disable arm unit testing until either 1. your patch fixing the flags test hits main

Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix

2023-08-21 Thread David Marchand
On Sat, Aug 19, 2023 at 1:26 AM Patrick Robb wrote: > On Fri, Aug 18, 2023 at 6:33 PM Patrick Robb wrote: >> >> >> For your patch, it looks like there are actually more eal flags test >> failures: >> http://mails.dpdk.org/archives/test-report/2023-August/444170.html. In any >> case, for debugg

Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix

2023-08-18 Thread Patrick Robb
On Fri, Aug 18, 2023 at 6:33 PM Patrick Robb wrote: > > For your patch, it looks like there are actually more eal flags test > failures: > http://mails.dpdk.org/archives/test-report/2023-August/444170.html. In > any case, for debugging purposes, I will do a run with > the eal_flags_file_prefix_au

Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix

2023-08-18 Thread Patrick Robb
On Fri, Aug 18, 2023 at 3:07 AM David Marchand wrote: > It is a "recurring" yet not so well known issue. > This unit test fails if any part of the DPDK did not release all > (hugepage backed) memory and associated hugepages before exiting. > > In your case here, there is a virtio-net device that

Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix

2023-08-18 Thread David Marchand
On Wed, Aug 16, 2023 at 9:26 PM David Marchand wrote: > > On Wed, Aug 16, 2023 at 8:30 PM Patrick Robb wrote: > > On Wed, Aug 16, 2023 at 10:40 AM David Marchand > > wrote: > >> > >> Patrick, Bruce, > >> > >> If it was reported, I either missed it or forgot about it, sorry. > >> Can you (re)sha

Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix

2023-08-17 Thread Patrick Robb
On Thu, Aug 17, 2023 at 3:28 AM David Marchand wrote: > It is possible to list tests from meson. > Why not simply list the existing tests and filter the non working one? > > $ meson test -C --suite fast-tests --list > $ meson test -C --test-args ... > > That requires no change in DPDK. > > > T

Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix

2023-08-17 Thread Bruce Richardson
On Thu, Aug 17, 2023 at 09:27:50AM +0200, David Marchand wrote: > On Wed, Aug 16, 2023 at 8:30 PM Patrick Robb wrote: > >> Patching sources from the test tool is a poor solution. > >> In general, developers won't be aware of source patching and will > >> waste time trying to understand why they ca

Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix

2023-08-17 Thread David Marchand
On Wed, Aug 16, 2023 at 8:30 PM Patrick Robb wrote: >> Patching sources from the test tool is a poor solution. >> In general, developers won't be aware of source patching and will >> waste time trying to understand why they can't reproduce what the CI >> reports (it happened to me with DTS on the

Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix

2023-08-16 Thread Patrick Robb
On Wed, Aug 16, 2023 at 3:26 PM David Marchand wrote: > On Wed, Aug 16, 2023 at 8:30 PM Patrick Robb wrote: > > On Wed, Aug 16, 2023 at 10:40 AM David Marchand < > david.march...@redhat.com> wrote: > >> > >> Patrick, Bruce, > >> > >> If it was reported, I either missed it or forgot about it, sor

Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix

2023-08-16 Thread David Marchand
On Wed, Aug 16, 2023 at 8:30 PM Patrick Robb wrote: > On Wed, Aug 16, 2023 at 10:40 AM David Marchand > wrote: >> >> Patrick, Bruce, >> >> If it was reported, I either missed it or forgot about it, sorry. >> Can you (re)share the context? >> >> >> > >> > Does the test suite pass if the mlx5 driv

Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix

2023-08-16 Thread Patrick Robb
On Wed, Aug 16, 2023 at 10:40 AM David Marchand wrote: > Patrick, Bruce, > > If it was reported, I either missed it or forgot about it, sorry. > Can you (re)share the context? > > > > Does the test suite pass if the mlx5 driver is disabled in the build? > That > > could confirm or refute the su

Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix

2023-08-16 Thread David Marchand
Patrick, Bruce, On Wed, Aug 16, 2023 at 2:57 PM Bruce Richardson wrote: > > On Tue, Aug 15, 2023 at 03:05:08PM -0400, Patrick Robb wrote: > >Adam from our team just raised something important about this patch and > >UNH CI which I missed during the RFC discussion. > >Presently, eal_fl

Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix

2023-08-16 Thread Bruce Richardson
On Tue, Aug 15, 2023 at 03:05:08PM -0400, Patrick Robb wrote: >Adam from our team just raised something important about this patch and >UNH CI which I missed during the RFC discussion. >Presently, eal_flags_file_prefix_autotest fails on arm tx2 systems (arm >people are aware of this

Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix

2023-08-16 Thread Bruce Richardson
On Tue, Aug 15, 2023 at 03:05:08PM -0400, Patrick Robb wrote: >Adam from our team just raised something important about this patch and >UNH CI which I missed during the RFC discussion. >Presently, eal_flags_file_prefix_autotest fails on arm tx2 systems (arm >people are aware of this

Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix

2023-08-15 Thread Patrick Robb
Adam from our team just raised something important about this patch and UNH CI which I missed during the RFC discussion. Presently, eal_flags_file_prefix_autotest fails on arm tx2 systems (arm people are aware of this, they think it might be a memory leak from mlx5 driver), so at their request we a

[PATCH v5 04/10] app/test: build using per-file dependency matrix

2023-08-15 Thread Bruce Richardson
Rather than using if-else constructs to selectively add or remove files from the UT build, switch to a table-based approach where each file lists out what libs or drivers it depends upon. Initial version of this table was generated via analysis of the header files included in each C file. The basi