Hi David, Responding to your Slack request about merging Bruce's patch ahead of yours here so there is more visibility.
That is fine, but as you point out it will mean a temporary loss of test coverage, as it will disable arm unit testing until either 1. your patch fixing the flags test hits mainline and we can re-enable testing without failing everyone's patchseries or 2. Bruce's RFC ([RFC PATCH] app/test: add support for skipping tests) is implemented and made a part of mainline. I agree with you this is the best thing to do so as to not hold up Bruce and his series. On Mon, Aug 21, 2023 at 3:13 AM David Marchand <[email protected]> wrote: > On Sat, Aug 19, 2023 at 1:26 AM Patrick Robb <[email protected]> wrote: > > On Fri, Aug 18, 2023 at 6:33 PM Patrick Robb <[email protected]> wrote: > >> > >> > >> For your patch, it looks like there are actually more eal flags test > failures: > http://mails.dpdk.org/archives/test-report/2023-August/444170.html. In > any case, for debugging purposes, I will do a run with the > eal_flags_file_prefix_autotest also included and send you the meson test > detail log on slack. > >> > > Quick follow up - I see with your patch it does pass on > eal_flags_file_prefix_autotest, but as stated fails some others now. The > detailed slack logs are DM'ed to you on slack. Thanks! > > Thanks for the report. > Interestingly those failures pointed out that I broke secondary > processes when no port gets initialised in the primary process. > > I'll send a v3. > > > -- > David Marchand > > -- Patrick Robb Technical Service Manager UNH InterOperability Laboratory 21 Madbury Rd, Suite 100, Durham, NH 03824 www.iol.unh.edu
