Re: [PATCH] net/mlx5: fix crash when secondary queries dev info after primary exits

2025-07-21 Thread Dariusz Sosnowski
On Mon, Jul 21, 2025 at 01:59:59PM +0200, Thomas Monjalon wrote: > 21/07/2025 13:46, Ivan Malov: > > On Mon, 21 Jul 2025, Dariusz Sosnowski wrote: > > > > > + mlx5 maintainers > > > > > > Thank you for the patch. > > > > > > Could yo

Re: [PATCH] doc/mlx5: document firmware requirement for flex item

2025-07-21 Thread Dariusz Sosnowski
On Wed, Jul 16, 2025 at 03:49:40AM -0400, Khadem Ullah wrote: > Hi Dariusz, > > Thanks for the follow-up. > > I was using DPDK v23.11 with the following flex item configuration: > > { > "next_header": { "field_mode": "FIELD_MODE_FIXED", "field_size": 0, > "field_base": 0 }, > "next_protocol

Re: [PATCH] net/mlx5: fix crash when secondary queries dev info after primary exits

2025-07-21 Thread Dariusz Sosnowski
+ mlx5 maintainers Thank you for the patch. Could you please include other PMD maintainers (or other maintainers, depending on changed code) in the future patches? There is a script which automatically adds maintainers while sending a patch. It is described in: https://doc.dpdk.org/guides/contr

[PATCH] net/mlx5: document IP fragment matching limitations

2025-07-18 Thread Dariusz Sosnowski
NVIDIA NICs do not support matching on packet headers appearing after IP header if the received packet is an IP fragment. This patch updates the relevant documentation. Bugzilla ID: 1417 Signed-off-by: Dariusz Sosnowski --- Depends-on: series-35735 ("rework mlx5 guide") FYI - I adde

Re: [PATCH v2] doc: update parameters to use for mlx5 on Windows

2025-07-18 Thread Dariusz Sosnowski
to "-L..." and: - as you mentioned on previous patch, does not work (-LIBPATH is required) - this is with meson 1.5.2 - but works with meson 0.57.2 (used in our local builds) In both cases, MS linker is detected. Older meson fixes up the flags before passing them linker. I'm no

Re: [PATCH] net/mlx5: fix crash when using meter in transfer flow

2025-07-16 Thread Dariusz Sosnowski
r confirming! > > Best regards, > Khadem Ullah No problem, happy to help. Best regards, Dariusz Sosnowski

[PATCH] app/testpmd: report minimum and maximum MTU

2025-07-16 Thread Dariusz Sosnowski
Add reporting of minimum and maximum allowed MTU on a given port to "show port info " command. Signed-off-by: Dariusz Sosnowski Acked-by: Viacheslav Ovsiienko --- This patch allowed simpler testing of mlx5 patch: https://patches.dpdk.org/project/dpdk/patch/20250716102546.1118749

[PATCH] net/mlx5: fix min and max MTU reporting

2025-07-16 Thread Dariusz Sosnowski
Fixes: e60fbd5b24fc ("mlx5: add device configure/start/stop") Cc: sta...@dpdk.org Signed-off-by: Dariusz Sosnowski Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/linux/mlx5_nl.c | 109 ++ drivers/common/mlx5/linux/mlx5_nl.h | 3 + drivers/net/

Re: [PATCH] doc: update parameters to use for mlx5 on Windows

2025-07-16 Thread Dariusz Sosnowski
On Tue, Jul 15, 2025 at 06:57:25AM -0700, Andre Muezerie wrote: > On Tue, Jul 15, 2025 at 02:03:45PM +0200, Dariusz Sosnowski wrote: *snip* > > Shouldn't clang linker parameters stay as it was previously i.e., "-L..."? > > Not on Windows. It can be confirmed by

[PATCH] net/mlx5: deprecate representor matching devarg

2025-07-16 Thread Dariusz Sosnowski
/events/slides/DPDK-2024-07-unified_representor.pdf should be developed. Signed-off-by: Dariusz Sosnowski --- doc/guides/nics/mlx5.rst | 4 doc/guides/rel_notes/deprecation.rst | 11 +++ 2 files changed, 15 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides

Re: [PATCH] net/mlx5: fix crash when using meter in transfer flow

2025-07-15 Thread Dariusz Sosnowski
On Tue, Jul 15, 2025 at 07:39:53PM +0200, Dariusz Sosnowski wrote: > + mlx5 maintainers > > Thank you for the patch. > > On Wed, Jul 02, 2025 at 08:36:17AM -0400, Khadem Ullah wrote: > > When creating a flow rule with the transfer attribute and a meter action, > >

Re: [PATCH] net/mlx5: fix crash when using meter in transfer flow

2025-07-15 Thread Dariusz Sosnowski
} > + } > /* >* If the device is not started yet, it is not allowed to created a >* flow from application. PMD default flows and traffic control flows > -- > 2.43.0 > Best regards, Dariusz Sosnowski

Re: [PATCH] doc/mlx5: document firmware requirement for flex item

2025-07-15 Thread Dariusz Sosnowski
r firmware (e.g. >= 24.38.1002) is required to support this > configuration. > > - Match on random value: > > -- > 2.43.0 > Best regards, Dariusz Sosnowski

Re: [PATCH] doc: update parameters to use for mlx5 on Windows

2025-07-15 Thread Dariusz Sosnowski
-LIBPATH:"%DEVX_LIB_PATH%" meson.exe setup -Denable_stdatomic=true ... The same applies to commands for clang. > + > +When compiling with Clang, use either:: > + > + meson.exe setup "-Dc_args=-I\"%DEVX_INC_PATH%\"" > + "-Dc_link_args=-Wl,-LIBPATH:\"%DEVX_LIB_PATH%\"" ... Shouldn't clang linker parameters stay as it was previously i.e., "-L..."? > + > +or:: > + > + set CFLAGS=-I"%DEVX_INC_PATH%" && set > LDFLAGS=-Wl,-LIBPATH:"%DEVX_LIB_PATH%" && > + meson.exe setup ... > > > .. _mlx5_common_env: Best regards, Dariusz Sosnowski

[PATCH] net/mlx5: fix indirect age action handling

2025-07-14 Thread Dariusz Sosnowski
ction with HWS") Cc: michae...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Dariusz Sosnowski Acked-by: Bing Zhao --- doc/guides/nics/mlx5.rst| 2 ++ drivers/net/mlx5/mlx5_flow_hw.c | 15 --- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/doc/guides

Re: [PATCH v3] net/mlx5: remove use of sizeof(rte_v128u32_t)

2025-07-09 Thread Dariusz Sosnowski
et descriptor > layout, not rte_v128u32_t. > > Since rte_mov16() is used in real code and rte_v128u32_t is only used to > carry over the length of the copy, this patch replaces instances of > sizeof(rte_v128u32_t) with a macro named MLX5_SIZE_MOV16 to better > reflect the real usag

[PATCH] net/mlx5: fix masked indirect age action validation

2025-07-01 Thread Dariusz Sosnowski
action. To prevent the segfault, this patch adds relevant validation to actions template creation and removes the debug assertion which now becomes redundant. Fixes: 04a4de756e14 ("net/mlx5: support flow age action with HWS") Cc: michae...@nvidia.com Cc: sta...@dpdk.org Signed-off-b

Re: [PATCH v2] net/mlx5: fix segfault on indirect action age query with conntrack

2025-06-26 Thread Dariusz Sosnowski
Thank you very much for changes and detailed descriptions. It helped a lot during review. Acked-by: Dariusz Sosnowski On Thu, Jun 26, 2025 at 09:07:02AM -0400, Khadem Ullah wrote: > v2: > - Added missing check for AGE + CT conflict in flow_dv_query(). > - Removed unnecessary null c

Re: [PATCH v2 2/2] net/mlx5: enhance log file path

2025-06-26 Thread Dariusz Sosnowski
work on Windows as well. (see https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/access-waccess?view=msvc-170) - Replace the opening of the file in mlx5_dump_debug_information() with mlx5_os_debug_dump_file_open(). Best regards, Dariusz Sosnowski On Wed, Jun 04, 2025 at 06:54

Re: [PATCH v2 1/2] net/mlx5: enhance socket file path

2025-06-26 Thread Dariusz Sosnowski
: dsosnow...@nvidia.com > Cc: step...@networkplumber.org > Cc: julien.meun...@nokia.com > > Signed-off-by: Yang Ming Acked-by: Dariusz Sosnowski Best regards, Dariusz Sosnowski

Re: [PATCH] net/mlx5: fix segfault on indirect action age query with conntrack

2025-06-26 Thread Dariusz Sosnowski
_error_set > + (error, EINVAL, > + RTE_FLOW_ERROR_TYPE_UNSPECIFIED, > + NULL, "cannot read age data"); > > age_param = &act->age_params; > } else if (flow->counter) { > -- > 2.43.0 > Best regards, Dariusz Sosnowski

Re: [PATCH] net/mlx5: fix transceiver warning when not exist

2025-06-26 Thread Dariusz Sosnowski
een "no transceiver" and "other I/O error". For this reason I would keep the log and keep it at warn level. > Also, I do not understand how my patch (not printing a log) makes a test fail > - I couldn't find that test in DPDK to verify. I'm not that familiar though.. > > Yogev *snip* Best regards, Dariusz Sosnowski

Re: [PATCH] common/mlx5: avoid warning about operation mixing different enum types

2025-06-05 Thread Dariusz Sosnowski
On Wed, Jun 04, 2025 at 08:18:58AM -0700, Andre Muezerie wrote: > On Wed, Jun 04, 2025 at 09:42:31AM +0200, Dariusz Sosnowski wrote: > > Hi, > > > > On Tue, Jun 03, 2025 at 06:41:24PM +0200, Dariusz Sosnowski wrote: > > > Hi, > > > > > > On Tue,

Re: [PATCH v2] common/mlx5: use intrinsics instead of inline assembly

2025-06-05 Thread Dariusz Sosnowski
On Thu, Jun 05, 2025 at 10:33:54AM +0200, Dariusz Sosnowski wrote: > Hi, > > On Wed, Jun 04, 2025 at 07:15:25AM -0700, Andre Muezerie wrote: > > When compiling with MSVC the errors below are hit because msvc does not > > support inline assembly: > > > &

Re: [PATCH v2] common/mlx5: use intrinsics instead of inline assembly

2025-06-05 Thread Dariusz Sosnowski
mlx5_txpp.c(510): error C2143: syntax error: > missing ';' before 'volatile' > > The fix for (1) is to use compiler intrinsic __cpuid and for (2) > intrinsic _InterlockedCompareExchange128 can be used. > > Signed-off-by: Andre Muezerie Thank you for applying the changes. Best regards, Dariusz Sosnowski

Re: [PATCH v2] net/mlx5: declare size of rte_v128u32_t

2025-06-04 Thread Dariusz Sosnowski
> /* Fill the gap in the title WQEBB with inline data. */ > rte_mov16(pdst, psrc); > - psrc += sizeof(rte_v128u32_t); > + psrc += MLX5_SIZEOF_V128U32_T; > } > pdst = (uint8_t *)(es + 2); > MLX5_ASSERT(inlen >= MLX5_ESEG_MIN_INLINE_SIZE); > -- > 2.49.0.vfs.0.3 > Best regards, Dariusz Sosnowski

Re: [PATCH v2] doc/guides: Mention needed kernel option for mlx5

2025-06-04 Thread Dariusz Sosnowski
gt; from properly working in multiport-eswitch mode. > > Fixes: 11c73de9ef63 ("net/mlx5: probe multi-port E-Switch device") > > v2: > - Added additional MLX5 kernel option > - Fixed patch formatting > - Added "Fixes" tag > > Signed-off-by: Jaromí

Re: [PATCH] net/mlx5: avoid setting kernel MTU if not needed

2025-06-04 Thread Dariusz Sosnowski
Hi Maxime, On Tue, Jun 03, 2025 at 07:56:11PM +0200, Dariusz Sosnowski wrote: > On Tue, Jun 03, 2025 at 07:53:45PM +0200, Dariusz Sosnowski wrote: > > Hi, > > > > On Wed, May 28, 2025 at 02:12:37PM +0200, David Marchand wrote: > > > Hello, > > > > &

Re: [PATCH] common/mlx5: avoid warning about operation mixing different enum types

2025-06-04 Thread Dariusz Sosnowski
Hi, On Tue, Jun 03, 2025 at 06:41:24PM +0200, Dariusz Sosnowski wrote: > Hi, > > On Tue, May 27, 2025 at 04:41:25PM -0700, Andre Muezerie wrote: > > When compiling with MSVC, warnings like the one below pop up: > > > > ../drivers/common/mlx5/mlx5_devx_cmds.c(55

Re: [PATCH] net/mlx5: avoid setting kernel MTU if not needed

2025-06-03 Thread Dariusz Sosnowski
On Tue, Jun 03, 2025 at 07:53:45PM +0200, Dariusz Sosnowski wrote: > Hi, > > On Wed, May 28, 2025 at 02:12:37PM +0200, David Marchand wrote: > > Hello, > > > > On Wed, May 28, 2025 at 11:36 AM Maxime Coquelin > > wrote: > > > > > > This pat

Re: [PATCH] net/mlx5: avoid setting kernel MTU if not needed

2025-06-03 Thread Dariusz Sosnowski
ata->mtu. I'll prepare a patch later which does that. Thanks for bringing that up. For posperity - this cached value is used only during rte_eth_rx_queue_setup() while validating shared RX queue configuration. Best regards, Dariusz Sosnowski

Re: [PATCH] common/mlx5: avoid warning about operation mixing different enum types

2025-06-03 Thread Dariusz Sosnowski
;'; use an explicit cast > to silence this warning > > The values in both enums indicate that this sort of mixed bit > manipulation is intentional, so this patch just uses an explicit > cast to avoid the warning. > > Signed-off-by: Andre Muezerie Acked-by: Dariusz Sosnowski Best regards, Dariusz Sosnowski

Re: [PATCH] net/mlx5: avoid implicit conversion to 64 bits

2025-06-03 Thread Dariusz Sosnowski
(was 64-bit shift intended?) > > Depending on the situation, the fix is to do a 64-bit shift, or > be explicit about the type conversion by adding a cast. > > Signed-off-by: Andre Muezerie Acked-by: Dariusz Sosnowski Best regards, Dariusz Sosnowski

Re: [PATCH] net/mlx5: use portable version of __builtin_ffsl

2025-06-03 Thread Dariusz Sosnowski
ndre Muezerie Acked-by: Dariusz Sosnowski Best regards, Dariusz Sosnowski

Re: [PATCH] common/mlx5: use intrinsics instead of inline assembly

2025-06-03 Thread Dariusz Sosnowski
_InterlockedCompareExchange128((int64_t volatile *)dst, src->val[1], src->val[0], (int64_t *)exp); > +} > +#else > static inline int > mlx5_atomic128_compare_exchange(rte_int128_t *dst, > rte_int128_t *exp, > @@ -510,6 +524,7 @@ mlx5_atomic128_compare_exchange(rte_int128_t *dst, > return res; > } > #endif > +#endif > > static inline void > mlx5_atomic_read_cqe(rte_int128_t *from, rte_int128_t *ts) Best regards, Dariusz Sosnowski

Re: [PATCH 1/1] net/mlx5: unresolved symbol mlx5_geneve_tlv_parser_create

2025-06-03 Thread Dariusz Sosnowski
systems. It also sorts the file names in meson.build in > alphabetical order. > > Signed-off-by: Andre Muezerie Acked-by: Dariusz Sosnowski Best regards, Dariusz Sosnowski

Re: [PATCH] net/mlx5: optimize counters ID greneration logic

2025-06-03 Thread Dariusz Sosnowski
e() function. > > Signed-off-by: Alexander Kozyrev Acked-by: Dariusz Sosnowski Best regards, Dariusz Sosnowski

Re: [PATCH] drivers/net/mlx5: fix mlx5 send packet failed

2025-06-03 Thread Dariusz Sosnowski
ount the possibility of cache line being 128B (https://github.com/DPDK/dpdk/blob/main/drivers/common/mlx5/mlx5_prm.h#L427) and this achieves the equivalent to the above diff. > if (unlikely(ret < 0)) { > /* >* Some error occurred on queue error > -- > 1.8.3.1 > Best regards, Dariusz Sosnowski

[PATCH] net/mlx5: fix flex tunnel validation

2025-04-30 Thread Dariusz Sosnowski
fixes the flex item validation, by correctly updating recognized items bitmask depending on flex item mode. Fixes: 80c676259a04 ("net/mlx5: validate HWS template items") Cc: getel...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Dariusz Sosnowski Acked-by: Viacheslav Ovsiienko --- d

[PATCH] net/mlx5: fix VLAN stripping on hairpin queues

2025-04-25 Thread Dariusz Sosnowski
fixes that. Fixes: e79c9be91515 ("net/mlx5: support Rx hairpin queues") Cc: sta...@dpdk.org Signed-off-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_devx.c | 2 ++ drivers/net/mlx5/mlx5_vlan.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx

[PATCH 2/2] net/mlx5: fix counter service thread init

2025-04-25 Thread Dariusz Sosnowski
k.org Signed-off-by: Dariusz Sosnowski Acked-by: Bing Zhao --- drivers/net/mlx5/mlx5_hws_cnt.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/mlx5_hws_cnt.c b/drivers/net/mlx5/mlx5_hws_cnt.c index fd12bcd7ec..5c7c0041aa 100644 --- a/drivers/net

[PATCH 1/2] net/mlx5: fix counter pool init error propagation

2025-04-25 Thread Dariusz Sosnowski
This patch addresses these cases, by propagating the rte_errno set by failing functions. Fixes: e1c83d295dd9 ("net/mlx5: support ASO actions with non-template flow") Cc: mkash...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Dariusz Sosnowski Acked-by: Bing Zhao --- drivers/net/mlx5

[PATCH 0/2] net/mlx5: flow counter pool fixes

2025-04-25 Thread Dariusz Sosnowski
This patch series includes several fixes for flow counter pool used with HW Steering flow engine. Dariusz Sosnowski (2): net/mlx5: fix counter pool init error propagation net/mlx5: fix counter service thread init drivers/net/mlx5/mlx5_hws_cnt.c | 29 +++-- 1 file

[PATCH] net/mlx5: validate GTP PSC QFI width

2025-04-25 Thread Dariusz Sosnowski
Add missing validation of GTP PSC QFI flow field width for modify field flow action. Fixes: 0f4aa72b99da ("net/mlx5: support flow modify field with HWS") Cc: suanmi...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Dariusz Sosnowski Acked-by: Bing Zhao --- drivers/net/mlx5/mlx5_flo

[PATCH] net/mlx5: fix modify field action on group 0

2025-04-25 Thread Dariusz Sosnowski
w modify field with HWS") Cc: suanmi...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Dariusz Sosnowski Acked-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow_hw.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/dri

Re: [PATCH v3] rust: support raw DPDK API

2025-04-05 Thread Dariusz Sosnowski
; +let mut name_buf: [c_char; RTE_ETH_NAME_MAX_LEN as usize] = > +[0 as c_char; RTE_ETH_NAME_MAX_LEN as usize]; > + let title = format!("{:<4}{:<32} {:<14}", "Port", "Name", "Driver"); > +println!("{title}"); > +ports.iter().for_each(|p| unsafe { > +let _rc = rte_eth_dev_get_name_by_port(p.port_id, > name_buf.as_mut_ptr()); > +let name = CStr::from_ptr(name_buf.as_ptr()); > +let drv = CStr::from_ptr(p.dev_info.driver_name); > +let summary = format!( > +"{:<4}{:<32} {:<14}", > +p.port_id, > +name.to_str().unwrap(), > +drv.to_str().unwrap() > +); > +println!("{summary}"); > +}); > +} > + > +fn main() { > +let mut argv: Vec<*mut c_char> = env::args() > +.map(|arg| CString::new(arg).unwrap().into_raw()) > +.collect(); > + > +let rc = unsafe { rte_eal_init(env::args().len() as c_int, > argv.as_mut_ptr()) }; > +if rc == -1 { > +unsafe { > +rte_eal_cleanup(); > +} > +} > + > +let mut ports: Vec = vec![]; > +unsafe { > +for port_id in > + > iter_rte_eth_dev().take(dpdk::raw::rte_build_config::RTE_MAX_ETHPORTS as > usize) > +{ > +let mut port = Port::new(port_id); > +port.init_port_config(); > +println!("init port {port_id}"); > +port.start_port(); > +ports.push(port); > +} > +} > + > +unsafe { > +show_ports_summary(&ports); > +} > + > +println!("Hello, world!"); > +} > diff --git a/meson_options.txt b/meson_options.txt > index e49b2fc089..d37b9ba1dc 100644 > --- a/meson_options.txt > +++ b/meson_options.txt > @@ -60,3 +60,5 @@ option('tests', type: 'boolean', value: true, description: > 'build unit tests') > option('use_hpet', type: 'boolean', value: false, description: > 'use HPET timer in EAL') > +option('enable_rust', type: 'boolean', value: false, description: > + 'enable RUST') > -- > 2.45.2 > Best regards, Dariusz Sosnowski

Re: [PATCH v3] rust: support raw DPDK API

2025-03-18 Thread Dariusz Sosnowski
On Tue, Mar 18, 2025 at 09:51:05AM +0100, Dariusz Sosnowski wrote: > > +use std::process::Command; > > + > > +pub fn main() { > > +let mut pkgconfig = Command::new("pkg-config"); > > + > > +match pkgconfig.args(["--l

RE: [PATCH 1/2] net/mlx5: improve socket file path

2025-03-14 Thread Dariusz Sosnowski
Hi, > From: Yang Ming > Sent: Wednesday, March 12, 2025 3:56 AM > To: Bruce Richardson ; Stephen Hemminger > > Cc: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; > Suanming Mou ; Matan Azrad > ; dev@dpdk.org > Subject: Re: [PATCH 1/2] net/

[PATCH] net/mlx5: fix NAT64 register selection

2025-03-12 Thread Dariusz Sosnowski
selected. Also, if not enough registers are available, PMD will not attempt to create NAT64 actions. Fixes: 7a26bfec06a4 ("net/mlx5: fetch available registers for NAT64") Cc: sta...@dpdk.org Signed-off-by: Dariusz Sosnowski Acked-by: Bing Zhao --- drivers/net/mlx5/mlx5.c

[PATCH v2] net/mlx5/hws: fix incorrect DV FT type convert

2025-03-07 Thread Dariusz Sosnowski
ction object") Cc: sta...@dpdk.org Signed-off-by: Alex Vesker Acked-by: Dariusz Sosnowski --- v2: * Rebase on top of v25.03-rc2 drivers/net/mlx5/hws/mlx5dr_action.c | 68 1 file changed, 58 insertions(+), 10 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5d

RE: [PATCH] doc/guides: Mention needed kernel option for mlx5 multiport e-switch

2025-03-06 Thread Dariusz Sosnowski
/nics/mlx5.rst > @@ -1713,7 +1713,7 @@ Supported HCAs: > > Supported mlx5 kernel modules versions: > > -- Upstream Linux - from version 6.3. > +- Upstream Linux - from version 6.3. with CONFIG_NET_TC_SKB_EXT enabled Could you also include CONFIG_MLX5_CLS_ACT option i

[PATCH] net/mlx5/hws: fix incorrect DV FT type convert

2025-03-05 Thread Dariusz Sosnowski
ction object") Cc: sta...@dpdk.org Signed-off-by: Alex Vesker Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/hws/mlx5dr_action.c | 68 1 file changed, 58 insertions(+), 10 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_action.c b/drivers/ne

[PATCH v3 1/3] net/mlx5/hws: support jump FDB Rx

2025-02-26 Thread Dariusz Sosnowski
instead of FT for dest table FDB Rx case. Signed-off-by: Suanming Mou Signed-off-by: Alex Vesker Acked-by: Dariusz Sosnowski --- drivers/common/mlx5/mlx5_prm.h| 9 - drivers/net/mlx5/hws/mlx5dr_action.c | 26 +- drivers/net/mlx5/hws/mlx5dr_action.h | 4

[PATCH v3 2/3] net/mlx5: add jump FDB Rx flag

2025-02-26 Thread Dariusz Sosnowski
From: Suanming Mou When jump FDB Rx is supported, flow will be able to jump from FDB Tx to FDB Rx, in that case the dest action in FDB Rx table should support FDB Tx as well. Signed-off-by: Suanming Mou Acked-by: Dariusz Sosnowski --- drivers/common/mlx5/mlx5_devx_cmds.c | 8

[PATCH v3 3/3] net/mlx5: allow FDB RSS

2025-02-26 Thread Dariusz Sosnowski
Acked-by: Dariusz Sosnowski --- doc/guides/nics/mlx5.rst| 4 drivers/net/mlx5/mlx5_flow.c| 4 ++-- drivers/net/mlx5/mlx5_flow_dv.c | 32 +--- drivers/net/mlx5/mlx5_flow_hw.c | 20 +++- 4 files changed, 38 insertions(+), 22 deletions

[PATCH v3 0/3] net/mlx5: support jump FDB Rx

2025-02-26 Thread Dariusz Sosnowski
Before FW introduced the JUMP_FDB_RX action feature, jump from FDB Tx to Rx is not allowed. JUMP_FDB_RX feature introduces the internal loopback for Tx case and allow the REG C0 C1 B be preserved as well. This series adds the jump from FDB Tx to FDB Rx support and allows RSS action in FDB domain r

RE: [PATCH V2 4/4] net/mlx5/hws: allow different types in miss validation

2025-02-26 Thread Dariusz Sosnowski
> -Original Message- > From: Ophir Munk > Sent: Wednesday, February 26, 2025 9:39 AM > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Suanming Mou ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH V2 4/4] net/mlx5

RE: [PATCH V2 3/4] net/mlx5: remove unneeded FDB flag on representor action

2025-02-26 Thread Dariusz Sosnowski
> -Original Message- > From: Ophir Munk > Sent: Wednesday, February 26, 2025 9:39 AM > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Suanming Mou ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh ; Jiawei(Jonny) > Wang > Su

RE: [PATCH V2 2/4] net/mlx5: support FDB unified domain

2025-02-26 Thread Dariusz Sosnowski
> -Original Message- > From: Ophir Munk > Sent: Wednesday, February 26, 2025 9:39 AM > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Suanming Mou ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH V2 2/4] net/mlx5:

RE: [PATCH V2 1/4] common/mlx5: support FDB unified capability query

2025-02-26 Thread Dariusz Sosnowski
> -Original Message- > From: Ophir Munk > Sent: Wednesday, February 26, 2025 9:39 AM > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Suanming Mou ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH V2 1/4] commo

RE: [PATCH] net/mlx5/hws: change error flow on matcher disconnect

2025-02-26 Thread Dariusz Sosnowski
t;M3 4. This > results in a segmentation fault as M1 is already freed > > Signed-off-by: Itamar Gozlan Acked-by: Dariusz Sosnowski Best regards, Dariusz Sosnowski

RE: [PATCH] net/mlx5: fix packet hardware ptype translation

2025-02-26 Thread Dariusz Sosnowski
> case was > not supported in the ptype translation table cause not reporting the ptype in > the > mbufs. > > Fixes: ea16068c0064 ("net/mlx5: fix L4 packet type support") > Cc: sta...@dpdk.org > > Signed-off-by: Viacheslav Ovsiienko Acked-by: Dariusz Sosnowski Best regards, Dariusz Sosnowski

RE: [PATCH 2/2] net/mlx5/hws: add DROP action to multi destination actions

2025-02-26 Thread Dariusz Sosnowski
ion to multi destination > actions > > External email: Use caution opening links or attachments > > > From: Tamar Mashiah > > Add DROP action to multi destination actions, set NOP destination type when > DROP is specified. > > cc: sta...@dpdk.org > > Signed-off

RE: [PATCH 1/2] net/mlx5: add DROP destination to mirror clone actions

2025-02-26 Thread Dariusz Sosnowski
to mirror clone actions > > External email: Use caution opening links or attachments > > > From: Tamar Mashiah > > Add DROP destination to mirror clone actions. > > cc: sta...@dpdk.org > > Signed-off-by: Tamar Mashiah Acked-by: Dariusz Sosnowski Best regards, Dariusz Sosnowski

RE: [PATCH] net/mlx5: support ESP in non-template RSS expansion

2025-02-26 Thread Dariusz Sosnowski
: Use caution opening links or attachments > > > Add support for the ESP protocol in non-template RSS expansion. > > Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski Best regards, Dariusz Sosnowski

RE: [PATCH] net/mlx5: add eCPRI support

2025-02-25 Thread Dariusz Sosnowski
> -Original Message- > From: Bing Zhao > Sent: Tuesday, February 25, 2025 17:03 > To: Slava Ovsiienko ; dev@dpdk.org; Raslan > Darawsheh > Cc: Ori Kam ; Dariusz Sosnowski ; > Suanming Mou ; Matan Azrad ; > Hamdan Agbariya > Subject: [PATCH] net/mlx5: add

RE: [PATCH V1 2/4] net/mlx5: support FDB unified domain

2025-02-25 Thread Dariusz Sosnowski
Nacked-by: Dariusz Sosnowski Please see below: > diff --git a/drivers/net/mlx5/linux/mlx5_os.c > b/drivers/net/mlx5/linux/mlx5_os.c > index 091f288..9410211 100644 > --- a/drivers/net/mlx5/linux/mlx5_os.c > +++ b/drivers/net/mlx5/linux/mlx5_os.c > @@ -1707,6 +1707,17 @@ mlx

RE: [PATCH V1 3/4] net/mlx5: remove unneeded FDB flag on representor action

2025-02-25 Thread Dariusz Sosnowski
> -Original Message- > From: Ophir Munk > Sent: Tuesday, February 25, 2025 13:02 > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Suanming Mou ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh ; Jiawei(Jonny) > Wang > Subject: [

RE: [PATCH V1 4/4] net/mlx5/hws: allow different types in miss validation

2025-02-25 Thread Dariusz Sosnowski
> -Original Message- > From: Ophir Munk > Sent: Tuesday, February 25, 2025 13:02 > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Suanming Mou ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH V1 4/4] net/mlx5/hw

RE: [PATCH V1 2/4] net/mlx5: support FDB unified domain

2025-02-25 Thread Dariusz Sosnowski
> -Original Message- > From: Ophir Munk > Sent: Tuesday, February 25, 2025 13:02 > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Suanming Mou ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH V1 2/4] net/mlx5:

RE: [PATCH V1 1/4] common/mlx5: support FDB unified capability query

2025-02-25 Thread Dariusz Sosnowski
> -Original Message- > From: Ophir Munk > Sent: Tuesday, February 25, 2025 13:02 > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Suanming Mou ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH V1 1/4] commo

[PATCH] net/mlx5: fix queue counter error check

2025-02-25 Thread Dariusz Sosnowski
Whenever queue counter allocation fails, the FW syndrome error should be checked to determine if maximum number of queue counters was reached. Fixes: f0c0731b6d40 ("net/mlx5: add counters for hairpin drop") Cc: shper...@nvidia.com Signed-off-by: Dariusz Sosnowski Acked-by:

RE: [PATCH v2] net/mlx5/hws: fix fragmented ptype match

2025-02-21 Thread Dariusz Sosnowski
> -Original Message- > From: Alexander Kozyrev > Sent: Thursday, December 19, 2024 17:06 > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava Ovsiienko > ; Dariusz Sosnowski ; Bing > Zhao ; Suanming Mou ; Michael > Baum > Subject: [PATCH v2] n

RE: [PATCH] net/mlx5: fix err message overwrite for actions translation

2025-02-20 Thread Dariusz Sosnowski
> -Original Message- > From: Junfeng Guo > Sent: Thursday, February 20, 2025 08:09 > To: dev@dpdk.org > Cc: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Suanming Mou ; Matan Azrad > ; Minggang(Gavin) Li ; Jiawei(Jonny) > Wang ; sta...@dpdk

RE: [PATCH] net/mlx5: fix leak in HWS flow counter action

2025-02-18 Thread Dariusz Sosnowski
> -Original Message- > From: David Marchand > Sent: Monday, January 27, 2025 11:54 > To: dev@dpdk.org > Cc: sta...@dpdk.org; Dariusz Sosnowski ; Slava > Ovsiienko ; Bing Zhao ; Ori Kam > ; Suanming Mou ; Matan Azrad > ; Jack Min > Subject: [PATCH] net/mlx5: f

RE: [PATCH] net/mlx5: fix flow null ops seg fault

2025-02-18 Thread Dariusz Sosnowski
> -Original Message- > From: Kevin Traynor > Sent: Friday, February 14, 2025 11:06 > To: dev@dpdk.org > Cc: Dariusz Sosnowski ; Maayan Kashani > ; Raslan Darawsheh ; Ori Kam > ; Kevin Traynor ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix flow null ops seg f

RE: [PATCH 2/2] app/testpmd: use flags from user if it is set

2025-02-18 Thread Dariusz Sosnowski
ing the same port 4789. > > It will be set to 0x8 if user does not specify the flags. > > Fixes: da118115d95c ("app/testpmd: support matching any VXLAN field") > Signed-off-by: Minggang Li(Gavin) Acked-by: Dariusz Sosnowski Best regards, Dariusz Sosnowski <>

RE: [PATCH 1/2] doc: fix mlx5 VXLAN matching limitations

2025-02-18 Thread Dariusz Sosnowski
> -Original Message- > From: Minggang(Gavin) Li > Sent: Tuesday, February 18, 2025 11:33 > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact-Thomas > Monjalon (EXTERNAL) ; Dariusz Sosnowski > ; Bing Zhao ; Suanming Mou > ; Alex Vesker ; rongwei l

RE: [PATCH] doc: document hash RSS limitations with CQE zipping

2025-01-10 Thread Dariusz Sosnowski
> -Original Message- > From: Alexander Kozyrev > Sent: Thursday, January 9, 2025 23:34 > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; Dariusz Sosnowski ; > Bing Zhao ; Suanming Mou > Subject: [PATCH] doc: document hash RSS limitations with CQE

RE: [PATCH v3] net/mlx5: fix RSS hash for non-RSS CQE zipping

2024-12-02 Thread Dariusz Sosnowski
> -Original Message- > From: Alexander Kozyrev > Sent: Saturday, November 30, 2024 01:39 > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad ; Dariusz > Sosnowski ; Bing Zhao ; > Suanming Mou > Subject: [PATCH v3] net

RE: [PATCH] net/mlx5: fix the unneeded stub table allocation

2024-11-26 Thread Dariusz Sosnowski
> -Original Message- > From: Bing Zhao > Sent: Tuesday, November 26, 2024 10:26 > To: Dariusz Sosnowski ; Slava Ovsiienko > ; dev@dpdk.org; Raslan Darawsheh > > Cc: Ori Kam ; Suanming Mou ; > Matan Azrad ; Maayan Kashani > > Subject: [PATCH] net/mlx

RE: [PATCH] net/mlx5: fix RSS hash for non-RSS CQE zipping

2024-11-21 Thread Dariusz Sosnowski
> -Original Message- > From: Alexander Kozyrev > Sent: Thursday, November 21, 2024 14:32 > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad ; Dariusz > Sosnowski ; Bing Zhao ; > Suanming Mou > Subject: [PATCH] net

RE: [PATCH v2 1/2] app/testpmd: fix flow update

2024-11-18 Thread Dariusz Sosnowski
> -Original Message- > From: Danylo Vodopianov > Sent: Monday, November 18, 2024 11:25 > To: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > aman.deep.si...@intel.com; yuying.zh...@intel.com; Ori Kam > ; mko-...@napatech.com; c...@napatech.com; Dariusz > Sosnowski ; sil-

RE: [PATCH v3 2/2] app/testpmd: fix aged flow destroy

2024-11-18 Thread Dariusz Sosnowski
> -Original Message- > From: Danylo Vodopianov > Sent: Monday, November 18, 2024 19:03 > To: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > aman.deep.si...@intel.com; yuying.zh...@intel.com; Ori Kam > ; mko-...@napatech.com; c...@napatech.com; Dariusz > Sosnowski ;

RE: [PATCH v3 1/2] app/testpmd: fix flow update

2024-11-18 Thread Dariusz Sosnowski
> -Original Message- > From: Danylo Vodopianov > Sent: Monday, November 18, 2024 19:03 > To: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > aman.deep.si...@intel.com; yuying.zh...@intel.com; Ori Kam > ; mko-...@napatech.com; c...@napatech.com; Dariusz > Sosnowski ; sil-

RE: [PATCH v2 2/2] app/testpmd: fix aged flow destroy

2024-11-18 Thread Dariusz Sosnowski
> -Original Message- > From: Danylo Vodopianov > Sent: Monday, November 18, 2024 12:26 > To: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > aman.deep.si...@intel.com; yuying.zh...@intel.com; Ori Kam > ; mko-...@napatech.com; c...@napatech.com; Dariusz > Sosnowski ; sil-

RE: [PATCH v2 1/2] app/testpmd: fix flow update

2024-11-18 Thread Dariusz Sosnowski
> -Original Message- > From: Danylo Vodopianov > Sent: Monday, November 18, 2024 12:26 > To: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > aman.deep.si...@intel.com; yuying.zh...@intel.com; Ori Kam > ; mko-...@napatech.com; c...@napatech.com; Dariusz > Sosnowski ; sil-

RE: [PATCH] net/mlx5: fix the leak of action data list

2024-11-18 Thread Dariusz Sosnowski
Hi, > -Original Message- > From: Bing Zhao > Sent: Monday, November 18, 2024 07:53 > To: Dariusz Sosnowski ; Slava Ovsiienko > ; dev@dpdk.org; Raslan Darawsheh > > Cc: Ori Kam ; Suanming Mou ; > Matan Azrad ; Maayan Kashani > > Subject: [PATCH] net/mlx

RE: [PATCH v2 0/2] Testpmd flow update/destroy fixes

2024-11-18 Thread Dariusz Sosnowski
It seems that you're not registered to stable mailing list. Could you please register on that list and try again? You can use this link to register: https://mails.dpdk.org/listinfo/stable > From: Danylo Vodopianov > Sent: Monday, November 18, 2024 11:48 > To: Dariusz Sosnowski

RE: [PATCH v2 0/2] Testpmd flow update/destroy fixes

2024-11-18 Thread Dariusz Sosnowski
Hi Danylo, Could you please resend the v2 of the patchset? I'm not sure why, but for some reason the patches are missing in patchwork. I also cannot find them on http://inbox.dpdk.org/dev/ Best regards, Dariusz Sosnowski > -Original Message- > From: Danylo Vodopianov >

RE: [PATCH v1 2/2] app/testpmd: fix flow destroy

2024-11-15 Thread Dariusz Sosnowski
estroy(port_id, 1, > - &ctx.pf->id, false)) > + &flow_id, > + false)) > total++; > break; > case ACTION_AGE_CONTEXT_TYPE_INDIRECT_ACTION: > -- > 2.43.5 Best regards, Dariusz Sosnowski

RE: [PATCH v1 1/2] app/testpmd: fix flow update

2024-11-15 Thread Dariusz Sosnowski
with new actions\n", >flow->id); > + > + uf->next = flow->next; > + uf->id = flow->id; Please copy user_id as well. > + uf->flow = flow->flow; > + *flow_list = uf; > + > + free(flow); > return 0; > } > printf("Failed to find flow %"PRIu32"\n", rule_id); > -- > 2.43.5 Best regards, Dariusz Sosnowski

RE: [PATCH v2 07/10] net/mlx5: add legacy unicast flow rules management

2024-11-08 Thread Dariusz Sosnowski
> -Original Message- > From: Ferruh Yigit > Sent: Friday, November 8, 2024 15:48 > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Suanming Mou ; Matan Azrad > > Cc: dev@dpdk.org > Subject: Re: [PATCH v2 07/10] net/mlx5: add legacy unic

[PATCH] net/mlx5: fix MAC address initialization

2024-11-08 Thread Dariusz Sosnowski
by converting it to array initialization. Fixes: cf99567fe566 ("net/mlx5: add legacy unicast flow rules management") Signed-off-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c

[PATCH 2/2] net/mlx5: fix counter query loop getting stuck

2024-10-30 Thread Dariusz Sosnowski
ter service thread. Fixes: 4d368e1da3a4 ("net/mlx5: support flow counter action for HWS") Cc: jack...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Dariusz Sosnowski Acked-by: Ori Kam --- doc/guides/nics/mlx5.rst| 71 + drivers/net/mlx5/mlx5_flow

[PATCH 0/2] net/mlx5: fix counter query loop getting stuck

2024-10-30 Thread Dariusz Sosnowski
t_rule_items(dev, table, items, pattern_template_index, &priv->hw_q[queue].pp); ``` Dariusz Sosnowski (2): net/mlx5: fix dangling pointer to params net/mlx5: fix counter query loop getting stuck doc/guides/nics/mlx5.rst| 71 + drivers/net/mlx5/mlx5.h

[PATCH 1/2] net/mlx5: fix dangling pointer to params

2024-10-30 Thread Dariusz Sosnowski
ttern_params for similar reasons. Fixes: 1d2744f5028d ("net/mlx5: remove flow action parameters from job") Fixes: 57fd15fa373d ("net/mlx5: remove flow pattern from job") Signed-off-by: Dariusz Sosnowski Acked-by: Ori Kam --- drivers/net/mlx5/mlx5.h | 28 ++

[PATCH 2/3] net/mlx5: fix mingw stubs link issue in flow destroy

2024-10-30 Thread Dariusz Sosnowski
is available in rdma-core, this patch removes the __rte_weak. mlx5_flow_hw_stubs.c was already included on required platforms by preceding commit. Fixes: 8ed3e0001d0d ("net/mlx5: support destroying unicast flow rules") Signed-off-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_

[PATCH 3/3] net/mlx5: fix stub for HWS context validation

2024-10-30 Thread Dariusz Sosnowski
Since weak symbols are not supported on MinGW, move mlx5_hw_ctx_validate() to dedicated stubs file. Fixes: f3b76d541a25 ("net/mlx5: validate HWS context in meter operations") Signed-off-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow.c | 7 --- driver

[PATCH 0/3] net/mlx5: fix mingw link issues

2024-10-30 Thread Dariusz Sosnowski
This patchset fixes link issues with MinGW which appear in next-net-mlx-main tree. It is based on commit 69461d18dfd5 ("net/mlx5/hws: fix TC to TOS fields mapping in NAT64"). Dariusz Sosnowski (3): net/mlx5: fix mingw stubs link issue in flow creation net/mlx5: fix mingw stubs lin

  1   2   3   4   5   >