Re: [PATCH] examples/multi_process: fix cleanup on exit

2025-07-09 Thread Burakov, Anatoly
On 7/8/2025 9:09 AM, Maayan Kashani wrote: Device was started but not stopped on exit signal. Added port stop and close on exit. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Maayan Kashani --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [PATCH v1 1/1] memory: handle invalid socket ID's when allocating

2025-06-27 Thread Burakov, Anatoly
On 6/27/2025 12:46 PM, Thomas Monjalon wrote: 27/06/2025 12:44, Thomas Monjalon: 20/06/2025 15:37, Bruce Richardson: On Fri, Jun 20, 2025 at 02:30:23PM +0100, Anatoly Burakov wrote: This issue was reported by static analysis. It is a false positive, because both `rte_socket_count` and `rte_soc

Re: [PATCH] eal: deprecate old coremask-based EAL parameters

2025-06-27 Thread Burakov, Anatoly
On 6/24/2025 3:41 PM, Bruce Richardson wrote: As the number of cores/cpus on platforms has increased over the years, the use of coremasks rather than core-lists for identifying DPDK cores has become more and more unwieldy. At this point, let's deprecate the coremask-based EAL parameters for futur

Re: [PATCH v5 2/3] eal: merge corelist and core mapping options

2025-06-27 Thread Burakov, Anatoly
On 5/27/2025 5:29 PM, Bruce Richardson wrote: The "-l" EAL parameter supported a subset of the features that were provided by the "--lcores" long option. There is no need to have two different options with different behaviour in this case, so we can just eliminate the special-case handling for "-

Re: [PATCH v5 1/3] eal: deprecate old coremask-based EAL parameters

2025-06-27 Thread Burakov, Anatoly
On 5/27/2025 5:29 PM, Bruce Richardson wrote: As the number of cores/cpus on platforms has increased over the years, the use of coremasks rather than core-lists for identifying DPDK cores has become more and more unwieldy. At this point, let's deprecate the coremask-based EAL parameters for futur

Re: [PATCH] net/ice: fix inconsistency in Rx queue VLAN tag placement

2025-06-27 Thread Burakov, Anatoly
On 6/27/2025 3:52 PM, Bruce Richardson wrote: When VLAN or QinQ stripping is enabled in the ice driver, an inconsistency was observed between the placement of the VLAN tag in the descriptors of the final Rx queue (irrespective of the number of queues) vs descriptors of all other queues. This inco

Re: [PATCH 2/2] doc: use core lists rather than masks in guides

2025-06-26 Thread Burakov, Anatoly
On 6/24/2025 3:34 PM, Bruce Richardson wrote: For the guides for applications and examples, use the "-l" flag rather than the "-c" flag to pass in core lists rather than core masks. While for the trivial examples given, core masks work fine and may be easier; in real-world cases, with potentially

Re: [PATCH 1/2] doc/eal: add doc entry for service core list flag

2025-06-26 Thread Burakov, Anatoly
On 6/24/2025 3:34 PM, Bruce Richardson wrote: In the list of EAL arguments, only the "-s" flag for service cores was documented. Add an entry for the "-S" one too, which takes a core list instead of a core mask. Signed-off-by: Bruce Richardson --- doc/guides/linux_gsg/eal_args.include.rst | 5

Re: [PATCH v2] eal: handle sysconf(_SC_PAGESIZE) negative return value

2025-06-13 Thread Burakov, Anatoly
On 6/12/2025 4:06 PM, Morten Brørup wrote: eal: handle sysconf(_SC_PAGESIZE) negative return value Coverity reports some defects, where the root cause seems to be negative return value from sysconf(_SC_PAGESIZE) not being handled. rte_mem_page_size() was updated to handle negative return value

Re: [PATCH v7 18/33] net/ixgbe: add a desc done function

2025-06-12 Thread Burakov, Anatoly
On 6/12/2025 1:11 PM, Anatoly Burakov wrote: Add a function to check DD bit status, and use it everywhere we do these checks. Signed-off-by: Anatoly Burakov --- Missed Bruce's ack from v5 and v6: Acked-by: Bruce Richardson -- Thanks, Anatoly

Re: [PATCH v1 1/2] net/e1000: better clock synchronization workaround

2025-06-12 Thread Burakov, Anatoly
On 6/9/2025 6:23 PM, Stephen Hemminger wrote: On Mon, 9 Jun 2025 11:16:41 +0100 Anatoly Burakov wrote: + ret_val = hw->phy.ops.write_reg_locked(hw, E1000_PHY_TIMEOUTS_REG, + phy_timeout); + + return ret_val; Why use temporary value (r

Re: [PATCH v5 32/34] net/intel: support wider x86 vectors for Rx rearm

2025-06-09 Thread Burakov, Anatoly
On 6/9/2025 1:54 PM, Bruce Richardson wrote: On Fri, Jun 06, 2025 at 06:17:07PM +0100, Anatoly Burakov wrote: Currently, for 32-byte descriptor format, only SSE instruction set is supported. Add implementation for AVX2 and AVX512 instruction sets. Since we are using Rx descriptor definitions fro

Re: [PATCH v5 19/34] net/ixgbe: add a desc done function

2025-06-09 Thread Burakov, Anatoly
On 6/6/2025 7:08 PM, Anatoly Burakov wrote: Add a function to check DD bit status, and use it everywhere we do these checks. Signed-off-by: Anatoly Burakov --- Notes: v5: - Add this commit drivers/net/intel/ixgbe/ixgbe_rxtx.c| 8 ++-- drivers/net/intel/ixgbe/ixgb

Re: [PATCH v4 23/25] net/intel: support wider x86 vectors for Rx rearm

2025-06-05 Thread Burakov, Anatoly
On 6/4/2025 4:59 PM, Bruce Richardson wrote: On Fri, May 30, 2025 at 02:57:19PM +0100, Anatoly Burakov wrote: Currently, for 32-byte descriptor format, only SSE instruction set is supported. Add implementation for AVX2 and AVX512 instruction sets. Since we are using Rx descriptor definitions fro

Re: [PATCH v4 22/25] net/ixgbe: use common Rx rearm code

2025-06-05 Thread Burakov, Anatoly
On 6/4/2025 11:40 AM, Bruce Richardson wrote: On Fri, May 30, 2025 at 02:57:18PM +0100, Anatoly Burakov wrote: The ixgbe driver has implementations of vectorized mbuf rearm code that is identical to the ones in the common code, so just use those. Since ixgbe Rx descriptors are always 16-byte wi

Re: [PATCH v3 03/10] net/ice/base: fix integer overflow issue

2025-06-02 Thread Burakov, Anatoly
On 5/27/2025 3:17 PM, Dhanya Pillai wrote: From: Lukasz Krakowiak Fix issue related to INTEGER_OVERFLOW. I would also suggest rewording the commit message. Even something like the following would be better: Fix integer overflow issue in power of 2 calculation. Fixes: f636f2888cec ("net/

Re: [PATCH v3 02/10] net/ice/base: fix typo in media type check

2025-06-02 Thread Burakov, Anatoly
On 5/27/2025 3:17 PM, Dhanya Pillai wrote: From: Paul Greenwalt Found a typo in original implementation of ice_set_media_type, where one of the checks for FIBER checks for C2C media type instead of C2M. This results in failure of this check for some AOC devices, consequently setting the media

Re: [PATCH v2 1/2] app/testpmd: harmonize case in help strings

2025-05-29 Thread Burakov, Anatoly
On 5/26/2025 4:52 PM, Stephen Hemminger wrote: On Fri, 23 May 2025 11:36:04 +0100 Anatoly Burakov wrote: Most testpmd help strings are lower case. Amend those that aren't. Signed-off-by: Anatoly Burakov Why does DPDK not follow the convention used for years by the Unix man pages and comman

Re: [PATCH v3 05/13] net/ice: use the common Rx queue structure

2025-05-23 Thread Burakov, Anatoly
On 5/14/2025 6:56 PM, Bruce Richardson wrote: On Mon, May 12, 2025 at 01:54:31PM +0100, Anatoly Burakov wrote: Make the ice driver use the new common Rx queue structure. Because the ice driver supports both 16-byte and 32-byte descriptor formats (controlled by RTE_LIBRTE_ICE_16BYTE_RX_DESC defi

Re: [PATCH v5 2/3] cmdline: add floating point support

2025-05-23 Thread Burakov, Anatoly
On 5/21/2025 4:05 PM, Stephen Hemminger wrote: On Wed, 7 May 2025 16:22:11 +0100 Anatoly Burakov wrote: +NUMERIC_TYPES = { +"UINT8": "uint8_t", +"UINT16": "uint16_t", +"UINT32": "uint32_t", +"UINT64": "uint64_t", +"INT8": "int8_t", +"INT16": "int16_t", +"INT32": "i

Re: [PATCH v1 2/2] app/testpmd: sort commands by help string

2025-05-23 Thread Burakov, Anatoly
On 5/22/2025 12:24 AM, Stephen Hemminger wrote: On Wed, 14 May 2025 14:02:12 +0100 Anatoly Burakov wrote: When using '?' to find commands, it occasionally is difficult to find the needed commands because all commands are not in alphabetical order, but rather can be ordered rather arbitrarily.

Re: [PATCH v5 2/3] cmdline: add floating point support

2025-05-21 Thread Burakov, Anatoly
On 5/20/2025 6:19 PM, Stephen Hemminger wrote: On Wed, 7 May 2025 16:22:11 +0100 Anatoly Burakov wrote: Add support for parsing floating point numbers in cmdline library, as well as unit tests for the new functionality. Use C library for parsing. Signed-off-by: Anatoly Burakov This looks

Re: [PATCH v2] eal/linux: skip vfio for non-privileged container

2025-05-16 Thread Burakov, Anatoly
On 3/27/2025 8:57 AM, Yang Ming wrote: DPDK detect vfio container according the existence of vfio module. But for container with non-privileged mode, there is possibility that no VFIO_DIR(/dev/vfio) mapping from host to container when host have both Intel NIC and Mellanox NIC but this conntainer

Re: [PATCH v1 1/2] app/testpmd: harmonize case in help strings

2025-05-15 Thread Burakov, Anatoly
On 5/14/2025 3:26 PM, Bruce Richardson wrote: On Wed, May 14, 2025 at 02:02:11PM +0100, Anatoly Burakov wrote: Most testpmd help strings are lower case. Amend those that aren't. Signed-off-by: Anatoly Burakov --- app/test-pmd/cmdline.c| 4 ++-- app/test-pmd/cmdline_tm.c | 36 ++

Re: [PATCH v3 01/13] net/ixgbe: remove unused field in Rx queue struct

2025-05-15 Thread Burakov, Anatoly
On 5/14/2025 6:32 PM, Bruce Richardson wrote: On Mon, May 12, 2025 at 01:54:27PM +0100, Anatoly Burakov wrote: The `rdh` (read head) field in the `ixgbe_rx_queue` struct is not used anywhere in the codebase, and can be removed. Signed-off-by: Anatoly Burakov With the one comment below fixed.

Re: [PATCH v3 06/13] net/iavf: use the common Rx queue structure

2025-05-15 Thread Burakov, Anatoly
On 5/15/2025 12:59 PM, Bruce Richardson wrote: On Mon, May 12, 2025 at 01:54:32PM +0100, Anatoly Burakov wrote: Make the iavf driver use the new common Rx queue structure. Because the iavf driver supports both 16-byte and 32-byte descriptor formats (controlled by RTE_LIBRTE_IAVF_16BYTE_RX_DESC

Re: [PATCH v3 04/13] net/i40e: use the common Rx queue structure

2025-05-15 Thread Burakov, Anatoly
On 5/14/2025 6:52 PM, Bruce Richardson wrote: On Mon, May 12, 2025 at 01:54:30PM +0100, Anatoly Burakov wrote: Make the i40e driver use the new common Rx queue structure. Because the i40e driver supports both 16-byte and 32-byte descriptor formats (controlled by RTE_LIBRTE_I40E_16BYTE_RX_DESC d

Re: [PATCH 1/4] bus/pci: Use force-noreplace flag when mapping PCI resources

2025-05-13 Thread Burakov, Anatoly
On 5/6/2025 7:40 PM, Jake Freeland wrote: When mapping PCI resources in secondary processes, use the RTE_MAP_FORCE_ADDRESS_NOREPLACE flag to indicate that the mapping must be made at the provided address. Without this flag, the kernel might return a different address for the mapping, even if the

Re: [PATCH] net/ice: update log message

2025-05-09 Thread Burakov, Anatoly
On 5/2/2025 5:25 PM, Pillai, Dhanya R wrote: Added log message for ddp package load failure. Judging by the code, the log message already existed, so technically it's not "adding" anything. IMO a better wording would be: "Clarified log message for DDP package load failure". mailmap: updat

Re: [PATCH v9 1/3] cmdline: use C standard library as number parser

2025-05-09 Thread Burakov, Anatoly
On 5/9/2025 3:39 PM, Anatoly Burakov wrote: Remove custom number parser and use C standard library instead. In order to keep compatibility with earlier versions of the parser, we have to take into account a couple of quirks: - We did not consider "negative" numbers to be valid for anything other

Re: [PATCH v8 1/3] cmdline: use C standard library as number parser

2025-05-09 Thread Burakov, Anatoly
On 5/9/2025 3:08 PM, Burakov, Anatoly wrote: On 5/9/2025 3:02 PM, Burakov, Anatoly wrote: On 5/8/2025 3:16 PM, Anatoly Burakov wrote: Remove custom number parser and use C standard library instead. In order to keep compatibility with earlier versions of the parser, we have to take into

Re: [PATCH v8 1/3] cmdline: use C standard library as number parser

2025-05-09 Thread Burakov, Anatoly
On 5/9/2025 3:02 PM, Burakov, Anatoly wrote: On 5/8/2025 3:16 PM, Anatoly Burakov wrote: Remove custom number parser and use C standard library instead. In order to keep compatibility with earlier versions of the parser, we have to take into account a couple of quirks: - We did not consider

Re: [PATCH v8 1/3] cmdline: use C standard library as number parser

2025-05-09 Thread Burakov, Anatoly
On 5/8/2025 3:16 PM, Anatoly Burakov wrote: Remove custom number parser and use C standard library instead. In order to keep compatibility with earlier versions of the parser, we have to take into account a couple of quirks: - We did not consider "negative" numbers to be valid for anything other

Re: [PATCH 2/4] bus/pci/bsd: Map resources at EAL baseaddr

2025-05-08 Thread Burakov, Anatoly
On 5/6/2025 7:40 PM, Jake Freeland wrote: Provide the EAL base address as a hint to mmap(2), so device resources are not mapped where malloc(3) et al. make allocations. This makes mapping conflicts less likely for secondary processes that make memory allocations before initializing EAL. Signed-

Re: [PATCH v2] mem: fix infinite loop

2025-05-08 Thread Burakov, Anatoly
On 4/3/2025 4:57 AM, Dengdui Huang wrote: When the process address space is insufficient, mmap will fail, which will cause an infinite loop. This patch stops attempting mmap if it fails and the requested size cannot be reduced. Fixes: b7cc54187ea4 ("mem: move virtual area function in common dire

Re: [PATCH 1/4] bus/pci: Use force-noreplace flag when mapping PCI resources

2025-05-08 Thread Burakov, Anatoly
On 5/6/2025 7:40 PM, Jake Freeland wrote: When mapping PCI resources in secondary processes, use the RTE_MAP_FORCE_ADDRESS_NOREPLACE flag to indicate that the mapping must be made at the provided address. Without this flag, the kernel might return a different address for the mapping, even if the

Re: [PATCH 2/3] eal/freebsd: Do not index out of bounds in memseg list

2025-05-08 Thread Burakov, Anatoly
On 5/6/2025 7:50 PM, Jake Freeland wrote: It is possible for rte_fbarray_find_next_n_free() to misreport that there are n contiguous open spots. If we need two contiguous entries for a hole, make sure that we're not indexing out-of-bounds in the fbarray. The `arr->len - arr->count < n` condition

Re: [PATCH 4/4] bus/pci/bsd: Fix device existence check

2025-05-08 Thread Burakov, Anatoly
On 5/6/2025 7:40 PM, Jake Freeland wrote: Use open(2) instead of access(2) to check for the existence of the target device. This avoids a possible race condition where the the device file is removed after a successful call to access(2) but before open(2). This also fixes any potential bugs assoc

Re: [PATCH 3/4] bus/pci/bsd: Eliminate potential overflow

2025-05-08 Thread Burakov, Anatoly
On 5/6/2025 7:40 PM, Jake Freeland wrote: When calling rte_pci_write_config(), use memcpy(3) to copy @len bytes of @buf into local memory instead of casting it to a uint32_t pointer and dereferencing it. This prevents us from reading data outside of @buf in the case that @buf has a length less th

Re: [PATCH] eal: warn if no lcore is available

2025-05-08 Thread Burakov, Anatoly
On 5/8/2025 7:19 AM, David Marchand wrote: On systems with more cpu than RTE_MAX_LCORE, starting DPDK with cores >= RTE_MAX_LCORE ends up with an ambiguous error log. Example with RTE_MAX_LCORE=8: $ taskset -c 8 ./build/app/dpdk-testpmd EAL: Detected CPU lcores: 8 EAL: Detected NUMA nodes: 1 EAL

Re: [PATCH 1/3] eal/freebsd: Do not use prev_ms_idx for hole detection

2025-05-08 Thread Burakov, Anatoly
On 5/6/2025 7:50 PM, Jake Freeland wrote: Use rte_fbarray_is_used() to check if the previous fbarray entry is already empty. Using prev_ms_idx to do this is flawed in cases where we loop through multiple memseg lists. Each memseg list has its own count and length, so using a prev_ms_idx from one

Re: [PATCH 1/3] eal/freebsd: Do not use prev_ms_idx for hole detection

2025-05-08 Thread Burakov, Anatoly
On 5/6/2025 7:50 PM, Jake Freeland wrote: Use rte_fbarray_is_used() to check if the previous fbarray entry is already empty. Using prev_ms_idx to do this is flawed in cases where we loop through multiple memseg lists. Each memseg list has its own count and length, so using a prev_ms_idx from one

Re: [PATCH v7 2/3] cmdline: add floating point support

2025-05-08 Thread Burakov, Anatoly
On 5/8/2025 12:01 PM, Anatoly Burakov wrote: Add support for parsing floating point numbers in cmdline library, as well as unit tests for the new functionality. Use C library for parsing. Signed-off-by: Anatoly Burakov --- Notes: v6 -> v7: - Fixed a bug in float compare in unit tests where a

Re: [PATCH v5 1/3] cmdline: use C standard library as number parser

2025-05-08 Thread Burakov, Anatoly
On 5/8/2025 9:27 AM, Bruce Richardson wrote: On Wed, May 07, 2025 at 04:22:10PM +0100, Anatoly Burakov wrote: Remove custom number parser and use C standard library instead. In order to keep compatibility with earlier versions of the parser, we have to take into account a few quirks: - We do no

Re: [PATCH v4 1/2] cmdline: add floating point support

2025-05-07 Thread Burakov, Anatoly
On 5/7/2025 12:35 PM, Konstantin Ananyev wrote: Add support for parsing floating point numbers in cmdline library, as well as unit tests for the new functionality. The parser supports single and double precision floats, and will understand decimal fractions as well as scientific notation. Th

Re: [PATCH v4 1/2] cmdline: add floating point support

2025-05-07 Thread Burakov, Anatoly
On 5/7/2025 2:24 PM, Konstantin Ananyev wrote: -Original Message- From: Burakov, Anatoly Sent: Wednesday, May 7, 2025 12:07 PM To: Konstantin Ananyev ; dev@dpdk.org Subject: Re: [PATCH v4 1/2] cmdline: add floating point support On 5/7/2025 12:35 PM, Konstantin Ananyev wrote

Re: [PATCH v3 1/2] cmdline: add floating point support

2025-05-07 Thread Burakov, Anatoly
On 5/7/2025 11:50 AM, Anatoly Burakov wrote: Add support for parsing floating point numbers in cmdline library, as well as unit tests for the new functionality. The parser supports single and double precision floats, and will understand decimal fractions as well as scientific notation. Signed-of

Re: [PATCH v2 1/2] cmdline: add floating point support

2025-05-07 Thread Burakov, Anatoly
On 5/6/2025 3:38 PM, Bruce Richardson wrote: On Tue, May 06, 2025 at 02:08:18PM +0100, Anatoly Burakov wrote: Add support for parsing floating point numbers in cmdline library, as well as unit tests for the new functionality. The parser supports single and double precision floats, and will under

Re: [PATCH v1 1/1] app/testpmd: add sleep command

2025-05-06 Thread Burakov, Anatoly
On 5/2/2025 5:42 PM, Stephen Hemminger wrote: On Fri, 2 May 2025 13:27:29 +0100 Anatoly Burakov wrote: @@ -13701,6 +13735,7 @@ static cmdline_parse_ctx_t builtin_ctx[] = { &cmd_help_brief, &cmd_help_long, &cmd_quit, + &cmd_sleep, &cmd_load_from_file,

Re: [PATCH v1 1/1] app/testpmd: add sleep command

2025-05-02 Thread Burakov, Anatoly
On 5/2/2025 2:37 PM, Bruce Richardson wrote: On Fri, May 02, 2025 at 01:27:29PM +0100, Anatoly Burakov wrote: Test-pmd already has a way to run a list of commands from file, but there is no way to pause execution for a specified amount of time between two commands. This may be necessary for simp

Re: [PATCH v4 3/9] net/ixgbe/base: correct definition of macro

2025-03-28 Thread Burakov, Anatoly
On 3/28/2025 12:16 PM, Bruce Richardson wrote: The definition of IXGBE_LE32_TO_CPUS macro is meant to modify the value in place - similar to the le32_to_cpus() macro in kernel. Fixing the definition allows us to remove some warning flags, and removes the need for the uintptr_t typecasts. Fixes:

Re: [PATCH v4 9/9] net/intel: simplify base code builds

2025-03-28 Thread Burakov, Anatoly
On 3/28/2025 12:16 PM, Bruce Richardson wrote: Now that base-code warning flags have been removed from a number of drivers, we can simplify their build configuration by just including the base code files in the regular list of driver files passed back. There is no need to use pre-compiled objects

Re: [PATCH v4 8/9] net/ice/base: reduce warnings for unused variables

2025-03-28 Thread Burakov, Anatoly
On 3/28/2025 12:16 PM, Bruce Richardson wrote: Improve base code macros to reduce the number of issues with unused variables in the code. Issues still remain with unused-but-set variables, but completely unused variable warnings are eliminated. Signed-off-by: Bruce Richardson --- Acked-by: Ana

Re: [PATCH v4 6/9] net/i40e/base: fix unused value warnings

2025-03-28 Thread Burakov, Anatoly
On 3/28/2025 12:16 PM, Bruce Richardson wrote: Fix warnings about unused values - parameters, variables, etc., and remove the warning disable flags for them. Although modifying the base-code files is not ideal, the changes required are minor, and only affect two files from the imported base code.

Re: [PATCH v4 7/9] net/i40e/base: fix compiler warnings

2025-03-28 Thread Burakov, Anatoly
On 3/28/2025 12:16 PM, Bruce Richardson wrote: Add a single-line fix to the base code, and then the remaining two compiler warning disable flags can be removed from the driver base code build file. Fixes: 8db9e2a1b232 ("i40e: base driver") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --

Re: [PATCH v4 5/9] net/ixgbe/base: fix lock checker errors

2025-03-28 Thread Burakov, Anatoly
On 3/28/2025 12:16 PM, Bruce Richardson wrote: When building on FreeBSD, errors are reported in the base code by the lock checker (-Wthread-safety). For example: ../drivers/net/intel/ixgbe/base/ixgbe_osdep.c:42:1: error: mutex 'lock->mutex' is still held at the end of function [-Werror,-Wthread

Re: [PATCH v4 4/9] net/ixgbe/base: fix compilation warnings

2025-03-28 Thread Burakov, Anatoly
On 3/28/2025 12:16 PM, Bruce Richardson wrote: We can remove almost all of the "unused parameter" and "unused variable" warnings by just improving the macro definitions in the osdep.h header. Remaining two instances can be fixed by just one-line additions to the code, so add those to give us a cl

Re: [PATCH v4 2/9] net/iavf/base: remove unused meson.build file

2025-03-28 Thread Burakov, Anatoly
On 3/28/2025 12:16 PM, Bruce Richardson wrote: The meson.build file in the base folder was never used, as the base files were just included in the main sources list for iavf. Fixes: f1fdc9ddba5e ("drivers: move iavf common folder to iavf net") Signed-off-by: Bruce Richardson --- Acked-by: Ana

Re: [PATCH v4 1/9] net/fm10k/base: fix compilation warnings

2025-03-28 Thread Burakov, Anatoly
On 3/28/2025 12:16 PM, Bruce Richardson wrote: The fixes required to re-enable warnings in the fm10k base code are trivial, so let's make the changes and get a clean compile without any warning disable flags. * provide definitions for the UNREFERENCED_PARAMETER macros * fix the spelling of the w

Re: [PATCH] net/ice: fix incorrect mbuf cleanup function

2025-02-24 Thread Burakov, Anatoly
On 21/02/2025 17:04, Bruce Richardson wrote: The mbuf cleanup function is not being called correctly on close of the driver, due to the vector_tx flag not being set correctly on each Tx queue. Normally, this causes no visible problems, because the default is to have the vector flag unset, which m

Re: [PATCH] power: use hugepage memory for queue list entry structure

2025-02-21 Thread Burakov, Anatoly
On 20/02/2025 17:45, Stephen Hemminger wrote: On Thu, 20 Feb 2025 16:39:52 + Konstantin Ananyev wrote: -Original Message- From: Stephen Hemminger Sent: Thursday, February 20, 2025 4:12 PM To: lihuisong (C) Cc: dev@dpdk.org; tho...@monjalon.net; david.h...@intel.com; anatoly.bura

Re: [PATCH v8 05/17] eal: add new secure free function

2025-02-20 Thread Burakov, Anatoly
On 16/02/2025 17:53, Stephen Hemminger wrote: Although internally rte_free does poison the buffer in most cases, it is useful to have function that explicitly does this to avoid any security issues. Name of new API is chosen to be similar to Linux kernel kfree_sensitive() to make porting drivers

Re: [PATCH v8 06/17] app/test: use unit test runner for malloc tests

2025-02-20 Thread Burakov, Anatoly
On 16/02/2025 17:53, Stephen Hemminger wrote: There are several malloc tests and switching to the table driven unit test runner improves readability and makes adding new tests easier. Signed-off-by: Stephen Hemminger --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [PATCH v2] doc: reword sample application guides

2025-02-20 Thread Burakov, Anatoly
On 17/02/2025 0:09, Nandini Persad wrote: I have revised these sections to suit the template, but also, for punctuation, clarity, and removing repetition when necessary. Signed-off-by: Nandini Persad --- I wonder if this should be split up into individual guides' updates for easier review?

Re: [PATCH v3 0/2] Rewrite devbind

2025-02-18 Thread Burakov, Anatoly
On 04/12/2024 10:47, Anatoly Burakov wrote: It has been suggested [1] that a major cleanup/rewrite of devbind would be beneficial in terms of long term maintainability of the code. I was in a coding mood over the weekend, and so I've went ahead and rewritten devbind. Note that this is one giant

Re: [PATCH v1 1/1] usertools/devbind: add documentation for no-IOMMU mode

2025-02-18 Thread Burakov, Anatoly
On 02/12/2024 10:35, Anatoly Burakov wrote: Support for `--noiommu-mode` flag was added, but documentation for it was not. Add documentation for the flag. Signed-off-by: Anatoly Burakov --- doc/guides/tools/devbind.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/tools

Re: [PATCH v3 07/36] net/e1000: add support for more I219 devices

2025-02-07 Thread Burakov, Anatoly
On 07/02/2025 14:04, Bruce Richardson wrote: On Fri, Feb 07, 2025 at 12:44:59PM +, Anatoly Burakov wrote: From: Vitaly Lifshits Add support for new hardware ID's from the I219 series. Signed-off-by: Vitaly Lifshits Signed-off-by: Anatoly Burakov --- Should i219 be added to the base co

Re: [PATCH v1 00/42] Merge Intel IGC and E1000 drivers, and update E1000 base code

2025-02-04 Thread Burakov, Anatoly
On 03/02/2025 9:18, David Marchand wrote: Hello Anatoly, On Fri, Jan 31, 2025 at 1:59 PM Anatoly Burakov wrote: Intel IGC and E1000 drivers are distinct, but they are actually generated from the same base code. This patchset will merge together all e1000-derived drivers into one common base,

Re: [PATCH v2 1/5] eal: check lcore variable handle

2024-12-18 Thread Burakov, Anatoly
On 12/17/2024 9:59 AM, David Marchand wrote: Add an assert to double check the passed handle is not NULL, as it points at an initialisation/allocation issue prior to accessing this lcore variable. Signed-off-by: David Marchand --- lib/eal/include/rte_lcore_var.h | 2 ++ 1 file changed, 2 ins

Re: [PATCH v2 5/5] eal/x86: defer power intrinsics variable allocation

2024-12-18 Thread Burakov, Anatoly
On 12/17/2024 9:59 AM, David Marchand wrote: The lcore variable in this code unit is only used through rte_power_monitor*() public symbols. Defer the unconditional lcore variable allocation in those symbols. Fixes: 18b5049ab4fe ("eal/x86: keep power intrinsics state in lcore variable") Cc: sta.

Re: [PATCH v2 3/5] power: defer lcore variable allocation

2024-12-18 Thread Burakov, Anatoly
On 12/17/2024 9:59 AM, David Marchand wrote: The lcore variable in this code unit is only used through rte_power_ethdev_pmgmt_queue_*() public symbols. Defer the unconditional lcore variable allocation in those symbols. Fixes: 130643319579 ("power: keep per-lcore state in lcore variable") Cc: s

Re: [PATCH v2 4/5] power: reduce memory footprint of per-lcore state

2024-12-18 Thread Burakov, Anatoly
On 12/17/2024 9:59 AM, David Marchand wrote: Now that the per-lcore state was moved into a lcore variable, there is no reason to align a per-lcore state on a cache line to avoid false sharing. Remove this alignment and save a few bytes. Fixes: 130643319579 ("power: keep per-lcore state in lcore

Re: [PATCH 0/3] Defer lcore variables allocation

2024-12-16 Thread Burakov, Anatoly
On 12/10/2024 10:41 AM, Mattias Rönnblom wrote: Maybe the DAG is available on the build (meson) level, and thus the code can be generated out of that? There is in fact a patchset that produces just that kind of graph: https://patches.dpdk.org/project/dpdk/list/?series=34055 It's currentl

Re: [PATCH 0/3] Defer lcore variables allocation

2024-12-16 Thread Burakov, Anatoly
On 12/5/2024 6:57 PM, David Marchand wrote: As I had reported in rc2, the lcore variables allocation have a noticeable impact on applications consuming DPDK, even when such applications does not use DPDK, or use features associated to some lcore variables. While the amount has been reduced in a

Re: [PATCH 1/3] random: defer seeding to EAL init

2024-12-16 Thread Burakov, Anatoly
On 12/5/2024 6:57 PM, David Marchand wrote: The RNG is documented as being seeded as part of EAL init. /** * Seed the pseudo-random generator. * * The generator is automatically seeded by the EAL init with a timer * value. It may need to be re-seeded by the user with a real random * va

Re: [PATCH v1 1/4] net/e1000: prevent crashes in secondary processes

2024-12-13 Thread Burakov, Anatoly
On 12/12/2024 7:02 PM, Stephen Hemminger wrote: On Thu, 12 Dec 2024 16:19:03 + Anatoly Burakov wrote: Currently, the architecture of the base driver is such that it uses function pointers internally. These are not guaranteed to be valid in secondary processes, which can lead to crashes. Th

Re: [PATCH v1 1/1] usertools/devbind: add documentation for no-IOMMU mode

2024-12-04 Thread Burakov, Anatoly
On 12/2/2024 10:35 AM, Anatoly Burakov wrote: Support for `--noiommu-mode` flag was added, but documentation for it was not. Add documentation for the flag. Signed-off-by: Anatoly Burakov --- This update is also included in my devbind rewrite: https://patches.dpdk.org/project/dpdk/list/?seri

Re: [PATCH v4 1/1] usertools/devbind: allow changing UID/GID for VFIO

2024-12-04 Thread Burakov, Anatoly
On 12/2/2024 10:31 AM, Anatoly Burakov wrote: Currently, when binding a device to VFIO, the UID/GID for the device will always stay as system default (`root`). Yet, when running DPDK as non-root user, one has to change the UID/GID of the device to match the user's UID/GID to use the device. This

Re: [PATCH v3 0/1] Rewrite devbind

2024-12-04 Thread Burakov, Anatoly
On 12/4/2024 10:45 AM, Anatoly Burakov wrote: It has been suggested [1] that a major cleanup/rewrite of devbind would be beneficial in terms of long term maintainability of the code. I was in a coding mood over the weekend, and so I've went ahead and rewritten devbind. Note that this is one gian

Re: [PATCH v2 1/2] usertools/devbind: update coding style

2024-12-04 Thread Burakov, Anatoly
On 12/3/2024 11:16 PM, Stephen Hemminger wrote: On Tue, 3 Dec 2024 11:25:00 + Anatoly Burakov wrote: Devbind is one of the oldest tools in DPDK, and is written in a way that uses a lot of string matching, no type safety, lots of global variables, and has a few inconsistencies in the way i

Re: [PATCH v2 1/2] usertools/devbind: update coding style

2024-12-04 Thread Burakov, Anatoly
On 12/3/2024 6:07 PM, Stephen Hemminger wrote: On Tue, 3 Dec 2024 11:25:00 + Anatoly Burakov wrote: + +def check_installed(program: str, package: str) -> None: +"""Check if a program is installed.""" +if subprocess.call( +["which", program], stdout=subprocess.DEVNULL, std

Re: [PATCH v1 1/1] usertools/devbind: update coding style

2024-12-03 Thread Burakov, Anatoly
On 12/2/2024 6:01 PM, Stephen Hemminger wrote: On Mon, 2 Dec 2024 15:09:34 + Anatoly Burakov wrote: +# For kernels < 3.15 when binding devices to a generic driver (i.e. one that doesn't have a PCI +# ID table) using new_id, some devices that are not bound to any other driver cou

Re: [PATCH v1 0/1] Rewrite devbind

2024-12-03 Thread Burakov, Anatoly
On 12/2/2024 5:14 PM, Bruce Richardson wrote: On Mon, Dec 02, 2024 at 03:09:33PM +, Anatoly Burakov wrote: It has been suggested [1] that a major cleanup/rewrite of devbind would be beneficial in terms of long term maintainability of the code. I was in a coding mood over the weekend, and so

Re: [PATCH v4 1/1] usertools/devbind: allow changing UID/GID for VFIO

2024-12-02 Thread Burakov, Anatoly
On 12/2/2024 10:31 AM, Anatoly Burakov wrote: Currently, when binding a device to VFIO, the UID/GID for the device will always stay as system default (`root`). Yet, when running DPDK as non-root user, one has to change the UID/GID of the device to match the user's UID/GID to use the device. This

Re: [PATCH v1 1/1] usertools/devbind: fix NUMA node display

2024-11-29 Thread Burakov, Anatoly
On 11/29/2024 10:12 AM, Burakov, Anatoly wrote: On 11/28/2024 6:20 PM, Stephen Hemminger wrote: On Thu, 28 Nov 2024 16:08:55 + Anatoly Burakov wrote: +    # occasionally, system may report NUMA support but lspci will not, so we +    # want to go through all devices and see if any of them

Re: [PATCH v1 1/1] usertools/devbind: fix NUMA node display

2024-11-29 Thread Burakov, Anatoly
On 11/28/2024 6:20 PM, Stephen Hemminger wrote: On Thu, 28 Nov 2024 16:08:55 + Anatoly Burakov wrote: +# occasionally, system may report NUMA support but lspci will not, so we +# want to go through all devices and see if any of them do not have NUMANode +# property - this will

Re: [PATCH v5 6/8] build: reduce driver dependencies

2024-11-27 Thread Burakov, Anatoly
On 11/27/2024 3:56 PM, Anatoly Burakov wrote: From: Bruce Richardson Remove any unnecessary dependencies from the driver dependency lists. This will give each driver a near-minimum set of required dependencies. Signed-off-by: Bruce Richardson Reviewed-by: Rosen Xu --- diff --git a/driver

Re: [PATCH v2 1/1] usertools/devbind: allow changing UID/GID for VFIO

2024-11-27 Thread Burakov, Anatoly
On 11/26/2024 5:15 PM, Robin Jarry wrote: Hi Anatoly, Anatoly Burakov, Nov 26, 2024 at 16:02: Currently, when binding a device to VFIO, the UID/GID for the device will always stay as system default (`root`). Yet, when running DPDK as non- root user, one has to change the UID/GID of the device

Re: [PATCH v4 0/8] Record and rework component dependencies

2024-11-26 Thread Burakov, Anatoly
On 11/26/2024 3:39 PM, Anatoly Burakov wrote: As part of the meson build, we can record the dependencies for each component as we process it, logging them to a file. This file can be used as input to a number of other scripts and tools, for example, to graph the dependencies, or to allow higher-l

Re: [PATCH v6 10/20] net/ixgbe: remove use of VLAs

2024-11-11 Thread Burakov, Anatoly
On 09/11/2024 02:48, Andre Muezerie wrote: From: Konstantin Ananyev 1) ../drivers/net/ixgbe/ixgbe_ethdev.c:3556:46: warning: variable length array used [-Wvla] 2) ../drivers/net/ixgbe/ixgbe_ethdev.c:3739:23: warning: variable length array used [-Wvla] 3) ../drivers/net/ixgbe/ixgbe_rxt

Re: [PATCH v6 11/20] net/ice: remove use of VLAs

2024-11-11 Thread Burakov, Anatoly
On 09/11/2024 02:48, Andre Muezerie wrote: From: Konstantin Ananyev ../drivers/net/ice/ice_rxtx.c:1871:29: warning: variable length array used [-Wvla] Here VLA is used as a temp array for mbufs that will be used as a split RX data buffers. As at any given time only one thread can do RX fr

Re: [PATCH v4 17/17] eal: add function attributes for allocation functions

2024-10-02 Thread Burakov, Anatoly
On 10/1/2024 5:25 PM, Stephen Hemminger wrote: On Tue, 1 Oct 2024 14:25:46 +0200 David Marchand wrote: On Tue, Oct 1, 2024 at 2:21 PM Burakov, Anatoly wrote: + +/** + * Frees the memory space pointed to by the provided pointer. + * + * This pointer must have been returned by a previous call

Re: [PATCH v4 01/17] memzone: fix use after free in tracing

2024-10-01 Thread Burakov, Anatoly
On 9/30/2024 8:43 PM, Stephen Hemminger wrote: Using the freed value for tracing is not a good idea. Although it is harmless for tracing, it will cause analyzers to flag this as unsafe. Signed-off-by: Stephen Hemminger Acked-by: Chengwen Feng --- lib/eal/common/eal_common_memzone.c | 3 ++-

Re: [PATCH v4 17/17] eal: add function attributes for allocation functions

2024-10-01 Thread Burakov, Anatoly
On 9/30/2024 8:44 PM, Stephen Hemminger wrote: The allocation functions take a alignment argument that can be useful to hint the compiler optimizer. This is supported by Gcc and Clang but only useful with Gcc because Clang gives warning if alignment is 0. Recent versions of GCC have a malloc at

Re: [RFC 0/2] introduce LLC aware functions

2024-09-13 Thread Burakov, Anatoly
On 9/12/2024 1:50 PM, Varghese, Vipin wrote: [Public] Snipped Based on the discussions we agreed on sharing version-2 FRC for extending API as `rte_get_next_lcore_extnd` with extra argument as `flags`. As per my ideation, for the API ` rte_get_next_sibling_core`, the above

Re: [PATCH v1 1/1] net/ixgbe: update base code README

2024-09-09 Thread Burakov, Anatoly
On 9/9/2024 10:36 AM, Anatoly Burakov wrote: When last driver update was performed, README was not updated with data on latest shared code package generation date. Update README to reflect the date of last shared code package generation. Signed-off-by: Anatoly Burakov --- drivers/net/ixgbe/ba

Re: [PATCH v3 1/8] build: split dependencies into mandatory and optional

2024-09-09 Thread Burakov, Anatoly
On 9/6/2024 4:51 PM, Bruce Richardson wrote: On Wed, Sep 04, 2024 at 04:08:29PM +0100, Anatoly Burakov wrote: Allow specifying dependencies as either mandatory or optional. This does not change anything about the build, but it is useful for tooling to know if a dependency is required or not.

Re: [RFC PATCH v1 0/5] Adjust wording for NUMA vs. socket ID in DPDK

2024-09-06 Thread Burakov, Anatoly
On 9/6/2024 3:07 PM, Bruce Richardson wrote: On Fri, Sep 06, 2024 at 03:02:53PM +0200, Morten Brørup wrote: From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] Sent: Friday, 6 September 2024 14.46 On 9/6/2024 2:37 PM, Morten Brørup wrote: From: Anatoly Burakov [mailto:anatoly.bura

Re: [RFC PATCH v1 0/5] Adjust wording for NUMA vs. socket ID in DPDK

2024-09-06 Thread Burakov, Anatoly
On 9/6/2024 2:37 PM, Morten Brørup wrote: From: Anatoly Burakov [mailto:anatoly.bura...@intel.com] Sent: Friday, 6 September 2024 13.47 To: dev@dpdk.org Subject: [RFC PATCH v1 0/5] Adjust wording for NUMA vs. socket ID in DPDK While initially, DPDK has used the term "socket ID" to refer to physi

Re: [PATCH v1 1/1] usertools: add DPDK build directory setup script

2024-09-06 Thread Burakov, Anatoly
On 9/6/2024 10:28 AM, Morten Brørup wrote: From: fengchengwen [mailto:fengcheng...@huawei.com] Sent: Friday, 6 September 2024 09.41 On 2024/9/5 15:29, David Marchand wrote: On Wed, Sep 4, 2024 at 5:17 PM Anatoly Burakov wrote: Enter this script. It relies on Meson's introspection capabilitie

  1   2   3   4   5   6   7   8   9   10   >